Ros-dev

ros-dev@reactos.org

5790 discussions

Re: [ros-dev] [ros-diffs] [mkupfer] 40173: - Disable "Back" in last page of syssetup, because it doesn't make any sense.
by Gabriel ilardi 22 Mar '09

22 Mar '09

This hides bug 2675. > Date: Sun, 22 Mar 2009 16:36:17 +0000 > To: ros-diffs(a)reactos.org > From: mkupfer(a)svn.reactos.org > Subject: [ros-diffs] [mkupfer] 40173: - Disable "Back" in last page of syssetup, because it doesn't make any sense. > > Author: mkupfer > Date: Sun Mar 22 19:36:16 2009 > New Revision: 40173 > > URL: http://svn.reactos.org/svn/reactos?rev=40173&view=rev > Log: > - Disable "Back" in last page of syssetup, because it doesn't make any sense. > > Modified: > trunk/reactos/dll/win32/syssetup/wizard.c > > Modified: trunk/reactos/dll/win32/syssetup/wizard.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/syssetup/wizard.… > ============================================================================== > --- trunk/reactos/dll/win32/syssetup/wizard.c [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/syssetup/wizard.c [iso-8859-1] Sun Mar 22 19:36:16 2009 > @@ -1990,22 +1990,13 @@ > { > case PSN_SETACTIVE: > /* Enable the correct buttons on for the active page */ > - PropSheet_SetWizButtons(GetParent(hwndDlg), PSWIZB_BACK | PSWIZB_FINISH); > + PropSheet_SetWizButtons(GetParent(hwndDlg), PSWIZB_FINISH); > > SendDlgItemMessage(hwndDlg, IDC_RESTART_PROGRESS, PBM_SETRANGE, 0, > MAKELPARAM(0, 300)); > SendDlgItemMessage(hwndDlg, IDC_RESTART_PROGRESS, PBM_SETPOS, 0, 0); > SetTimer(hwndDlg, 1, 50, NULL); > break; > - > - case PSN_WIZBACK: > - /* Handle a Back button click, if necessary */ > - KillTimer(hwndDlg, 1); > - > - /* Skip the progress page */ > - SetWindowLong(hwndDlg, DWL_MSGRESULT, IDD_DATETIMEPAGE); > - SetupData.UnattendSetup = FALSE; > - return TRUE; > > case PSN_WIZFINISH: > /* Handle a Finish button click, if necessary */ > _________________________________________________________________ Scopri le keyword più cercate della settimana! http://clk.atdmt.com/GBL/go/136430524/direct/01/

1 0

Re: [ros-dev] [ros-diffs] [cgutman] 40142: - Reorganize NDIS code
by Aleksey Bragin 21 Mar '09

21 Mar '09

What was wrong with a previous naming convention? x0gone.c were supposed to contain implementation of functions, which became legacy in that major version of NDIS. Now you substituted it with x0stubs.c, which means it's going to contain stubs only. Was that intentionally? On Mar 21, 2009, at 12:29 AM, cgutman(a)svn.reactos.org wrote: > Author: cgutman > Date: Sat Mar 21 00:29:53 2009 > New Revision: 40142 > > URL: http://svn.reactos.org/svn/reactos?rev=40142&view=rev > Log: > - Reorganize NDIS code > > Added: > trunk/reactos/drivers/network/ndis/ndis/30stubs.c > - copied, changed from r40140, trunk/reactos/drivers/network/ > ndis/ndis/40gone.c > trunk/reactos/drivers/network/ndis/ndis/40stubs.c > - copied, changed from r40141, trunk/reactos/drivers/network/ > ndis/ndis/50gone.c > trunk/reactos/drivers/network/ndis/ndis/50stubs.c > - copied, changed from r40113, trunk/reactos/drivers/network/ > ndis/ndis/stubs.c > trunk/reactos/drivers/network/ndis/ndis/misc.c (with props) > Removed: > trunk/reactos/drivers/network/ndis/ndis/40gone.c > trunk/reactos/drivers/network/ndis/ndis/50gone.c > trunk/reactos/drivers/network/ndis/ndis/stubs.c

2 1

advapi self forwarding and kernel32 self imports
by Timo Kreuzer 21 Mar '09

21 Mar '09

Hi, 1.) Is there a reason, why some exports of advapi32 are forwarded instead of just set to the proper function? Forwarding is more work for the loader. 2.) kernel32 imports from itself. Which will probably lead to the same result as bug 4292. This is because the mingw lib imports from kernel32 and requires kernel32 library to be added afterwards. But rbuild likes to add mingw lib at the very end of the library list which requires adding kernel32 as a library to mingw_common to resolve imports. This should be fixed and mingw added as the very first library. I wonder if those 2 are even allowed on Windows, as both don't make sense. Timo

1 0

Re: [ros-dev] [ros-diffs] [tkreuzer] 40115: rename DCs pDc_Attr to pdcattr, like in gdikdx. Make pdcattr alsways point to a DC_ATTR, either the user mode struct or the local part. Get rid of all the If (!pdcattr) pdcattr = &dc->Dc_Attr; That are not
by James Tabor 20 Mar '09

20 Mar '09

Hi All! Good to see it go, I had it in as a safeguard, and now we moved on to the next phase of the rewrite! Thanks Timo! James 8^D On Fri, Mar 20, 2009 at 4:47 AM, Aleksey Bragin <aleksey(a)reactos.org> wrote: > Oh, finally! ;) > > On Mar 20, 2009, at 7:51 AM, tkreuzer(a)svn.reactos.org wrote: > >> Author: tkreuzer >> Date: Fri Mar 20 07:51:26 2009 >> New Revision: 40115 >> >> URL: http://svn.reactos.org/svn/reactos?rev=40115&view=rev >> Log: >> rename DCs pDc_Attr to pdcattr, like in gdikdx. >> Make pdcattr alsways point to a DC_ATTR, either the user mode >> struct or the local part. Get rid of all the If (!pdcattr) pdcattr >> = &dc->Dc_Attr; That are not required anymore. >

1 0

20 Mar '09

Oh, finally! ;) On Mar 20, 2009, at 7:51 AM, tkreuzer(a)svn.reactos.org wrote: > Author: tkreuzer > Date: Fri Mar 20 07:51:26 2009 > New Revision: 40115 > > URL: http://svn.reactos.org/svn/reactos?rev=40115&view=rev > Log: > rename DCs pDc_Attr to pdcattr, like in gdikdx. > Make pdcattr alsways point to a DC_ATTR, either the user mode > struct or the local part. Get rid of all the If (!pdcattr) pdcattr > = &dc->Dc_Attr; That are not required anymore.

1 0

[ros-diffs] [fireball] 40106: - Don't try to be smarter than Windows and don't copy background/foreground color from the original DC.
by James Tabor 20 Mar '09

20 Mar '09

Introduced in revision 6042. Over think was a norm back then.

1 0

header hack.... eeh workaround ;)
by Timo Kreuzer 17 Mar '09

17 Mar '09

Hi, I's like to suggest a workaround to the problem that we have to deal with both RECT and RECTL structures in win32k and as they are incompatible need to typecast in a lot of places. RECTL is what the DDI interface uses (almost) exclusively. While the NtGdi Interface and a lot of User structures also use RECT. Both structures are equal, but not compatible when it comes to assigning one to another, So we need to do all these nasty typecasts. My suggestion is adding some defines after the inclusion of windef.h: #define RECT RECTL #define PRECT PRECTL #define LPRECT LPRECTL #define LPCRECT LPCRECTL same for POINT and POINTL I'd like to hear your opinion on that. Thanks, Timo

2 2

Re: [ros-dev] [ros-diffs] [dgorbachev] 40014: Trying to fix boot breakage.
by Timo Kreuzer 14 Mar '09

14 Mar '09

dgorbachev(a)svn.reactos.org schrieb: > Author: dgorbachev > Date: Sat Mar 14 21:13:32 2009 > New Revision: 40014 > > URL: http://svn.reactos.org/svn/reactos?rev=40014&view=rev > Log: > Trying to fix boot breakage. > Try harder, please ;-P http://reactos.org:8010/builders/ReactOS_%28Debug%29/builds/13888/steps/tes… > Modified: > trunk/reactos/ntoskrnl/mm/freelist.c > trunk/reactos/ntoskrnl/mm/kmap.c > > Modified: trunk/reactos/ntoskrnl/mm/freelist.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/freelist.c?rev… > ============================================================================== > --- trunk/reactos/ntoskrnl/mm/freelist.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/mm/freelist.c [iso-8859-1] Sat Mar 14 21:13:32 2009 > @@ -942,6 +942,21 @@ > return NumberOfPagesFound; > } > > +static > +NTSTATUS > +MiZeroPageInternal(PFN_TYPE Page) > +{ > + PVOID TempAddress; > + > + TempAddress = MiMapPageToZeroInHyperSpace(Page); > + if (TempAddress == NULL) > + { > + return(STATUS_NO_MEMORY); > + } > + memset(TempAddress, 0, PAGE_SIZE); > + return(STATUS_SUCCESS); > +} > + > NTSTATUS > NTAPI > MmZeroPageThreadMain(PVOID Ignored) > @@ -989,7 +1004,7 @@ > PageDescriptor->Flags.Type = MM_PHYSICAL_PAGE_USED; > KeReleaseQueuedSpinLock(LockQueuePfnLock, oldIrql); > Pfn = PageDescriptor - MmPageArray; > - Status = MiZeroPage(Pfn); > + Status = MiZeroPageInternal(Pfn); > > oldIrql = KeAcquireQueuedSpinLock(LockQueuePfnLock); > if (PageDescriptor->MapCount != 0) > > Modified: trunk/reactos/ntoskrnl/mm/kmap.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/kmap.c?rev=400… > ============================================================================== > --- trunk/reactos/ntoskrnl/mm/kmap.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/mm/kmap.c [iso-8859-1] Sat Mar 14 21:13:32 2009 > @@ -16,18 +16,23 @@ > /* GLOBALS *****************************************************************/ > > /* FUNCTIONS ***************************************************************/ > + > NTSTATUS > NTAPI > MiZeroPage(PFN_TYPE Page) > { > + PEPROCESS Process; > + KIRQL Irql; > PVOID TempAddress; > > - TempAddress = MiMapPageToZeroInHyperSpace(Page); > + Process = (PEPROCESS)KeGetCurrentThread()->ApcState.Process; > + TempAddress = MiMapPageInHyperSpace(Process, Page, &Irql); > if (TempAddress == NULL) > { > return(STATUS_NO_MEMORY); > } > memset(TempAddress, 0, PAGE_SIZE); > + MiUnmapPageInHyperSpace(Process, TempAddress, Irql); > return(STATUS_SUCCESS); > } > > > >

1 0

Re: [ros-dev] [ros-diffs] [dgorbachev] 40008: Return to an old idea of MiMapPageToZeroInHyperSpace(), "fix" bug #4267.
by Timo Kreuzer 14 Mar '09

14 Mar '09

This breaks boot. http://reactos.org:8010/builders/ReactOS_%28Debug%29/builds/13880/steps/tes… dgorbachev(a)svn.reactos.org schrieb: > Author: dgorbachev > Date: Sat Mar 14 04:20:18 2009 > New Revision: 40008 > > URL: http://svn.reactos.org/svn/reactos?rev=40008&view=rev > Log: > Return to an old idea of MiMapPageToZeroInHyperSpace(), "fix" bug #4267. > > Modified: > trunk/reactos/ntoskrnl/mm/hypermap.c > > Modified: trunk/reactos/ntoskrnl/mm/hypermap.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/hypermap.c?rev… > ============================================================================== > --- trunk/reactos/ntoskrnl/mm/hypermap.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/mm/hypermap.c [iso-8859-1] Sat Mar 14 04:20:18 2009 > @@ -14,8 +14,11 @@ > > /* GLOBALS ********************************************************************/ > > +#define MI_ZEROING_PTES 255 > + > PMMPTE MmFirstReservedMappingPte; > PMMPTE MmLastReservedMappingPte; > +PMMPTE MmFirstReservedZeroingPte; > MMPTE HyperTemplatePte; > PEPROCESS HyperProcess; > KIRQL HyperIrql; > @@ -40,6 +43,8 @@ > MmFirstReservedMappingPte = MiAddressToPte(MI_MAPPING_RANGE_START); > MmLastReservedMappingPte = MiAddressToPte(MI_MAPPING_RANGE_END); > MmFirstReservedMappingPte->u.Hard.PageFrameNumber = MI_HYPERSPACE_PTES; > + MmFirstReservedZeroingPte = MiAddressToPte(MI_ZERO_PTE); > + MmFirstReservedZeroingPte->u.Hard.PageFrameNumber = MI_ZEROING_PTES; > } > > PVOID > @@ -134,38 +139,62 @@ > { > MMPTE TempPte; > PMMPTE PointerPte; > + PFN_NUMBER Offset; > PVOID Address; > - > + > // > // Never accept page 0 > // > ASSERT(Page != 0); > - > + > // > // Build the PTE > // > TempPte = HyperTemplatePte; > TempPte.u.Hard.PageFrameNumber = Page; > - > - // > - // Get the Zero PTE and its address > - // > - PointerPte = MiAddressToPte(MI_ZERO_PTE); > + > + // > + // Pick the first zeroing PTE > + // > + PointerPte = MmFirstReservedZeroingPte; > + > + // > + // Now get the first free PTE > + // > + Offset = PFN_FROM_PTE(PointerPte); > + if (!Offset) > + { > + // > + // Reset the PTEs > + // > + Offset = MI_ZEROING_PTES; > + KeFlushProcessTb(); > + } > + > + // > + // Prepare the next PTE > + // > + PointerPte->u.Hard.PageFrameNumber = Offset - 1; > + > + // > + // Write the current PTE > + // > + PointerPte += Offset; > + *PointerPte = TempPte; > + > + // > + // Return the address > + // > Address = (PVOID)((ULONG_PTR)PointerPte << 10); > - > - // > - // Invalidate the old address > - // > - __invlpg(Address); > - > - // > - // Write the current PTE > - // > - TempPte.u.Hard.PageFrameNumber = Page; > - *PointerPte = TempPte; > - > - // > - // Return the address > - // > return Address; > } > + > +VOID > +NTAPI > +MiUnmapPageInZeroSpace(IN PVOID Address) > +{ > + // > + // Blow away the mapping > + // > + MiAddressToPte(Address)->u.Long = 0; > +} > > >

1 0

Re: [ros-dev] [ros-diffs] [mkupfer] 39871: Sascha Clausen <r4v3r AT hotmail DOT de> - Draw bullet for menu radio group. - See issue #4193 for details.
by Ged 13 Mar '09

13 Mar '09

Looking at the patch only this looks wrong to me. Assuming this is radio button it should use the marlett font. Ged. -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of mkupfer(a)svn.reactos.org Sent: 04 March 2009 16:30 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [mkupfer] 39871: Sascha Clausen <r4v3r AT hotmail DOT de> - Draw bullet for menu radio group. - See issue #4193 for details. Author: mkupfer Date: Wed Mar 4 19:29:57 2009 New Revision: 39871 URL: http://svn.reactos.org/svn/reactos?rev=39871&view=rev Log: Sascha Clausen <r4v3r AT hotmail DOT de> - Draw bullet for menu radio group. - See issue #4193 for details. Modified: trunk/reactos/dll/win32/user32/windows/draw.c Modified: trunk/reactos/dll/win32/user32/windows/draw.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/d… ============================================================================== --- trunk/reactos/dll/win32/user32/windows/draw.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/user32/windows/draw.c [iso-8859-1] Wed Mar 4 19:29:57 2009 @@ -1276,11 +1276,12 @@ yc = myr.top + SmallDiam - SmallDiam/2; i = 234*SmallDiam/750; i = i < 1 ? 1 : i; - myr.left = xc - i+i/2; + myr.left = xc - i/2; myr.right = xc + i/2; - myr.top = yc - i+i/2; + myr.top = yc - i/2; myr.bottom = yc + i/2; - Pie(dc, myr.left, myr.top, myr.right, myr.bottom, xe, ye, xe, ye); + // if the start and the end point are equal, Pie() only draws a single line, so start one pixel lower + Pie(dc, myr.left, myr.top, myr.right, myr.bottom, xe, ye+1, xe, ye); break; case DFCS_MENUCHECK:

4 3

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev