Ros-dev

ros-dev@reactos.org

1 participants
5793 discussions

Re: [ros-dev] ReactOS Development Process
by Aleksey Bragin 03 Oct '07

03 Oct '07

Herve suggests using a kind of a continuous integration system, describing it this way: * precommit hook if commit not to trunk, abort precommit hook create a REV-abc branch from trunk and do the commit here * regularly go through all REV-abc branches (increasing ABC numbers) test it if not, inform user or whatever that test failed and go to next branch try to merge to trunk if not, inform user or whatever that merge failed and go to next branch commit to trunk delete the branch go to next branch * pros: devs and users will have new version to trunk once they are tested devs and users only have to know trunk * cons: changes are not immediatly available for everyone, except in REV-abc branch On Oct 3, 2007, at 12:50 PM, Aleksey Bragin wrote: > Hello, > recently, different people raised a question: How should development > process evolve with time, when ReactOS has more (much more) > developers willing to contribute code?

5 4

Bugzilla error when sending notifications
by Marc Piulachs 02 Oct '07

02 Oct '07

I'm getting this error when posting/modifying a bugreport Bugzilla has suffered an internal error. Please save this page and send it to aleksey(a)reactos.org with details of what you were doing at the time this message appeared. URL: http://www.reactos.org/bugzilla/process_bug.cgi There was an error sending mail from 'ReactOS.Bugzilla' to 'hpoussin(a)reactos.org':error when closing pipe to /usr/lib/sendmail:

2 1

Re: [ros-dev] [ros-diffs] [hpoussin] 29352: Do not hardcode cdrom directory
by Pablo Menichini 02 Oct '07

02 Oct '07

> --- trunk/reactos/base/setup/usetup/drivesup.c (original) > +++ trunk/reactos/base/setup/usetup/drivesup.c Tue Oct 2 16:16:45 2007 > @@ -35,7 +35,8 @@ ... > + if (Ptr) > + RtlCreateUnicodeString(SourceRootDir, Ptr); > + else > + RtlCreateUnicodeString(SourceRootDir, L""); > + > if (Ptr != NULL) > - *Ptr = 0; > - > + *Ptr = 0; You can put *Ptr = 0 in the if-else Pablo

1 0

SmartPDF (aka SumatraPDF) in rosapps, linking problems
by Klemens Friedl 02 Oct '07

02 Oct '07

SumatraPDF is a lightweight Win32 pdf viewer app http://blog.kowalczyk.info/software/sumatrapdf/ http://code.google.com/p/sumatrapdf/ The name "sumatra" sounds weird (for an app), so I renamed the directory and the output exe file to "SmartPDF" (based on suggestions from #reactos). SumatraPDF comes with VS 2k5 project files. I have fixed various compile issues so that libjpeg, poppler, fitz/mupdf and sumatra app itself compile without errors in mingw (RosBE 0.3.7.2 Win32). All code changes can be found by grep/search for "@note:", I added a comment to each changed code line. The remaining problem is the linking issue. Currently it does NOT link correctly. Timo Kreuzer mentioned on 2007-09-27 in #reactos something that may be related to the issue: "it [sumatrapdf] imports a function from winspool.drv by number, when you add that number to winspool.def, it starts" Please have a look at it, fixes are appreciated :) Klemens

4 9

Kernel streaming header mess / GUIDs
by reactos-development＠silverblade.co.uk 30 Sep '07

30 Sep '07

Hi, Alex nudged me in IRC about this, but sadly I've not quite figured this out yet. It appears my definitions for Kernel Streaming GUIDs are not quite right. This results in ugly code like so: -- const GUID foo_audio_category = STATIC_KSCATEGORY_AUDIO; DoSomethingWithTheGuid(&foo_audio_category); -- Which consequently results in a barrage of compiler complaints about brace initialization. It should be possible to just do: DoSomethingWithTheGuid(KSCATEGORY_AUDIO); I'm clearly going wrong somewhere in KS.H or KSMEDIA.H but to be honest am blind to whatever is causing the problem. If anyone can figure out what I'm doing wrong here, I'd appreciate it. Thanks. -Andrew

5 4

Re: [ros-dev] [ros-diffs] [fireball] 28351: Dmitry Chapyshev <lentind@yandex.ru>: - Fix so that letters like "p" or "y" are correctly displayed in messageboxes.
by Ged 29 Sep '07

29 Sep '07

IMO, this change is wrong, it's a hack to a problem we have with text placement. Text is cut short on other controls too, not just messageboxes. Check out labels for example. Ged. fireball(a)svn.reactos.org wrote: > Author: fireball > Date: Wed Aug 15 18:49:44 2007 > New Revision: 28351 > > URL: http://svn.reactos.org/svn/reactos?rev=28351&view=rev > Log: > Dmitry Chapyshev <lentind(a)yandex.ru>: > - Fix so that letters like "p" or "y" are correctly displayed in messageboxes. > > Modified: > trunk/reactos/dll/win32/user32/windows/messagebox.c > > Modified: trunk/reactos/dll/win32/user32/windows/messagebox.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/m… > ============================================================================== > --- trunk/reactos/dll/win32/user32/windows/messagebox.c (original) > +++ trunk/reactos/dll/win32/user32/windows/messagebox.c Wed Aug 15 18:49:44 2007 > @@ -491,7 +491,7 @@ > txtrect.right = GetSystemMetrics(SM_CXSCREEN) / 5 * 4; > if(Icon) > txtrect.right -= GetSystemMetrics(SM_CXICON) + MSGBOXEX_SPACING; > - txtrect.top = txtrect.left = txtrect.bottom = 0; > + txtrect.top = txtrect.left = txtrect.bottom = 5; > SelectObject(hDC, hFont); > if (textlen != 0) > { > > > >

7 6

Note for devs about translations
by Heis Spiter 29 Sep '07

29 Sep '07

Hello, I'd just like to do a remark about ReactOS apps, dlls, which be translated. When a dev change something to the interface, or the core app, it could be great to update EVERY language file (*.rc) and not only some of them (or even worse : only english one). It does not take many times to do (I know because I've already done that), and for a translator that's quite easier to see what has changed without having to compare his language file and the english one. And most of all, it avoids uncomplete, or outdated language files. Finally, for end-user, that's better : that's even better to have English string instead of nothing (I mean blank string). Thanks, Pierre Schweitzer, French Language Maintainer

1 0

Re: [ros-dev] Audit
by Aleksey Bragin 24 Sep '07

24 Sep '07

On Sep 22, 2007, at 10:19 PM, João Jerónimo wrote: > The point of a possible 3rd party audit is raising the legal > credibility of > the ReactOS project by ensuring that no tainted code is left in the > source > tree, right? The word "tainted" is actually quite wrong, and is being misused everywhere. A tea was tainted by polonium in a not-so-recent accident in the UK. ReactOS is not a tea, and we have no "polonium" commiters. There will be a WineConf event in 1 or 2 weeks, and they say they are going to clear up the legal situation around Wine, around SFLC audit and around requirements to the developers, whose code may be commited to the tree. When they do it, I would be very glad to know those requirements, and enforce them on ReactOS developers, so that we are on the common ground. > > Well, if the project is going to wait until more modules stabilize, > won't > this stabilization process obfuscate most of the tainted source > code, and > make them hard to find? Your mind is ahead of you. "Taint obfuscated code", "Obfuscate tainted code", ... Your question is obfuscated and may be tainted, I won't answer it. WBR, Aleksey Bragin.

9 19

Re: [ros-dev] Audit
by Aleksey Bragin 24 Sep '07

24 Sep '07

Please stop rumouring this topic. I clearly said "if there are strong circumstances, in future, only then we will think about doing 3rd party audit, and only from agreement of all devs". That's 3 or 4 years away from now, if such legal problems ever happen. Also noone ever said SFLC is taking up copyrights to themselves. At least it's first time I hear this. I just grepped Wine source code base for word "SFLC" - doesn't appear anywhere. Also, open up any of Wine's source code file, you'll see "Copyright 200x Person's Name". And again, I didn't suggest SFLC or FSF or whoever. Time will show who and if we need, and who and if agrees to. WBR, Aleksey Bragin. On Sep 24, 2007, at 2:58 PM, Magnus Olsen wrote: > It seam u fall into he SFLC traps they are trying push doing the > audlt of > ros from a 3 part project > of ros, and we shall obay theirs rules it mean all api that is not > document > in msdn shall be remove > and so on. That mean 80% of ntoskrnl will go away, for around 80% of > ntoskrnl are not in msdn > 80% of win32k will go aways, for thuse api are not in msdn, then > shall we > not talk about audio > no audio system and so on. > > that mean no ros, if we play after SLFC and we need also write > papper give > up our copyright to > them. no thanks

1 0

Re: [ros-dev] Audit
by Aleksey Bragin 23 Sep '07

23 Sep '07

Well-well, please calm down, we had enough flamewars, a new one is not necessary. No decisions are made, and no decisions are going to be made without agreement with all our developers. WBR, Aleksey Bragin. On Sep 23, 2007, at 3:40 PM, Ged wrote: > James Tabor wrote: >> >> Wine is the Pot calling the kettle BLACK! Bunch of RE coders using >> smoke and >> mirrors when it comes to case testing! It's a easy out! >> > > I agree with Aleksey, we must adopt their way of working in the > hope of > rebuilding the bridges and additionally improving our credability > within > the open source world. If this means offering ourselves to an external > audit, then so be it. We can't be a hobbiest project forever if we aim > to bring ReactOS to the public sector as a viable alternative to > Windows. > > > Ged.

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev