Ros-dev

ros-dev@reactos.org

1 participants
5793 discussions

Re: [ros-dev] [ros-diffs] [cfinck] 28423: - Always include"wine/unicode.h" before all other headers, when we need the wchar_t type. unicode.h includes windef.h, which includes winnt.h, which has the handling for the wchar_t type. As it's the firstinc
by Steven Edwards 22 Aug '07

22 Aug '07

On 8/19/07, Colin Finck <mail(a)colinfinck.de> wrote: > These changes were made to properly compile ReactOS under a Mac OS X host. > They have nothing to do with MSVC or the Microsoft SDK headers. Sorry I was not clear about what I meant in my rant and sounded bitchy > Mac OS X defines its own wchar_t type in "ctype.h". But it uses _WCHAR_T for > reporting that the type has been defined and not _WCHAR_T_DEFINED like > Windows does. > This is why I needed to add a handling for _WCHAR_T in "winnt.h". > But if "ctype.h" is now included before "winnt.h", these changes don't have > any effect. This is why I changed the header order. > > Of course, there might be other "solutions" to this problem (like adding all > possible definitions that wchar_t has been defined into the Makefile), but > this is the simplest one. > And I see no reason not to do this for fixing this problem. It makes anyone doing a diff have more stuff to have to workaround. There are constantly minor updates and fixes to the unicode tables in Wine because Microsoft did not just generate them from the uncode.org spec but added a bunch of stuff. Wine currently builds on OS X with the header order as it stands and figures out someway around it. I guess its using a define in the makefile for _WCHAR_T generated by configure or something. I have not looked so don't quote me on that. I don't really care if you want to change it to make it less of a hassle to build on OS X for ReactOS but its just going to break again next time someone syncs the unicode lib so its better if you can work around it in the makefile. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

6 15

Re: [ros-dev] [ros-diffs] [fireball] 28448: - Allow pci read/writes during proving BAR's size operation
by Aleksey Bragin 22 Aug '07

22 Aug '07

Hi, sorry - no, this is an olpc-specific code in olpc branch, I have to emulate some PCI hardware (the code is taken from Linux), however ReactOS's PCI access is more complicated, and thus I slightly improved the code. As for that crash - hmm. I will try the real hardware today maybe. WBR, Aleksey Bragin. On Aug 22, 2007, at 7:31 AM, James Tabor wrote: > Hi! > Could this be related to 28448? I mean could it fix this? The > buffer address > goes down from 8XXXXX to 3fffff (yes backwards, I watch it) and > faults. > This fault was before 28448 and on real hardware. Display is normal > and mouse > moves. > Thanks, > James > > Unhandled exception > ExceptionCode: c0000005 > Faulting Address: 3fffff > Address: 78010e04 C:\ReactOS\system32\msvcrt.dll > CS:EIP 1b:78010e04 > DS 23 ES 23 FS 3b GS 0 > EAX: 0010ad41 EBX: 003fffff ECX: 00001000 > EDX: 009a2068 EBP: 0087f5b4 ESI: 00000002 ESP: 0087f5a0 > EDI: 009a2068 EFLAGS: 00010217 > Frames: > 78000000+122c6 C:\ReactOS\system32\msvcrt.dll > 400000+742eb C:\ReactOS\explorer.exe > 400000+609f4 C:\ReactOS\explorer.exe > > _write lib/sdk/crt/io/write.c Line 55 > . > . > . > while (_nbyte--) { > ----> if (*in == 0x0a) { > . > . > . > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev

1 0

[ros-diffs] [fireball] 28448: - Allow pci read/writes during proving BAR's size operation
by James Tabor 22 Aug '07

22 Aug '07

Hi! Could this be related to 28448? I mean could it fix this? The buffer address goes down from 8XXXXX to 3fffff (yes backwards, I watch it) and faults. This fault was before 28448 and on real hardware. Display is normal and mouse moves. Thanks, James Unhandled exception ExceptionCode: c0000005 Faulting Address: 3fffff Address: 78010e04 C:\ReactOS\system32\msvcrt.dll CS:EIP 1b:78010e04 DS 23 ES 23 FS 3b GS 0 EAX: 0010ad41 EBX: 003fffff ECX: 00001000 EDX: 009a2068 EBP: 0087f5b4 ESI: 00000002 ESP: 0087f5a0 EDI: 009a2068 EFLAGS: 00010217 Frames: 78000000+122c6 C:\ReactOS\system32\msvcrt.dll 400000+742eb C:\ReactOS\explorer.exe 400000+609f4 C:\ReactOS\explorer.exe _write lib/sdk/crt/io/write.c Line 55 . . . while (_nbyte--) { ----> if (*in == 0x0a) { . . .

1 0

Re: [ros-dev] IoCheckEaBufferValidity
by Aleksey Bragin 21 Aug '07

21 Aug '07

Hello, please provide your real name (this is a must for every commit), and also how to test it under Windows (maybe you wrote some test app for this - it would be useful too). WBR, Aleksey Bragin. On Aug 21, 2007, at 3:39 AM, netzimme(a)aim.com wrote: > Hallo > > Have a patch that implemented the function IoCheckEaBufferValidity > in ntoskrnl\io\iomgr\util.c. > Tested with Windows 2000 and Vista Ultimate 64 Bit. > Perhaps some one can comit it for me. > > Thanks > dz >

2 2

IoCheckEaBufferValidity
by netzimme＠aim.com 21 Aug '07

21 Aug '07

Hallo Have a patch that implemented the function IoCheckEaBufferValidity in ntoskrnl\io\iomgr\util.c. Tested with Windows 2000 and Vista Ultimate 64 Bit. Perhaps some one can comit it for me. Thanks dz ________________________________________________________________________ Check Out the new free AIM(R) Mail -- 2 GB of storage and industry-leading spam and email virus protection. =================================================================== --- file.c (revision 28441) +++ file.c (working copy) @@ -1632,6 +1632,7 @@ IN ULONG Options) { KPROCESSOR_MODE AccessMode; + ULONG EaErrorOffset; HANDLE LocalHandle = 0; LARGE_INTEGER SafeAllocationSize; PVOID SystemEaBuffer = NULL; @@ -1732,10 +1733,10 @@ /* Validate the buffer */ Status = IoCheckEaBufferValidity(SystemEaBuffer, EaLength, - NULL); + &EaErrorOffset); if (!NT_SUCCESS(Status)) { - /* FIXME: Fail once function is implemented */ + DPRINT1("FIXME: IoCheckEaBufferValidity failed with Status: %lx\n",Status); } } } Index: util.c =================================================================== --- util.c (revision 28441) +++ util.c (working copy) @@ -129,8 +129,9 @@ return STATUS_SUCCESS; } + /* - * @unimplemented + * @implemented */ NTSTATUS NTAPI @@ -138,10 +139,58 @@ IN ULONG EaLength, OUT PULONG ErrorOffset) { - UNIMPLEMENTED; - return STATUS_NOT_IMPLEMENTED; + PFILE_FULL_EA_INFORMATION EaBufferEnd; + ULONG LenOfEaBuffer; + UINT IntEaLength; + + IntEaLength = EaLength; + EaBufferEnd = EaBuffer; + + while (IntEaLength >= 8) + { + LenOfEaBuffer = EaBufferEnd->EaNameLength+EaBufferEnd->EaValueLength + 9; + if (IntEaLength >= LenOfEaBuffer) + { + if (EaBufferEnd->EaName[EaBufferEnd->EaNameLength]==0) + { + if (EaBufferEnd->NextEntryOffset == 0) + { + IntEaLength = IntEaLength - LenOfEaBuffer; + if (IntEaLength>=0) + { + return STATUS_SUCCESS; + } + } + else + { + LenOfEaBuffer = ((LenOfEaBuffer + 3) & 0xFFFFFFFC); + if (EaBufferEnd->NextEntryOffset == LenOfEaBuffer) + { + if (EaBufferEnd->NextEntryOffset>0) + { + IntEaLength = IntEaLength - EaBufferEnd->NextEntryOffset; + if (IntEaLength>=0) + { + LenOfEaBuffer = EaBufferEnd->NextEntryOffset; + EaBufferEnd = (PFILE_FULL_EA_INFORMATION)((PBYTE)EaBufferEnd + LenOfEaBuffer); + continue; + } + } + } + } + } + } + break; + } + if (ErrorOffset != NULL) + { + *ErrorOffset = (ULONG)((PBYTE)EaBufferEnd - (PBYTE)EaBuffer); + } + + return STATUS_EA_LIST_INCONSISTENT; } + /* * @unimplemented */

2 2

Re: [ros-dev] [ros-diffs] [cfinck] 28423: - Always include "wine/unicode.h" before all other headers, when we need the wchar_t type. unicode.h includes windef.h, which includes winnt.h, which has the handling for the wchar_t type. As it's the first included he
by Steven Edwards 19 Aug '07

19 Aug '07

On 8/19/07, cfinck(a)svn.reactos.org <cfinck(a)svn.reactos.org> wrote: > - Always include "wine/unicode.h" before all other headers, when we need the wchar_t type. Please stop changing the header order. If you need to do this then something is wrong. The Wine headers are mostly correct as far as the PSDK/WDK goes and if you build Wine on MSVC you DO NOT have to make these invasive changes to the source even when using the SDK headers. Fix the ROS headers or work around system limitations some other way. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

2 1

Freedom
by James Tabor 19 Aug '07

19 Aug '07

Hi, I want ReactOS to become free again. From gnu.org, Free software is a matter of the users' freedom to run, copy, distribute, study, change and improve the software. More precisely, it refers to four kinds of freedom, for the users of the software: * The freedom to run the program, for any purpose (freedom 0). * The freedom to study how the program works, and adapt it to your needs (freedom 1). Access to the source code is a precondition for this. * The freedom to redistribute copies so you can help your neighbor (freedom 2). * The freedom to improve the program, and release your improvements to the public, so that the whole community benefits (freedom 3). Access to the source code is a precondition for this. We forget what this is all about. We need to be liberated from the shackles and chains. Replace "Tainted Developers" with this: Referring to Proprietary Programs: Don't in any circumstances refer to any closed source proprietary code for or during your work on ReactOS! (Or to any other proprietary programs, Unix, Novel, Solaris, Microsoft,.) If you have a vague recollection of the internals of a closed source program, this does not absolutely mean you can't write an imitation of it, but do try to organize the imitation internally along different lines, because this is likely to make the details of the software version irrelevant and dissimilar to your results. It's from: http://www.gnu.org/prep/standards/html_node/Reading-Non_002dFree-Code.html#… If is good for FSF/GNU it's good enough for us. I don't think we need to vote on this, just change it! Remember this is GNU/ReactOS! Not SFLC/Wine! Thanks, James

3 2

Remote desktop on ROS
by Gabriel ilardi 15 Aug '07

15 Aug '07

Dear Devs, I've tested a win32 port of rdesktop for linux, and it works in current trunk (http://img440.imageshack.us/my.php?image=rdesktop3hi1.jpg), since our rdp client doesn't work, I was wondering if this one could be included instead, it's released under gpl, perhaps adding a gui, I don't think it's a lot of work, correct me if I'm wrong, you can find the sources here: http://os.american-data.com/rdesktop/win32/ Best regards, gabriel_it Have a nice day! _________________________________________________________________ Scarica GRATIS Internet Explorer 7 personalizzato MSN http://optimizedie7.msn.com/default.aspx?mkt=it-it

1 0

Re: [ros-dev] [ros-diffs] [gedmurphy] 28324: - fix the code, untested *note, shouldn't this be in rosapps?
by Aleksey Bragin 14 Aug '07

14 Aug '07

This should go into rosapps, unless it's being used during the setup process for example (which it is not). WBR, Aleksey Bragin. On Aug 14, 2007, at 12:52 AM, gedmurphy(a)svn.reactos.org wrote: > Author: gedmurphy > Date: Tue Aug 14 00:52:47 2007 > New Revision: 28324 > > URL: http://svn.reactos.org/svn/reactos?rev=28324&view=rev > Log: > - fix the code, untested > *note, shouldn't this be in rosapps? > > Modified: > trunk/reactos/base/applications/network/dwnl/dwnl.c > trunk/reactos/base/applications/network/dwnl/dwnl.rbuild >

1 0

disussion from forum
by 3th.voice＠googlemail.com 13 Aug '07

13 Aug '07

Hi ReactOS guy's, are you not able to discuss a topic in your forum or why did you delete my post in http://www.reactos.org/forum/viewtopic.php?t=4307 ? Here is it again: [quote="jimtabor"] The irc meetings, there are two I think. It was voting on how to do the audit. Later if I remember right, we started movie review and joking around with unrelated issues. [/quote] I'm missing something about the meetings. [url= http://www.reactos.org/archives/public/ros-dev/2006-January/007478.html]Ste…'s mail[/url] starts with: [quote="Steven Edwards"] There has been a lot of talk about possible tainted code in ReactOS and or developers that had access to leaked Microsoft source code. [/quote] and later [quote="Steven Edwards"] We know of four developers who have had access to leaked sources prior to working on ReactOS.. [/quote] Depend on the [url=http://www.reactos.org/en/dev_legalreview.html]ReactOSproject development policy[/url] [quote="ReactOS project development policy"] Developers who have had access to proprietary source code that would have originally fallen under trade secret protection (including, for example, the leaked Microsoft Windows source code) are a special case. The copyright issues are unchanged, as are the patent issues, but any developer who has the code is clearly either under an NDA or else does not have a license to possess the code. In the latter case, there is a clear violation of the relevant trade secrets by the developer. As such, this kind of code is unsuitable even for research and understanding. It is the policy of the Project to not take submissions from developers who have or use any such proprietary code in their development efforts for ReactOS. [/quote] this developers have to be banned from the project. Steven's mail or the developer's voting wasn't so restrictive: [quote="Steven Edwards"] 4) any developer that had access to leaked sources is baned from contributing code to the project for any of the modules that are the same as leaked sources they examined. [/quote] The question is, why are the tainted developers not banned? If only a few of the developers had access to the leaked windows source code, it is not a problem to ban them. I think more than four developers had access to the leaked windows source code. In this case it will never get a vote for banning the tainted developers, because they must ban itself. It exists the 'Open letter to all' from Alex. I've got the original mail with all the names from one of the developers. [quote="Alex's 'Open letter to all'"] /*Steven, Aleksey, Mike and myself had leaked windows code and looked at it. KJK, Eric, Filip, Magnus and Marteen had IDA and used it for reverse engineering. 9 developers, and these are only some cases.*/ Herve too, sometimes used IDA to verify some flags (I once helped him understand a weird DEVICE_EXTENSION structure), and Thomas, although against reverse-engineering, also used IDA to verify some implementations, although he said he never used it to actually reverse-engineer, and I believe him, although, once you have seen the taint, it's hard to really psycologically prove how much you were, or were not influenced by it. /*With more then 2/3rds of the entire developer team having broken the law and/or our IP policy, I continued my work in the same way.*/ [/quote] Now the story make sense. The implementation of ReactOS is based on the leaked windows source code and possible more than the four named developers had or have access to this code. [quote="jimtabor"] As you all can see, things have gone on to this project. Money was the key word here. Wine, Casper, GvG, hbirr etc,,, mass manipulation to gain from other peoples work. [/quote] And now it makes sense why you accuse some of the developers, which had left the project, that they have done something for money... The only developer, which has something to do with money, is Alex. In May he was bought by Microsoft.

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev