Ros-dev

ros-dev@reactos.org

1 participants
5790 discussions

by Aleksey Bragin

Hello, please provide your real name (this is a must for every commit), and also how to test it under Windows (maybe you wrote some test app for this - it would be useful too). WBR, Aleksey Bragin. On Aug 21, 2007, at 3:39 AM, netzimme(a)aim.com wrote: > Hallo > > Have a patch that implemented the function IoCheckEaBufferValidity > in ntoskrnl\io\iomgr\util.c. > Tested with Windows 2000 and Vista Ultimate 64 Bit. > Perhaps some one can comit it for me. > > Thanks > dz >

18 years

IoCheckEaBufferValidity

by netzimme＠aim.com

Hallo Have a patch that implemented the function IoCheckEaBufferValidity in ntoskrnl\io\iomgr\util.c. Tested with Windows 2000 and Vista Ultimate 64 Bit. Perhaps some one can comit it for me. Thanks dz ________________________________________________________________________ Check Out the new free AIM(R) Mail -- 2 GB of storage and industry-leading spam and email virus protection. =================================================================== --- file.c (revision 28441) +++ file.c (working copy) @@ -1632,6 +1632,7 @@ IN ULONG Options) { KPROCESSOR_MODE AccessMode; + ULONG EaErrorOffset; HANDLE LocalHandle = 0; LARGE_INTEGER SafeAllocationSize; PVOID SystemEaBuffer = NULL; @@ -1732,10 +1733,10 @@ /* Validate the buffer */ Status = IoCheckEaBufferValidity(SystemEaBuffer, EaLength, - NULL); + &EaErrorOffset); if (!NT_SUCCESS(Status)) { - /* FIXME: Fail once function is implemented */ + DPRINT1("FIXME: IoCheckEaBufferValidity failed with Status: %lx\n",Status); } } } Index: util.c =================================================================== --- util.c (revision 28441) +++ util.c (working copy) @@ -129,8 +129,9 @@ return STATUS_SUCCESS; } + /* - * @unimplemented + * @implemented */ NTSTATUS NTAPI @@ -138,10 +139,58 @@ IN ULONG EaLength, OUT PULONG ErrorOffset) { - UNIMPLEMENTED; - return STATUS_NOT_IMPLEMENTED; + PFILE_FULL_EA_INFORMATION EaBufferEnd; + ULONG LenOfEaBuffer; + UINT IntEaLength; + + IntEaLength = EaLength; + EaBufferEnd = EaBuffer; + + while (IntEaLength >= 8) + { + LenOfEaBuffer = EaBufferEnd->EaNameLength+EaBufferEnd->EaValueLength + 9; + if (IntEaLength >= LenOfEaBuffer) + { + if (EaBufferEnd->EaName[EaBufferEnd->EaNameLength]==0) + { + if (EaBufferEnd->NextEntryOffset == 0) + { + IntEaLength = IntEaLength - LenOfEaBuffer; + if (IntEaLength>=0) + { + return STATUS_SUCCESS; + } + } + else + { + LenOfEaBuffer = ((LenOfEaBuffer + 3) & 0xFFFFFFFC); + if (EaBufferEnd->NextEntryOffset == LenOfEaBuffer) + { + if (EaBufferEnd->NextEntryOffset>0) + { + IntEaLength = IntEaLength - EaBufferEnd->NextEntryOffset; + if (IntEaLength>=0) + { + LenOfEaBuffer = EaBufferEnd->NextEntryOffset; + EaBufferEnd = (PFILE_FULL_EA_INFORMATION)((PBYTE)EaBufferEnd + LenOfEaBuffer); + continue; + } + } + } + } + } + } + break; + } + if (ErrorOffset != NULL) + { + *ErrorOffset = (ULONG)((PBYTE)EaBufferEnd - (PBYTE)EaBuffer); + } + + return STATUS_EA_LIST_INCONSISTENT; } + /* * @unimplemented */

18 years

Re: [ros-dev] [ros-diffs] [cfinck] 28423: - Always include "wine/unicode.h" before all other headers, when we need the wchar_t type. unicode.h includes windef.h, which includes winnt.h, which has the handling for the wchar_t type. As it's the first included he

by Steven Edwards

On 8/19/07, cfinck(a)svn.reactos.org <cfinck(a)svn.reactos.org> wrote: > - Always include "wine/unicode.h" before all other headers, when we need the wchar_t type. Please stop changing the header order. If you need to do this then something is wrong. The Wine headers are mostly correct as far as the PSDK/WDK goes and if you build Wine on MSVC you DO NOT have to make these invasive changes to the source even when using the SDK headers. Fix the ROS headers or work around system limitations some other way. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

18 years

Freedom

by James Tabor

Hi, I want ReactOS to become free again. From gnu.org, Free software is a matter of the users' freedom to run, copy, distribute, study, change and improve the software. More precisely, it refers to four kinds of freedom, for the users of the software: * The freedom to run the program, for any purpose (freedom 0). * The freedom to study how the program works, and adapt it to your needs (freedom 1). Access to the source code is a precondition for this. * The freedom to redistribute copies so you can help your neighbor (freedom 2). * The freedom to improve the program, and release your improvements to the public, so that the whole community benefits (freedom 3). Access to the source code is a precondition for this. We forget what this is all about. We need to be liberated from the shackles and chains. Replace "Tainted Developers" with this: Referring to Proprietary Programs: Don't in any circumstances refer to any closed source proprietary code for or during your work on ReactOS! (Or to any other proprietary programs, Unix, Novel, Solaris, Microsoft,.) If you have a vague recollection of the internals of a closed source program, this does not absolutely mean you can't write an imitation of it, but do try to organize the imitation internally along different lines, because this is likely to make the details of the software version irrelevant and dissimilar to your results. It's from: http://www.gnu.org/prep/standards/html_node/Reading-Non_002dFree-Code.html#… If is good for FSF/GNU it's good enough for us. I don't think we need to vote on this, just change it! Remember this is GNU/ReactOS! Not SFLC/Wine! Thanks, James

18 years

Remote desktop on ROS

by Gabriel ilardi

Dear Devs, I've tested a win32 port of rdesktop for linux, and it works in current trunk (http://img440.imageshack.us/my.php?image=rdesktop3hi1.jpg), since our rdp client doesn't work, I was wondering if this one could be included instead, it's released under gpl, perhaps adding a gui, I don't think it's a lot of work, correct me if I'm wrong, you can find the sources here: http://os.american-data.com/rdesktop/win32/ Best regards, gabriel_it Have a nice day! _________________________________________________________________ Scarica GRATIS Internet Explorer 7 personalizzato MSN http://optimizedie7.msn.com/default.aspx?mkt=it-it

18 years

Re: [ros-dev] [ros-diffs] [gedmurphy] 28324: - fix the code, untested *note, shouldn't this be in rosapps?

by Aleksey Bragin

This should go into rosapps, unless it's being used during the setup process for example (which it is not). WBR, Aleksey Bragin. On Aug 14, 2007, at 12:52 AM, gedmurphy(a)svn.reactos.org wrote: > Author: gedmurphy > Date: Tue Aug 14 00:52:47 2007 > New Revision: 28324 > > URL: http://svn.reactos.org/svn/reactos?rev=28324&view=rev > Log: > - fix the code, untested > *note, shouldn't this be in rosapps? > > Modified: > trunk/reactos/base/applications/network/dwnl/dwnl.c > trunk/reactos/base/applications/network/dwnl/dwnl.rbuild >

18 years

disussion from forum

by 3th.voice＠googlemail.com

Hi ReactOS guy's, are you not able to discuss a topic in your forum or why did you delete my post in http://www.reactos.org/forum/viewtopic.php?t=4307 ? Here is it again: [quote="jimtabor"] The irc meetings, there are two I think. It was voting on how to do the audit. Later if I remember right, we started movie review and joking around with unrelated issues. [/quote] I'm missing something about the meetings. [url= http://www.reactos.org/archives/public/ros-dev/2006-January/007478.html]Ste…'s mail[/url] starts with: [quote="Steven Edwards"] There has been a lot of talk about possible tainted code in ReactOS and or developers that had access to leaked Microsoft source code. [/quote] and later [quote="Steven Edwards"] We know of four developers who have had access to leaked sources prior to working on ReactOS.. [/quote] Depend on the [url=http://www.reactos.org/en/dev_legalreview.html]ReactOSproject development policy[/url] [quote="ReactOS project development policy"] Developers who have had access to proprietary source code that would have originally fallen under trade secret protection (including, for example, the leaked Microsoft Windows source code) are a special case. The copyright issues are unchanged, as are the patent issues, but any developer who has the code is clearly either under an NDA or else does not have a license to possess the code. In the latter case, there is a clear violation of the relevant trade secrets by the developer. As such, this kind of code is unsuitable even for research and understanding. It is the policy of the Project to not take submissions from developers who have or use any such proprietary code in their development efforts for ReactOS. [/quote] this developers have to be banned from the project. Steven's mail or the developer's voting wasn't so restrictive: [quote="Steven Edwards"] 4) any developer that had access to leaked sources is baned from contributing code to the project for any of the modules that are the same as leaked sources they examined. [/quote] The question is, why are the tainted developers not banned? If only a few of the developers had access to the leaked windows source code, it is not a problem to ban them. I think more than four developers had access to the leaked windows source code. In this case it will never get a vote for banning the tainted developers, because they must ban itself. It exists the 'Open letter to all' from Alex. I've got the original mail with all the names from one of the developers. [quote="Alex's 'Open letter to all'"] /*Steven, Aleksey, Mike and myself had leaked windows code and looked at it. KJK, Eric, Filip, Magnus and Marteen had IDA and used it for reverse engineering. 9 developers, and these are only some cases.*/ Herve too, sometimes used IDA to verify some flags (I once helped him understand a weird DEVICE_EXTENSION structure), and Thomas, although against reverse-engineering, also used IDA to verify some implementations, although he said he never used it to actually reverse-engineer, and I believe him, although, once you have seen the taint, it's hard to really psycologically prove how much you were, or were not influenced by it. /*With more then 2/3rds of the entire developer team having broken the law and/or our IP policy, I continued my work in the same way.*/ [/quote] Now the story make sense. The implementation of ReactOS is based on the leaked windows source code and possible more than the four named developers had or have access to this code. [quote="jimtabor"] As you all can see, things have gone on to this project. Money was the key word here. Wine, Casper, GvG, hbirr etc,,, mass manipulation to gain from other peoples work. [/quote] And now it makes sense why you accuse some of the developers, which had left the project, that they have done something for money... The only developer, which has something to do with money, is Alex. In May he was bought by Microsoft.

18 years

When will ROS 0.3.3 comming out ?

by theUser BL

Hi! When will ROS 0.3.3 comming out? On July, 21th you anounced 0.3.3 RC1 at http://www.reactos.org/archives/public/ros-dev/2007-July/009571.html You have also changed the front-page, that the actual version is 0.3.3 RC1 and on the downloadside there is now also only 0.3.3 RC1. Will 0.3.3 any time really comming or existing now 0.3.3 RC1 for it instead and the next one will be 0.3.4 ? Btw: On the download-side the links to the CD-Booklets don't exists. It showns now to 0.3.3-RC booklets, but the only one which exists are 0.3.1 booklets. Greatings theuserbl _________________________________________________________________ Sie suchen E-Mails, Dokumente oder Fotos? Die neue MSN Suche Toolbar mit Windows-Desktopsuche liefert in sekundenschnelle Ergebnisse. Jetzt neu! http://desktop.msn.de/ Jetzt gratis downloaden!

18 years

RosBE and autogenerated files

by Sylvain Petreolle

Hi all, I wonder if the RosBE-Windows must be the one which removes autogenerated files. In this case , we have to : - merge the list into RosBE-Unix - publish updated versions when the list changes. - last but not least, the user must have the svn versions of RosBE to get a completely clean tree. Colin suggested we can put it into the Makefile, which would be simpler and more efficient. Kind regards, Sylvain Petreolle (aka Usurp) --- --- --- --- --- --- --- --- --- --- --- --- --- Run your favorite Windows apps with free ReactOS : http://www.reactos.org Listen to non-DRMised Music: http://www.jamendo.com

18 years

Betov is move againts nasm32

by Magnus Olsen

Hi is betov are moreon or idot or brian dead person I can not longer keep my feeling in shape thanks to him It seam that betov is out damges every good open source project on the market. Let see now which project he is trying damges 1.ReactOS It is well known he dislike us, and my advice we ignore him it seam he does not known what his is talking about, and it seam in my eyes his claim is not vaild 2. Sano ReactOS borro some code from this project and that code betov trying convice it is illage 3. SDL Almost same code can be found in SDL for same part we talking about, the code are almost same as Sano code. That mean Betov trying destor this project as well 4. Nasm32 what he have gone after NASM 32, now and claim it is illage for they do not ship the source code in the binary. or the licen agreemtn, and some other stuff more we can read about his stupied http://groups.google.com/group/alt.lang.asm/browse_thread/thread/35cd7e11ff… it is not wonder people do not take him serius he is like a big moron and trying sabtages opensource project world wide for people do not support his rosasm project. And I have follow now his writting for few month and more I read, more it seam it is something wrong with his brain. he calling people with bad names and attact people when they ask him simple question, it mean he socal skill is bad or is is brain dead, that is my cludtions after reading his vaurs stuff he writitning on the net. Or even better bethov is getting pay leading sabtages agaist opensource project that is well known, He maybe getting pay from MS/DMCA/NOVELL how knowns, but it seam not in this case it seam he is complete brian dead.

18 years

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev