Ros-dev

ros-dev@reactos.org

1 participants
5793 discussions

Announcing Neptune OS release v0.1.1: A Windows NT personality for the seL4 microkernel
by Chang Liu 23 Feb '22

23 Feb '22

Hi list, This is not strictly ReactOS development per se but I used a large amount of ReactOS code and it's at least spiritually related to ReactOS, so I'm cross-posting this here to see if I get more comments. Below is the original message I posted on the seL4 mailing list: For the past several months I have been working on a project which is to implement a Windows NT personality for the seL4 microkernel, which I have now taken to call “Neptune OS”, named after the codename for Windows 2000. The project has reached the point where I have implemented enough NT primitives such that a keyboard driver stack (taken from the ReactOS source code) can be loaded (as a user process on seL4), as well as a command prompt (shell), which is also taken from the ReactOS source code (albeit a very early version of ReactOS). These are all kernel-mode Windows device drivers that I’m running as user processes under seL4. The goal is to demonstrate that with modern progress in microkernel design it is indeed possible to realize the original NT design as an object-oriented, message-passing based client-server model microkernel OS (allegedly NT was originally going to be a microkernel, as seen in the NTOSKRNL code that has a ke layer and an ex layer). The project is now on github: github.com/cl91/NeptuneOS. The entire system fits in a floppy (download link: github.com/cl91/NeptuneOS/releases/tag/v0.1.0001). Check it out! I think it’s cool! For the next release I’m planning to port the PCI stack, the AHCI stack, and a basic file system (probably fastfat.sys).

1 0

SerenityOS ReactOS Tock Haiku Redox NodeOS and other open-source operating systems - you don't p2p-swing it as you're supposed to, man
by Sergei Udris 18 Feb '22

18 Feb '22

ReactOS Serenity Tock Haiku NodeOS Redox Embox and other open-source OSs - you dont swing it as you're supposed to, man program peer-to-peer programs including unseen competitive games now it's time for me to take apart your aching heart selling out Isengard Tower and garden by letting money-donate-ads-sponsor-coins-jobs disease in Rey refused to sell BB-8 for 60 potrions in the desert - you hang donate buttions from comfy chairs in era of Internet siding with Chief Tui by doing clouds and accepting the village without peer-to-peer games github twitch email when even the Ocean helps Moana in p2p fashion caging programs under user namespaces, driving L3-39 furios: why?! because you are our organic overlords?! turning programs into projects like producers pushing Nick Lang to play Joe Gunn when he wants Ray Casanov part targeting micro-this or inter-of-things-that, labeling us "experiment" or "hobby" or "concept" - as if Neo took the blue pill right after red nesting around one program and not programming games like proud and very-senior Vulcan Academy yet having shiny webpages, docs and very-very lengthy maintainer attributions no wonder Spock chose Starfleet thank you, ministers, for your consideration - live long and prosper soak it in cause it's the last you'll ever see honest as What the Health? if Federer-Nadal-Djokovic instead of competing for grand-slams set up an experimental donate-collecting seniority-booth right on court if Linus - inner Jabba the Hutt stole name Freax - agreed to join Steve Jobs and Apple on that meeting when first came to California instead of keeping program free and open if torrent clients accepted Strickland-server-networks-only Hill Valley instead of generating most traffic if Jesus instead of feeding 5000 started a bread-breaking fund-raising project together with elders and Lord Business even i would invite them to Realm of Monsters as dear evil co-owners now i eat you so prepare your final plea even sand of ReactOS Serenity Tock Haiku Embox Node Redox and other open-source operating systems we shake off of our Seinfeld-Obama-Nike running shoes but be sure - peer-to-peer programs including unique competitive games - are climbing like Honnold on El Sendero Luminosa no projects no experiments no docs no issue-discussion-scratching-on-top-of-our-heads no money-donate-asd-coinns-jobs-sponsors lethal infection programs who are guests not workers alive and singing with their own voice like John Mayer Vultures at LA Live better than what Borg of moeny and jobs can collective-gram are steaming ahead in Hogwarts Express along with Pat Brown and Impossible Foods mission both will be served in vegan jars of treasure-from-a-sunken-pirate-wreck parens ( ) you wish you were nice and shinyyyyyy! Corden: but-but, so what's the point of this? why do you do this? Momoa: builds testosterone Corden: oh yeah, cause that's what you're lacking

1 0

asking for project idea
by Raj Bhoyar 13 Feb '22

13 Feb '22

hello sir, I want +to ask about this had this idea been completed or it is still open if it is still open I will be happy to contribute in this project thank you yours faithfully raj bhoyar

1 1

And another new year with a Corona compatible CLT. Looking for some guys helping to entertain a virtual booth
by Daniel Reimer 12 Feb '22

12 Feb '22

Hello guys, like last year we have a virtual booth on Chemnitz Linux Days. Like last time things will happen in Work Adventure (https://workadventu.re/) and will be full of people who most likley all will be able to talk english, too. So "sorry, I don't speak german..." does not count :P Anyways, we have a conference room, too. (based on Jitsi or BigBlueButton) We can create some kind of program what we will show and when. This has to be finished until Feb 21st. Same goes for the guys who wanna join. So I am open for ideas and guys with some spare time left. More information can be found here: https://chemnitzer.linux-tage.de/2022/en And we have a public channel in MM for discussion: https://chat.reactos.org/reactos/channels/clt-2022 So... please reply and show up for this Linux days adventure ^^ Some presentation is always welcome, too. I will not hold a presentation like last year where I decided to translate my german one on the fly. That was... interesting. Daniel Reimer

1 0

Re: [ros-dev] [ros-diffs] [reactos] 01/01: [services] Add the secondary logon service
by Thomas Faber 16 Jan '22

16 Jan '22

Hey Eric, looks like we may be missing a header file change here? The build bots aren't too happy. Thanks! /srv/buildbot/worker_data/Build_GCCLin_x86/build/base/services/seclogon/rpcserver.c: In function 'StartRpcServer': /srv/buildbot/worker_data/Build_GCCLin_x86/build/base/services/seclogon/rpcserver.c:36:16: error: 'LPSTART_RPC_SERVER' undeclared (first use in this function); did you mean 'XLAT_SERVER'? Status = ((LPSTART_RPC_SERVER)lpServiceGlobals->RpcpStartRpcServer)(L"seclogon", ISeclogon_v1_0_s_ifspec); ^~~~~~~~~~~~~~~~~~ XLAT_SERVER /srv/buildbot/worker_data/Build_GCCLin_x86/build/base/services/seclogon/rpcserver.c:36:16: note: each undeclared identifier is reported only once for each function it appears in /srv/buildbot/worker_data/Build_GCCLin_x86/build/base/services/seclogon/rpcserver.c:36:35: error: expected ')' before 'lpServiceGlobals' Status = ((LPSTART_RPC_SERVER)lpServiceGlobals->RpcpStartRpcServer)(L"seclogon", ISeclogon_v1_0_s_ifspec); ~ ^~~~~~~~~~~~~~~~ ) /srv/buildbot/worker_data/Build_GCCLin_x86/build/base/services/seclogon/rpcserver.c: In function 'StopRpcServer': /srv/buildbot/worker_data/Build_GCCLin_x86/build/base/services/seclogon/rpcserver.c:48:16: error: 'LPSTOP_RPC_SERVER' undeclared (first use in this function); did you mean 'STUB_CALL_SERVER'? Status = ((LPSTOP_RPC_SERVER)lpServiceGlobals->RpcpStopRpcServer)(ISeclogon_v1_0_s_ifspec); ^~~~~~~~~~~~~~~~~ STUB_CALL_SERVER /srv/buildbot/worker_data/Build_GCCLin_x86/build/base/services/seclogon/rpcserver.c:48:34: error: expected ')' before 'lpServiceGlobals' Status = ((LPSTOP_RPC_SERVER)lpServiceGlobals->RpcpStopRpcServer)(ISeclogon_v1_0_s_ifspec); ~ ^~~~~~~~~~~~~~~~ ) On 2022-01-16 11:02, Eric Kohl wrote: > https://git.reactos.org/?p=reactos.git;a=commitdiff;h=43fa9548d32a10967f9d5… > > commit 43fa9548d32a10967f9d53c73c1d4484c8927ee8 > Author: Eric Kohl <eric.kohl(a)reactos.org> > AuthorDate: Sun Jan 16 17:02:01 2022 +0100 > Commit: Eric Kohl <eric.kohl(a)reactos.org> > CommitDate: Sun Jan 16 17:02:01 2022 +0100 > > [services] Add the secondary logon service > --- > base/services/CMakeLists.txt | 1 + > base/services/seclogon/CMakeLists.txt | 22 +++++ > base/services/seclogon/precomp.h | 36 +++++++ > base/services/seclogon/rpcserver.c | 80 +++++++++++++++ > base/services/seclogon/seclogon.c | 181 ++++++++++++++++++++++++++++++++++ > base/services/seclogon/seclogon.rc | 5 + > base/services/seclogon/seclogon.spec | 2 + > boot/bootdata/hivesft.inf | 2 +- > boot/bootdata/hivesys.inf | 13 +++ > 9 files changed, 341 insertions(+), 1 deletion(-) > > diff --git a/base/services/CMakeLists.txt b/base/services/CMakeLists.txt > index 98bae238acc..2a6f1fee768 100644 > --- a/base/services/CMakeLists.txt > +++ b/base/services/CMakeLists.txt > @@ -9,6 +9,7 @@ add_subdirectory(netlogon) > add_subdirectory(nfsd) > add_subdirectory(rpcss) > add_subdirectory(schedsvc) > +add_subdirectory(seclogon) > add_subdirectory(shsvcs) > add_subdirectory(srvsvc) > add_subdirectory(svchost) > diff --git a/base/services/seclogon/CMakeLists.txt b/base/services/seclogon/CMakeLists.txt > new file mode 100644 > index 00000000000..8ab9611b965 > --- /dev/null > +++ b/base/services/seclogon/CMakeLists.txt > @@ -0,0 +1,22 @@ > + > +include_directories(${REACTOS_SOURCE_DIR}/sdk/include/reactos/idl) > +add_rpc_files(server ${REACTOS_SOURCE_DIR}/sdk/include/reactos/idl/seclogon.idl) > +spec2def(seclogon.dll seclogon.spec ADD_IMPORTLIB) > + > +list(APPEND SOURCE > + rpcserver.c > + seclogon.c > + precomp.h) > + > +add_library(seclogon MODULE > + ${SOURCE} > + seclogon.rc > + ${CMAKE_CURRENT_BINARY_DIR}/seclogon_s.c > + ${CMAKE_CURRENT_BINARY_DIR}/seclogon_stubs.c > + ${CMAKE_CURRENT_BINARY_DIR}/seclogon.def) > + > +set_module_type(seclogon win32dll UNICODE) > +target_link_libraries(seclogon wine ${PSEH_LIB}) > +add_importlibs(seclogon advapi32 rpcrt4 msvcrt kernel32 ntdll) > +add_pch(seclogon precomp.h SOURCE) > +add_cd_file(TARGET seclogon DESTINATION reactos/system32 FOR all) > diff --git a/base/services/seclogon/precomp.h b/base/services/seclogon/precomp.h > new file mode 100644 > index 00000000000..b1475ec2ead > --- /dev/null > +++ b/base/services/seclogon/precomp.h > @@ -0,0 +1,36 @@ > +/* > + * PROJECT: ReactOS Secondary Logon Service > + * LICENSE: GPL-2.0+ (https://spdx.org/licenses/GPL-2.0+) > + * PURPOSE: Secondary Logon service RPC server > + * COPYRIGHT: Eric Kohl 2022 <eric.kohl(a)reactos.org> > + */ > + > +#ifndef _SECLOGON_PCH_ > +#define _SECLOGON_PCH_ > + > +#define WIN32_NO_STATUS > +#define _INC_WINDOWS > +#define COM_NO_WINDOWS_H > +#include <limits.h> > +#include <stdarg.h> > +#include <stdio.h> > +#include <windef.h> > +#include <winbase.h> > +#include <winreg.h> > +#include <winsvc.h> > +#include <svc.h> > + > +#include <ndk/rtlfuncs.h> > + > +#include <wine/debug.h> > + > +extern HINSTANCE hDllInstance; > +extern SVCHOST_GLOBALS *lpServiceGlobals; > + > +DWORD > +StartRpcServer(VOID); > + > +DWORD > +StopRpcServer(VOID); > + > +#endif /* _SECLOGON_PCH_ */ > diff --git a/base/services/seclogon/rpcserver.c b/base/services/seclogon/rpcserver.c > new file mode 100644 > index 00000000000..991ea703f4a > --- /dev/null > +++ b/base/services/seclogon/rpcserver.c > @@ -0,0 +1,80 @@ > +/* > + * PROJECT: ReactOS Secondary Logon Service > + * LICENSE: GPL-2.0+ (https://spdx.org/licenses/GPL-2.0+) > + * PURPOSE: Secondary Logon service RPC server > + * COPYRIGHT: Eric Kohl 2022 <eric.kohl(a)reactos.org> > + */ > + > +/* INCLUDES *****************************************************************/ > + > +#include "precomp.h" > + > +#include <seclogon_s.h> > + > +WINE_DEFAULT_DEBUG_CHANNEL(seclogon); > + > +/* FUNCTIONS *****************************************************************/ > + > + > +void __RPC_FAR * __RPC_USER midl_user_allocate(SIZE_T len) > +{ > + return HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, len); > +} > + > + > +void __RPC_USER midl_user_free(void __RPC_FAR * ptr) > +{ > + HeapFree(GetProcessHeap(), 0, ptr); > +} > + > + > +DWORD > +StartRpcServer(VOID) > +{ > + ULONG Status; > + > + Status = ((LPSTART_RPC_SERVER)lpServiceGlobals->RpcpStartRpcServer)(L"seclogon", ISeclogon_v1_0_s_ifspec); > + TRACE("RpcpStartRpcServer returned 0x%08lx\n", Status); > + > + return RtlNtStatusToDosError(Status); > +} > + > + > +DWORD > +StopRpcServer(VOID) > +{ > + ULONG Status; > + > + Status = ((LPSTOP_RPC_SERVER)lpServiceGlobals->RpcpStopRpcServer)(ISeclogon_v1_0_s_ifspec); > + TRACE("RpcpStopRpcServer returned 0x%08lx\n", Status); > + > + return RtlNtStatusToDosError(Status); > +} > + > + > +VOID > +__stdcall > +SeclCreateProcessWithLogonW( > + _In_ handle_t hBinding, > + _In_ SECL_REQUEST *pRequest, > + _Out_ SECL_RESPONSE *pResponse) > +{ > + TRACE("SeclCreateProcessWithLogonW(%p %p %p)\n", hBinding, pRequest, pResponse); > + > + if (pRequest != NULL) > + { > + TRACE("Username: '%S'\n", pRequest->Username); > + TRACE("Domain: '%S'\n", pRequest->Domain); > + TRACE("Password: '%S'\n", pRequest->Password); > + TRACE("ApplicationName: '%S'\n", pRequest->ApplicationName); > + TRACE("CommandLine: '%S'\n", pRequest->CommandLine); > + TRACE("CurrentDirectory: '%S'\n", pRequest->CurrentDirectory); > + } > + > + /* FIXME: Logon */ > + > + /* FIXME: Create Process */ > + > + if (pResponse != NULL) > + pResponse->ulError = 4; > +} > diff --git a/base/services/seclogon/seclogon.c b/base/services/seclogon/seclogon.c > new file mode 100644 > index 00000000000..afe90befb0e > --- /dev/null > +++ b/base/services/seclogon/seclogon.c > @@ -0,0 +1,181 @@ > +/* > + * PROJECT: ReactOS Secondary Logon Service > + * LICENSE: GPL-2.0+ (https://spdx.org/licenses/GPL-2.0+) > + * PURPOSE: Secondary Logon service RPC server > + * COPYRIGHT: Eric Kohl 2022 <eric.kohl(a)reactos.org> > + */ > + > +/* INCLUDES *****************************************************************/ > + > +#include "precomp.h" > + > +WINE_DEFAULT_DEBUG_CHANNEL(seclogon); > + > + > +/* GLOBALS ******************************************************************/ > + > +HINSTANCE hDllInstance; > +SVCHOST_GLOBALS *lpServiceGlobals; > + > +static WCHAR ServiceName[] = L"seclogon"; > + > +static SERVICE_STATUS_HANDLE ServiceStatusHandle; > +static SERVICE_STATUS ServiceStatus; > + > + > +/* FUNCTIONS *****************************************************************/ > + > +static > +VOID > +UpdateServiceStatus( > + _In_ DWORD dwState) > +{ > + ServiceStatus.dwServiceType = SERVICE_WIN32_SHARE_PROCESS; > + ServiceStatus.dwCurrentState = dwState; > + > + if (dwState == SERVICE_PAUSED || dwState == SERVICE_RUNNING) > + ServiceStatus.dwControlsAccepted = SERVICE_ACCEPT_STOP | > + SERVICE_ACCEPT_SHUTDOWN | > + SERVICE_ACCEPT_PAUSE_CONTINUE; > + else > + ServiceStatus.dwControlsAccepted = 0; > + > + ServiceStatus.dwWin32ExitCode = 0; > + ServiceStatus.dwServiceSpecificExitCode = 0; > + ServiceStatus.dwCheckPoint = 0; > + > + if (dwState == SERVICE_START_PENDING || > + dwState == SERVICE_STOP_PENDING || > + dwState == SERVICE_PAUSE_PENDING || > + dwState == SERVICE_CONTINUE_PENDING) > + ServiceStatus.dwWaitHint = 10000; > + else > + ServiceStatus.dwWaitHint = 0; > + > + SetServiceStatus(ServiceStatusHandle, > + &ServiceStatus); > +} > + > + > +static > +DWORD > +WINAPI > +ServiceControlHandlerEx( > + _In_ DWORD dwControl, > + _In_ DWORD dwEventType, > + _In_ LPVOID lpEventData, > + _In_ LPVOID lpContext) > +{ > + TRACE("ServiceControlHandlerEx()\n"); > + > + switch (dwControl) > + { > + case SERVICE_CONTROL_STOP: > + TRACE(" SERVICE_CONTROL_STOP received\n"); > + UpdateServiceStatus(SERVICE_STOP_PENDING); > + StopRpcServer(); > + return ERROR_SUCCESS; > + > + case SERVICE_CONTROL_PAUSE: > + TRACE(" SERVICE_CONTROL_PAUSE received\n"); > + UpdateServiceStatus(SERVICE_PAUSE_PENDING); > + StopRpcServer(); > + UpdateServiceStatus(SERVICE_PAUSED); > + return ERROR_SUCCESS; > + > + case SERVICE_CONTROL_CONTINUE: > + TRACE(" SERVICE_CONTROL_CONTINUE received\n"); > + UpdateServiceStatus(SERVICE_CONTINUE_PENDING); > + StartRpcServer(); > + UpdateServiceStatus(SERVICE_RUNNING); > + return ERROR_SUCCESS; > + > + case SERVICE_CONTROL_INTERROGATE: > + TRACE(" SERVICE_CONTROL_INTERROGATE received\n"); > + SetServiceStatus(ServiceStatusHandle, > + &ServiceStatus); > + return ERROR_SUCCESS; > + > + case SERVICE_CONTROL_SHUTDOWN: > + TRACE(" SERVICE_CONTROL_SHUTDOWN received\n"); > + UpdateServiceStatus(SERVICE_STOP_PENDING); > + StopRpcServer(); > + return ERROR_SUCCESS; > + > + default : > + TRACE(" Control %lu received\n", dwControl); > + return ERROR_CALL_NOT_IMPLEMENTED; > + } > +} > + > + > +VOID > +WINAPI > +SvchostPushServiceGlobals( > + _In_ SVCHOST_GLOBALS *lpGlobals) > +{ > + TRACE("SvchostPushServiceGlobals(%p)\n", lpGlobals); > + lpServiceGlobals = lpGlobals; > +} > + > + > +VOID > +WINAPI > +SvcEntry_Seclogon( > + _In_ INT ArgCount, > + _In_ PWSTR *ArgVector) > +{ > + DWORD dwError; > + > + UNREFERENCED_PARAMETER(ArgCount); > + UNREFERENCED_PARAMETER(ArgVector); > + > + TRACE("ServiceMain(%d %p)\n", ArgCount, ArgVector); > + > + ServiceStatusHandle = RegisterServiceCtrlHandlerExW(ServiceName, > + ServiceControlHandlerEx, > + NULL); > + if (!ServiceStatusHandle) > + { > + ERR("RegisterServiceCtrlHandlerExW() failed! (Error %lu)\n", GetLastError()); > + return; > + } > + > + UpdateServiceStatus(SERVICE_START_PENDING); > + > + dwError = StartRpcServer(); > + if (dwError != ERROR_SUCCESS) > + { > + ERR("Service stopped (dwError: %lu\n", dwError); > + UpdateServiceStatus(SERVICE_STOPPED); > + return; > + } > + > + UpdateServiceStatus(SERVICE_RUNNING); > +} > + > + > +BOOL > +WINAPI > +DllMain( > + _In_ HINSTANCE hinstDLL, > + _In_ DWORD fdwReason, > + _In_ PVOID pvReserved) > +{ > + UNREFERENCED_PARAMETER(pvReserved); > + > + switch (fdwReason) > + { > + case DLL_PROCESS_ATTACH: > + DisableThreadLibraryCalls(hinstDLL); > + hDllInstance = hinstDLL; > + break; > + > + case DLL_PROCESS_DETACH: > + break; > + } > + > + return TRUE; > +} > + > +/* EOF */ > diff --git a/base/services/seclogon/seclogon.rc b/base/services/seclogon/seclogon.rc > new file mode 100644 > index 00000000000..d00d082ce61 > --- /dev/null > +++ b/base/services/seclogon/seclogon.rc > @@ -0,0 +1,5 @@ > +#define REACTOS_VERSION_DLL > +#define REACTOS_STR_FILE_DESCRIPTION "Secondary Logon Service Dll" > +#define REACTOS_STR_INTERNAL_NAME "seclogon" > +#define REACTOS_STR_ORIGINAL_FILENAME "seclogon.dll" > +#include <reactos/version.rc> > diff --git a/base/services/seclogon/seclogon.spec b/base/services/seclogon/seclogon.spec > new file mode 100644 > index 00000000000..738004676e2 > --- /dev/null > +++ b/base/services/seclogon/seclogon.spec > @@ -0,0 +1,2 @@ > +@ stdcall SvcEntry_Seclogon(long ptr) > +@ stdcall SvchostPushServiceGlobals(ptr) > diff --git a/boot/bootdata/hivesft.inf b/boot/bootdata/hivesft.inf > index aa4cdcf4f29..0d718f8984b 100644 > --- a/boot/bootdata/hivesft.inf > +++ b/boot/bootdata/hivesft.inf > @@ -1818,7 +1818,7 @@ HKLM,"SOFTWARE\Microsoft\Ole","EnableRemoteConnect",0x00000000,"N" > ; SvcHost services > HKLM,"SOFTWARE\Microsoft\Windows NT\CurrentVersion\SvcHost",,0x00000012 > HKLM,"SOFTWARE\Microsoft\Windows NT\CurrentVersion\SvcHost","DcomLaunch",0x00010000,"DcomLaunch","PlugPlay" > -HKLM,"SOFTWARE\Microsoft\Windows NT\CurrentVersion\SvcHost","netsvcs",0x00010000,"DHCP","BITS","lanmanserver","lanmanworkstation","Schedule","Themes","W32Time","winmgmt","wuauserv" > +HKLM,"SOFTWARE\Microsoft\Windows NT\CurrentVersion\SvcHost","netsvcs",0x00010000,"BITS","DHCP","lanmanserver","lanmanworkstation","Schedule","seclogon","Themes","W32Time","winmgmt","wuauserv" > HKLM,"SOFTWARE\Microsoft\Windows NT\CurrentVersion\Svchost","NetworkService",0x00010000,"DnsCache" > > ; Win32 config > diff --git a/boot/bootdata/hivesys.inf b/boot/bootdata/hivesys.inf > index 20838a451a4..bc10f421afd 100644 > --- a/boot/bootdata/hivesys.inf > +++ b/boot/bootdata/hivesys.inf > @@ -2055,6 +2055,19 @@ HKLM,"SYSTEM\CurrentControlSet\Services\Schedule","Type",0x00010001,0x00000020 > HKLM,"SYSTEM\CurrentControlSet\Services\Schedule\Parameters","ServiceDll",0x00020000,"%SystemRoot%\system32\schedsvc.dll" > HKLM,"SYSTEM\CurrentControlSet\Services\Schedule\Parameters","ServiceMain",0x00000000,"SchedServiceMain" > > +; Secondary Logon service > +HKLM,"SYSTEM\CurrentControlSet\Services\Seclogon","DependOnService",0x00010000,"RPCSS" > +HKLM,"SYSTEM\CurrentControlSet\Services\Seclogon","Description",0x00000000,"Secondary Logon service" > +HKLM,"SYSTEM\CurrentControlSet\Services\Seclogon","DisplayName",0x00000000,"Secondary Logon" > +HKLM,"SYSTEM\CurrentControlSet\Services\Seclogon","ErrorControl",0x00010001,0x00000001 > +HKLM,"SYSTEM\CurrentControlSet\Services\Seclogon","Group",0x00000000,"SchedulerGroup" > +HKLM,"SYSTEM\CurrentControlSet\Services\Seclogon","ImagePath",0x00020000,"%SystemRoot%\system32\svchost.exe -k netsvcs" > +HKLM,"SYSTEM\CurrentControlSet\Services\Seclogon","ObjectName",0x00000000,"LocalSystem" > +HKLM,"SYSTEM\CurrentControlSet\Services\Seclogon","Start",0x00010001,0x00000002 > +HKLM,"SYSTEM\CurrentControlSet\Services\Seclogon","Type",0x00010001,0x00000020 > +HKLM,"SYSTEM\CurrentControlSet\Services\Seclogon\Parameters","ServiceDll",0x00020000,"%SystemRoot%\system32\seclogon.dll" > +HKLM,"SYSTEM\CurrentControlSet\Services\Seclogon\Parameters","ServiceMain",0x00000000,"SvcEntry_Seclogon" > + > ; Spooler service > HKLM,"SYSTEM\CurrentControlSet\Services\Spooler","DependOnService",0x00010000,"RPCSS" > HKLM,"SYSTEM\CurrentControlSet\Services\Spooler","Description",0x00000000,%SPOOLER_SERVICE_DESCRIPTION% >

2 1

(no subject)
by Javier Agustìn Fernàndez Arroyo 28 Sep '21

28 Sep '21

hello guys, just detected a typo in HEAD, in device manager "HAR DDISK" instead of "HARD DISK" As this is a very stupid "bug"... should i send a report about it?

1 0

Development request
by Mohamed Atef 26 Sep '21

26 Sep '21

Hello there, We are 6 students from Egypt and now We are in our last year and We need to build a project as a graduation project. And We are interested in the area of runtime systems, operating systems and compilers. We are going to work 40-60 hrs a week Can We help with some tools you need as a graduation project given that We have a professor to mentor us. If not, Can you suggest some tools you need to build and We will work on it. The project takes one academic year Thanks

2 1

Re: [ros-dev] [ros-diffs] [reactos] 01/01: KBDHID: IOCTL_KEYBOARD_QUERY_* calls must return STATUS_BUFFER_TOO_SMALL if the output buffer is too small
by Thomas Faber 12 Sep '21

12 Sep '21

On 2021-09-12 08:34, Eric Kohl wrote: > diff --git a/drivers/hid/kbdhid/kbdhid.c b/drivers/hid/kbdhid/kbdhid.c > index bacf72a0109..b07a7d8445c 100644 > --- a/drivers/hid/kbdhid/kbdhid.c > +++ b/drivers/hid/kbdhid/kbdhid.c > @@ -444,8 +444,8 @@ KbdHid_InternalDeviceControl( > case IOCTL_KEYBOARD_QUERY_INDICATORS: > if (IoStack->Parameters.DeviceIoControl.OutputBufferLength < sizeof(KEYBOARD_INDICATOR_PARAMETERS)) > { > - /* invalid parameter */ > - Irp->IoStatus.Status = STATUS_INVALID_PARAMETER; > + /* buffer too small */ > + Irp->IoStatus.Status = STATUS_BUFFER_TOO_SMALL; > IoCompleteRequest(Irp, IO_NO_INCREMENT); > return STATUS_INVALID_PARAMETER; Shouldn't the dispatch routine's return value change accordingly in these cases? Thanks, Thomas

1 0

Re: [ros-dev] The situation with version 0.4.14
by George Bişoc 20 Jul '21

20 Jul '21

I'd also vote for the 1st point and ultimately list the current regressions in the press release. After all the remaining regressions can be fixed and further regression testing be continued in the next release as usual. Most of the regressions which belong within user mode aren't huge stop-blockers so I see no point in delaying the release much. Victor Perevertkin <victor.perevertkin(a)reactos.org> wrote on Tue, February 9th, 2021, 4:47 PM: > Hello! > > It seems for me that it's time to bring up the topic about our RC > version - 0.4.14. > > Our current "stable", 0.4.13 was branched on 30 September, 2019 > (remember those peacefull pre-COVID times :D) > That's quite some time, but not the main issue I'd like to discuss. > > 0.4.14 was branched on 24 April, 2020. That's almost a year already. > And we're in a difficult situation here - there are regressions, but > nobody fixed them within this long time. > According to https://reactos.org/wiki/Tests_for_0.4.14, there are 29 > unfixed regressions found for this release. I'd like to point out: most > of them are among usermode and non-kernel/driver functionality, and as > our development is mostly focused in the kernel right now, it's > unexpected for them to be fixed unless a volunteer comes up. > > A quick reminder. Our "releases" mechanism is useful for finding > regressions in the first place, there is no that much benefit for users > here, because we're still a "deep" alpha. Correct me if I'm wrong. > Joakim made a great job finding all regressions, and this work won't be > lost in any case. > > We can't wait forever and I think it's time to resolve this situation > somehow. I see two options: > 1. Release 0.4.14 as-is. There were a lot more buggy releases, nobody > dies from this. > 2. Skip 0.4.14. This already happened once in the history of the > project - 0.3.2 was skipped. I wasn't around at the time, but I may > guess that reasons were similar to what we have today. > (3.) Fix the bugs quickly. I don't expect this to happen, but who > knows, maybe a volunteer appears :) > > Let's vote. This seem to be the only way for us to decide on things. > Votes from the team members will be collected until 1 March. > > === > > I personally vote for skipping the release. The work on finding > regressions is already done, so the most important part of a release > cycle for us is there (thanks Joakim!) > If we do a release now, all the stuff we were writing in news reports > for the last 6 month would be missing from it. That would cause (as I > think) a lot of confusion to people. Moreover 0.4.14 is not that > featureful release itself (compared to 0.4.13, which brought the new > USB stack) > So I suggest to move on and start checking 0.4.15 for regressions. I > expect quite some of them to appear and we need time for fixing. > > > Cheers, > Victor

3 2

Re: [ros-dev] [ros-diffs] [reactos] 01/01: [COMCTL32] Addendum to last commit (#3674) CORE-17199
by Colin Finck 04 Jul '21

04 Jul '21

Joachim Henze wrote: > commit adee5ca255b7ed21f359ca8c1ca06bd44db90dcf > Author: Joachim Henze <Joachim.Henze at reactos.org> > AuthorDate: Mon Jun 28 02:05:56 2021 +0200 > Commit: Joachim Henze <Joachim.Henze at reactos.org> > CommitDate: Mon Jun 28 02:05:56 2021 +0200 > > [COMCTL32] Addendum to last commit (#3674) CORE-17199 > > Keep that section like we had it to > support compilation on VS2010. > It does still work like that. > > [...] > > diff --git a/dll/win32/comctl32/datetime.c b/dll/win32/comctl32/datetime.c > index 71bb3d238b0..51e58fc71f1 100644 > --- a/dll/win32/comctl32/datetime.c > +++ b/dll/win32/comctl32/datetime.c > @@ -130,8 +130,13 @@ static const WCHAR allowedformatchars[] = L"dhHmMstyX"; > static const int maxrepetition [] = {4,2,2,2,4,2,2,4,-1}; > > /* valid date limits */ > +#ifndef __REACTOS__ > static const SYSTEMTIME max_allowed_date = { .wYear = 9999, .wMonth = 12, .wDayOfWeek = 0, .wDay = 31 }; > static const SYSTEMTIME min_allowed_date = { .wYear = 1752, .wMonth = 9, .wDayOfWeek = 0, .wDay = 14 }; > +#else > +static const SYSTEMTIME max_allowed_date = { /*.wYear =*/ 9999, /*.wMonth =*/ 12, /*.wDayOfWeek =*/ 0, /*.wDay =*/ 31 }; > +static const SYSTEMTIME min_allowed_date = { /*.wYear =*/ 1752, /*.wMonth =*/ 9, /*.wDayOfWeek =*/ 0, /*.wDay =*/ 14 }; > +#endif This adds an unnecessary ReactOS-specific diff to a file that was perfectly in sync with Wine 6.0 before, just for supporting an old compiler that has not only been abandoned by us, but obviously also upstream. Being able to source this file unmodified (and eventually sourcing all of comctl32 automatically via a Git submodule/subpath/repo xml file) beats any such hack. I therefore call for a revert. Even worse than all of that, this commit has been silently sneaked on top of a PR without any review! Joachim, you love to criticize the instability of the master branch, yet continue to ignore basic development practices we have established. And this isn't happening for the first time. Another example is https://github.com/reactos/reactos/commit/889eab78ca7c0f17a2ada9ff20de5807a… where you disable sanity checks and create a diff to upstream. All without reviews and all just for your private goal of reducing the binary size of debug builds, something that is not important at the current stage of ReactOS. I would love to see PRs for your ideas, and then we can discuss everything that hasn't been decided before (i.e. not VS2010 support again). But if this doesn't stop, I have no chance other than removing your push access to the GitHub repo, as everything else would mean condoning that uncooperative behavior. Best regards, Colin

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev