Ros-dev

ros-dev@reactos.org

1 participants
5793 discussions

Please don't read Windows source code
by katahiromz . 24 Jun '17

24 Jun '17

According to The Register, Windows 10 source has been leaked. But reading that codes is still illegal for ReactOS development, so we might fire you if you read in the case. ---- Please don't read the leaked source. Thanks, Katayama Hirofumi MZ 片山博文MZ

2 1

ReactOS Hackfest 2017 - Are you in?
by Colin Finck 23 Jun '17

23 Jun '17

Hi all! I'm currently planning the ReactOS Hackfest 2017 in the Cologne/Bonn area in Germany. Currently, the plan is to book a meeting room from Monday, August 14 to Friday, August 18. We can then use the weekend before to get to Cologne and explore the city a bit. After the Hackfest, everybody interested can join us at FrOSCon in Bonn the weekend after. As booking a room there involves significant costs, I'd like to know who of you can definitely make it for the Hackfest and who of you is definitely out. Please reply now to prevent me from bugging you on IRC all the time! ;) Cheers, Colin

8 8

Re: [ros-dev] [ros-diffs] [hbelusca] 75164: [SECUR32_APITEST]: Add the beginnings of an apitest for secur32, based on code by Samuel Serapion & MSDN. What needs to be fixed here, is the client/server code to communicate the...
by Colin Finck 22 Jun '17

22 Jun '17

hbelusca(a)svn.reactos.org wrote: > [SECUR32_APITEST]: Add the beginnings of an apitest for secur32, based > on code by Samuel Serapion & MSDN. What needs to be fixed here, is the > client/server code to communicate the results back to the main test > app being running. Work in progress. I have implemented short and simple WineTest-compatible client/server code in localspl_apitest. The server is the application that is tested through rosautotest. For every test, it starts the client, sends the test name over a pipe and outputs the received testing output. The client simply has stdout redirected to a pipe and can then use usual WineTest ok() functions for testing. Check out rostests/apitests/localspl (server) and rostests/apitests/localspl/dll (client). Hope that helps! - Colin

1 0

Re: [ros-dev] [ros-diffs] [hbelusca] 75083: [NTOS]: Use SEH inside CmQueryKey(), as it can be called with user-mode parameter KeyInformation. Remove unused code in CmLoadKey(). I've noticed that in cmapi.c / ntapi.c we do n...
by Alex Ionescu 20 Jun '17

20 Jun '17

On Sun, Jun 18, 2017 at 1:34 AM, <hbelusca(a)svn.reactos.org> wrote: > - if (!(CmpProfileLoaded) && !(CmpWasSetupBoot)) > + if (!CmpProfileLoaded && !CmpWasSetupBoot) > Why do you keep re-formatting other people's code in unrelated patches? You've been repeatedly asked to stop doing this. Best regards, Alex Ionescu

1 0

Re: [ros-dev] [ros-diffs] [hbelusca] 75133: [NTOS]: Revert the pool tag change from r75128, and explain in comment why we cannot actually use it.
by Thomas Faber 19 Jun '17

19 Jun '17

On 2017-06-19 18:29, hbelusca(a)svn.reactos.org wrote: > + /* > + * Free it from the pool. > + * > + * We cannot use here ExFreePoolWithTag(..., OB_NAME_TAG); , because > + * the object name may have been massaged during operation by different > + * object parse routines. If the latter ones have to resolve a symbolic > + * link (e.g. as is done by CmpParseKey() and CmpGetSymbolicLink()), > + * the original object name is freed and re-allocated from the pool, > + * possibly with a different pool tag. At the end of the day, the new > + * object name can be reallocated and completely different, but we > + * should still be able to free it! > + */ > + ExFreePool(Buffer); I feel like ExFreePoolWithTag(Buffer, 0) conveys that same message without needing a huge comment?

2 1

GPU testing machine is ready!
by Colin Finck 13 Jun '17

13 Jun '17

Hi all! A picture says more than a thousand words: http://fs5.directupload.net/images/170613/u4d8a59a.png As promised in the last meeting, I have brought to life a machine for testing GPU drivers with real GPUs under ReactOS. It combines a QEMU virtual machine with PCIe GPU Passthrough together with a KVM-over-IP card for feeding the real video signal back to a window. What you see in the screenshot is a real NVIDIA GeForce 9300 GPU attached to a ReactOS VM. We can now test the NVIDIA driver installation while enjoying the easy debuggability of a VM. My first report is already out: https://jira.reactos.org/browse/CORE-13423 Every developer interested in working on this can drop me a line and I will send you credentials for the server. Soon I will also add an AMD Graphics Card along with another KVM-over-IP card to let us debug the other big driver package. Thanks go out to Mr. Kromdijk for the generous server donation, Christoph for the KVM-over-IP card, and Hervé for the QEMU hints! Let's all get some flashy 3D acceleration into ReactOS!! :) Cheers, Colin

1 0

Re: [ros-dev] [ros-diffs] [hbelusca] 75008: [USETUP]: Introduce SetupDeleteFile() and SetupMoveFile() (in addition to the already-existing SetupCopyFile()) in order to implement moving / renaming existing files. Will be use...
by Thomas Faber 12 Jun '17

12 Jun '17

On 2017-06-12 01:58, hbelusca(a)svn.reactos.org wrote: > +NTSTATUS > +SetupMoveFile( > + IN PCWSTR ExistingFileName, > + IN PCWSTR NewFileName, > + IN ULONG Flags) > +{ > + NTSTATUS Status; > + IO_STATUS_BLOCK IoStatusBlock; > + OBJECT_ATTRIBUTES ObjectAttributes; > + PFILE_RENAME_INFORMATION RenameInfo; > + UNICODE_STRING NewPathU, ExistingPathU; > + HANDLE SourceHandle = NULL; This variable fulfills the requirements for _SEH2_VOLATILE > + BOOLEAN ReplaceIfExists; > + > + RtlInitUnicodeString(&ExistingPathU, ExistingFileName); > + RtlInitUnicodeString(&NewPathU, NewFileName); > + > + _SEH2_TRY > + { Which part of this code needs SEH? That looks like it's purely hiding bugs.

2 1

Re: [ros-dev] [ros-diffs] [tthompson] 74970: [NTFS] - Add the most basic support for file creation. Expand diagnostic output, especially in NtfsDumpIndexRootAttribute(). Replace an ExFreePool() with ExFreePoolWithTag(). Add...
by Thomas Faber 12 Jun '17

12 Jun '17

On 2017-06-09 05:14, tthompson(a)svn.reactos.org wrote: > + RtlZeroMemory(&FilenameNoPath, sizeof(UNICODE_STRING)); > + FilenameNoPath.Buffer = Buffer; > + FilenameNoPath.MaximumLength = MAX_PATH; > + RtlInitEmptyUnicodeString does this for you On 2017-06-09 05:14, tthompson(a)svn.reactos.org wrote: > + FileNameAttribute->NameLength = FilenameNoPath.Length / 2; sizeof(WCHAR)?

1 0

Re: [ros-dev] [ros-diffs] [phater] 74750: [MSWSOCK] Call explicitly DnsQuery_W. Copy host aliases if available as answer from the query
by Thomas Faber 09 Jun '17

09 Jun '17

On 2017-06-02 19:52, phater(a)svn.reactos.org wrote: > + aDstNextStr = (char*)((DWORD)aDstNextStr + (DWORD)bItmLen); DWORD cannot always fit a pointer. You want DWORD_PTR for this kind of math (or simply use char *).

1 0

Re: [ros-dev] [ros-diffs] [hbelusca] 74742: [USETUP]: Creating a registry key with zero access is just plainly invalid. Fix it. It was not caught before because, we never ever booted a 1st-stage setup with a valid mounted e...
by Thomas Faber 02 Jun '17

02 Jun '17

On 2017-06-02 02:44, hbelusca(a)svn.reactos.org wrote: > @@ -341,7 +341,7 @@ > } > > InitializeObjectAttributes(&ObjectAttributes, &ServicesU, OBJ_CASE_INSENSITIVE, NULL, NULL); > - Status = NtCreateKey(&hServices, 0, &ObjectAttributes, 0, NULL, 0, NULL); > + Status = NtCreateKey(&hServices, KEY_ALL_ACCESS, &ObjectAttributes, 0, NULL, 0, NULL); > if (!NT_SUCCESS(Status)) > { > DPRINT1("NtCreateKey('%wZ') failed with status 0x%08lx\n", &ServicesU, Status); > > It doesn't really need full access, does it? Could have gone for something closer to the original, like READ_CONTROL.

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev