Ros-dev

ros-dev@reactos.org

5790 discussions

Security problem in NtGdiCreateCompatibleDC?
by Timo Kreuzer 03 Feb '07

03 Feb '07

Please have a look at that code: NtGdiCreateCompatibleDC @ 192: ... hNewDC = DC_AllocDC <http://www.reactos.org/generated/doxygen/de/dcc/dc_8h.html#a12>(&OrigDC->DriverName <http://www.reactos.org/generated/doxygen/d9/de9/struct__DC.html#o8>); if (NULL == hNewDC) { DC_UnlockDc(OrigDC); if (NULL != DisplayDC) { NtGdiDeleteObjectApp <http://www.reactos.org/generated/doxygen/d7/de8/subsystems_2win32_2win32k_2…>(DisplayDC); } return NULL; } NewDC = DC_LockDc( hNewDC ); ... I am not completely sure (GreatLord said it was fine) but i think it might not be. Let's think of a condition when process x, thread 0 does try call NtGdiCreateCompatibleDC and Allocates the DC. Wouldn't there be the chance of thread 1 to get a lock on the DC (by guessing it's handle) just after it was created and make DC_LockDC return NULL? GDIOBJ_LockObj checks if the ProcessID is the same as PsGetCurrentProcessId() , but not more. So I think a second thread might do a timed attack and get a lock on the just created DC.

1 0

problems building with gcc 4.1.2 (RosBE 0.3.4)
by Felipe Villarroel 03 Feb '07

03 Feb '07

Hi, today i tried to compile ReactOS with gcc 4.1.2 under RosBE 0.3.4 (previously i used both gcc 3.4.5 and gcc 4.1.2, with a previous svn revision). Before trying to switch compilers i have successfully built an iso image with gcc 3.4.5. So, i issued a make clean in the gcc 3.4.5 enviroment. Then i changed to gcc 4.1.2 and issued a make bootcd (with current SVN). In the building process i got this error message: [CC] lib\intrlck\i386\compareexchange.c [AR] obj-i386\lib\intrlck\intrlck.a [LD] output-i386\dll\ntdll\ntdll.dll [RSYM] output-i386\dll\ntdll\ntdll.dll [LD] output-i386\dll\win32\kernel32\kernel32.dll obj-i386\dll\win32\kernel32\misc\dllmain.o: In function `InterlockedCompareExchange@12': d:/reactos/current/include/psdk/intrin.h:110: undefined reference to `__sync_val_compare_and_swap_4' obj-i386\dll\win32\kernel32\misc\dllmain.o: In function `InterlockedIncrement@4': d:/reactos/current/include/psdk/intrin.h:139: undefined reference to `__sync_fetch_and_add_4' obj-i386\dll\win32\kernel32\misc\dllmain.o: In function `InterlockedDecrement@4': d:/reactos/current/include/psdk/intrin.h:139: undefined reference to `__sync_fetch_and_add_4' obj-i386\dll\win32\kernel32\misc\dllmain.o: In function `InterlockedExchangeAdd@8': d:/reactos/current/include/psdk/intrin.h:139: undefined reference to `__sync_fetch_and_add_4' collect2: ld returned 1 exit status mingw32-make: *** [output-i386\dll\win32\kernel32\kernel32.dll] Error 1 I'm using ReactOS Build Environment 0.3.4-4.1.2-20061229-prerelease-patched. Probably i could comment the gcc version checking in intrin.h to get this to compile, but that isn't nice/right :P. As far as i know __sync_* functions are supplied by the compiler and they should be present in gcc 4.1.2. Is this right? Anyone got an idea why this doesn't work? Thanks in advance for your help, Best regards, Logan_V8 d:\reactos\current>echo __GNUC__ * 10000 + __GNUC_MINOR__ * 100 + __GNUC_PATCHLEVEL__ > p.txt d:\reactos\current>cpp < p.txt cc1.exe: warning: is shorter than expected # 1 "<stdin>" # 1 "<built-in>" # 1 "<command line>" # 1 "<stdin>" 4 * 10000 + 1 * 100 + 2

1 1

Re: [ros-dev] [ros-diffs] [fireball] 25667: - Comment out clearing of KeLoaderBlock (introduced by 25629), because it looks like someone is still calling IopLoadServiceModule() even after that point. 2nd stage boots with this change.
by Alex Ionescu 01 Feb '07

01 Feb '07

fireball(a)svn.reactos.org wrote: > Author: fireball > Date: Thu Feb 1 01:30:59 2007 > New Revision: 25667 > > URL: http://svn.reactos.org/svn/reactos?rev=25667&view=rev > Log: > - Comment out clearing of KeLoaderBlock (introduced by 25629), because it looks like someone is still calling IopLoadServiceModule() even after that point. 2nd stage boots with this change. > This does not fix the freeze/slowdown/issue I am seeing with the NT scheduler disabled. I still can't boot to desktop. -- Best regards, Alex Ionescu Project Lead, TinyKRNL Kernel-Mode Software Design Engineer, ReactOS

1 0

01 Feb '07

fireball(a)svn.reactos.org wrote: > Author: fireball > Date: Thu Feb 1 01:30:59 2007 > New Revision: 25667 > > URL: http://svn.reactos.org/svn/reactos?rev=25667&view=rev > Log: > - Comment out clearing of KeLoaderBlock (introduced by 25629), because it looks like someone is still calling IopLoadServiceModule() even after that point. 2nd stage boots with this change. > > I still get a hang after pressing "Next" on the last 2nd stage setup wizard page. -- Best regards, Alex Ionescu Project Lead, TinyKRNL Kernel-Mode Software Design Engineer, ReactOS

2 3

How it went: running Burn under ReactOS
by Alexander Rødseth 01 Feb '07

01 Feb '07

Hi, A few weeks ago, I received an e-mail asking me to test Burn, my old drawing-program for Dos, on ReactOS. However, I've lost that e-mail somehow, so I'm hoping this mailinglist is the right place to send my reply, as a substitute. The original e-mail was from someone affiliated with ReactOS. I used ReactOS 0.3-RELEASE (Build 20060827-r23747), running under Qemu. A screenshot of how it went is included. ("Bad command or filename", even though the command was valid). Burn works perfectly well under DosBox. Hope this was of any help whatsoever, and thanks for your contributions to the world of open source. Best regards, Alexander Rødseth

1 0

Crash on exit
by hto＠mail.cnt.ru 01 Feb '07

01 Feb '07

> Can't really fix this, this is a side effect of > the fact that NT checks that the initial boot > process didn't die, and the fact that our setup > code actually replaces the initial process. It can be fixed on process level, not on the kernel level.

1 0

LiveCD and 0.3.1
by Alex Ionescu 01 Feb '07

01 Feb '07

This should go in the branch: http://www.reactos.org/bugzilla/attachment.cgi?id=1125&action=view -- Best regards, Alex Ionescu Project Lead, TinyKRNL Kernel-Mode Software Design Engineer, ReactOS

1 0

FreeLDR improvement
by Alex Ionescu 01 Feb '07

01 Feb '07

http://www.reactos.org/bugzilla/show_bug.cgi?id=1881 Please commit 1051. -- Best regards, Alex Ionescu Project Lead, TinyKRNL Kernel-Mode Software Design Engineer, ReactOS

1 0

A slightly more aggressive mm patch
by art yerkes 29 Jan '07

29 Jan '07

http://www.superheterodyne.net/reactos/freelist_remove_type.diff This removes the redundant notion of .Flags.Type in freelist, and leaves only the non-redundant MM_PHYSICAL_PAGE_BIOS. MM_PHYSICAL_PAGE_FREE is reported when the page has a 0 reference count and MM_PHYSICAL_PAGE_USED is reported when the reference count is nonzero. A function, MmGetPageType is added to replace the old functionality. Init memory being freed seems to cause a lot of grief. I'm going to see if there's a way to decentralize how those pages are set up, given that the method used to dispose of them is spread out too. -- Discordant is the murmur at such treading down of lovely things while god's most lordly gift to man is decency of mind. Call that man only blest who has in sweet tranquility brought his life to close. If only I could act as such, my hope is good. -- Aeschylus' Agamemnon (translated by H. W. Smyth)

2 1

A patch for page dereferencing
by art yerkes 27 Jan '07

27 Jan '07

This patch makes ReferenceCount include MapCount so we don't get into the quite common situation where the balance manager wants to expel a mapped section. I've been seeing this error running quite a number of things and recently even in the first stage installer. Lightly tested, probably wrong as usual. http://www.superheterodyne.net/reactos/fix_page_reference.diff -- Discordant is the murmur at such treading down of lovely things while god's most lordly gift to man is decency of mind. Call that man only blest who has in sweet tranquility brought his life to close. If only I could act as such, my hope is good. -- Aeschylus' Agamemnon (translated by H. W. Smyth)

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev