Ros-dev

ros-dev@reactos.org

5788 discussions

Re: [ros-svn] [gvg] 19802: Factor out probe and capture code from private ntoskrnl header and put it in

by Alex Ionescu

gvg(a)svn.reactos.com wrote: >Factor out probe and capture code from private ntoskrnl header and put it in >a more public place so other kernelmode components can use it too > > > >Added files: >trunk/reactos/include/reactos/probe.h > >Updated files: >trunk/reactos/ntoskrnl/include/internal/ntoskrnl.h >trunk/reactos/ntoskrnl/include/ntoskrnl.h > >_______________________________________________ >Ros-svn mailing list >Ros-svn(a)reactos.org >http://www.reactos.org/mailman/listinfo/ros-svn > > > This is incorrect; other kernel-mode components should NOT use these macros. They should do it the "long way" and go through ProbeForRead. Best regards, Alex Ionescu

18 years, 9 months

RE: [ion] 19742: - Implement RtlPrefectMemoryNonTemporal.Patch by Patrick Baggett <baggett.patrick@gmail.com> and myself.

by Ge van Geldorp

> From: ion(a)svn.reactos.com > > + > +@RtlPrefetchMemoryNonTemporal@8: > + ret /* Overwritten by ntoskrnl/ke/i386/kernel.c if SSE is supported (see Ki386SetProcessorFeatures() ) */ Is this routine so time-critical that we want to resort to self-modifying code? GvG

18 years, 9 months

Kernel32 race condition

by Ge van Geldorp

While working on proper logoff/shutdown processing, I'm running into an interesting race condition inside kernel32. The shutdown command (apps/utils/shutdown) calls ExitWindowsEx() and then terminates, which causes kernel32's DllMain() function to be called with the DLL_PROCESS_DETACH reason. This will clean up kernel32 resources, like calling RtlDeleteCriticalSection(&ConsoleLock). Now, before the process is completely shutdown, CSRSS will send it a CTRL_LOGOFF_EVENT. To deliver this event, CSRSS calls CreateRemoteThread(). So CreateRemoteThread() is called while the main thread is executing DLL_PROCESS_DETACH cleanup. During handling of CTRL_LOGOFF_EVENT, the new thread will try to enter the ConsoleLock critical section, which was already deleted by the main thread. Chaos results. To solve this, first I was looking for a way to disable new thread creation when a process enters ExitProcess(), but that won't solve the problem. We can still have a thread A which calls ExitProcess(), have a context switch to existing thread B of the same process which does something that needs the ConsoleLock. Then I considered SuspendThread()ing all other threads of the process when ExitProcess() is called, but that could potentially lead to deadlocks if the suspended threads hold synchronization objects. So now I'm inclined to believe that the solution is to just not do the resource cleanup during DLL_PROCESS_DETACH handling. But that doesn't feel very clean either. Anyone have a better idea? GvG

18 years, 9 months

RE: [ros-svn] [weiden] 19755: remove obsolete shutdown tool from rosapps

by Sylvain Petreolle

> From: weiden at svn.reactos.com > > remove obsolete shutdown tool from rosapps You should remove it from bootdata/packages/reactos.dff too. Index: bootdata/packages/reactos.dff =================================================================== --- bootdata/packages/reactos.dff (revision 19798) +++ bootdata/packages/reactos.dff (working copy) @@ -352,6 +352,5 @@ modules\rosapps\sysutils\man\man.exe 1 optional modules\rosapps\sysutils\pedump\pedump.exe 1 optional modules\rosapps\sysutils\regexpl\regexpl.exe 1 optional -modules\rosapps\sysutils\shutdown\shutdown.exe 1 optional modules\rosapps\sysutils\tcat\cat.exe 1 optional modules\rosapps\sysutils\tlist\tlist.exe 1 optional Kind regards, Sylvain Petreolle (aka Usurp) --- --- --- --- --- --- --- --- --- --- --- --- --- Tired of a proprietary Windows on your computer ? Use free ReactOS instead ( http://www.reactos.org )

18 years, 9 months

Re: [ros-dev] Patch for lib/rtl/i386/math_asm.S

by Magnus Olsen

We do not support some binutils for diffent reason and I do not think this patch is good, for it active least one version of binutils that always break reactos, it does not the linking right or was it some other issue. And I do not want see this patch in reactos for that reason. see older mails why we support 2.15.94 or higher. ----- Original Message ----- From: "Alex Buell" <alex.buell(a)munted.org.uk> To: "ReactOS Development" <Ros-dev(a)reactos.org> Sent: den 29 November 2005 17:52 Subject: [ros-dev] Patch for lib/rtl/i386/math_asm.S > The following might be better for those of us using older binutils > > --- lib/rtl/i386/math_asm.S.orig 2005-11-29 15:47:23.000000000 > +0000 > +++ lib/rtl/i386/math_asm.S 2005-11-29 15:47:09.000000000 +0000 > @@ -731,7 +731,7 @@ > mov al,ah // Move condition flags to AL > lahf // Load Flags into AH > and al, 0b01000101 // Isolate C0, C2 and C3 > - and ah,not 0b01000101 // Turn off CF, PF and ZF > + and ah, 0b10111010 // Turn off CF, PF and ZF > or ah,al // Set new CF, PF and ZF > sahf // Store AH into Flags > jb __fpow1 // Re-direct if x < 0 > @@ -743,7 +743,7 @@ > mov al,ah // Move condition flags to AL > lahf // Load Flags into AH > and al, 0b01000101 // Isolate C0, C2 and C3 > - and ah,not 0b01000101 // Turn off CF, PF and ZF > + and ah, 0b10111010 // Turn off CF, PF and ZF > or ah,al // Set new CF, PF and ZF > sahf // Store AH into Flags > ja __fpow3 // Re-direct if y > 0 > @@ -759,7 +759,7 @@ > mov al,ah // Move condition flags to AL > lahf // Load Flags into AH > and al, 0b01000101 // Isolate C0, C2 and C3 > - and ah,not 0b01000101 // Turn off CF, PF and ZF > + and ah, 0b10111010 // Turn off CF, PF and ZF > or ah,al // Set new CF, PF and ZF > sahf // Store AH into Flags > je __fpow2 // Proceed if y = int(y) > > Cheers, > Alex > -- > http://www.munted.org.uk > > Anyone that thinks an imaginary deity is going to protect them against > earthquakes and hurricanes needs psychiatric help. > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev > > > -- > No virus found in this incoming message. > Checked by AVG Free Edition. > Version: 7.1.362 / Virus Database: 267.13.9/185 - Release Date: 2005-11-28 > >

18 years, 9 months

DOS Subsystem.

by Jerry

18 years, 9 months

Next release

by Murphy, Ged (Bolton)

We're at the 2 month period since our last release. Is it not time to branch now and chase some more publicity If Alex meets his 1st December deadline for User-Mode networking, I propose a 0.2.9 branch then. Any thoughts? ************************************************************************ The information contained in this message or any of its attachments is confidential and is intended for the exclusive use of the addressee. The information may also be legally privileged. The views expressed may not be company policy, but the personal views of the originator. If you are not the addressee, any disclosure, reproduction, distribution or other dissemination or use of this communication is strictly prohibited. If you have received this message in error, please contact postmaster(a)exideuk.co.uk <mailto:postmaster@exideuk.co.uk> and then delete this message. Exide Technologies is an industrial and transportation battery producer and recycler with operations in 89 countries. Further information can be found at www.exide.com

18 years, 9 months

New Project Coordinator

by Murphy, Ged (Bolton)

The voting is closed and ReactOS now has a new project coordinator. Steven Edwards has been appointed as Jason Filby's successor. Congratulations, and good luck ;) Speech ! ! ! ************************************************************************ The information contained in this message or any of its attachments is confidential and is intended for the exclusive use of the addressee. The information may also be legally privileged. The views expressed may not be company policy, but the personal views of the originator. If you are not the addressee, any disclosure, reproduction, distribution or other dissemination or use of this communication is strictly prohibited. If you have received this message in error, please contact postmaster(a)exideuk.co.uk <mailto:postmaster@exideuk.co.uk> and then delete this message. Exide Technologies is an industrial and transportation battery producer and recycler with operations in 89 countries. Further information can be found at www.exide.com

18 years, 9 months

19535 breaks copy.

by WaxDragon

This change breaks copy in cmd, unless you are in the root of a drive. >[ros-svn] [hbirr] 19535: - Allow trailing back slashes only for directories. >hbirr at svn.reactos.com hbirr at svn.reactos.com >Thu Nov 24 22:08:17 CET 2005 > > * Previous message: [ros-svn] [gvg] 19534: Fix optimized builds > * Next message: [ros-svn] [jimtabor] 19536: Fix missed files. Svn problem? > * Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] > >- Allow trailing back slashes only for directories. >- Allow trailing back slashes, if a new directory will be created. > > > >Updated files: >trunk/reactos/drivers/fs/vfat/create.c >trunk/reactos/drivers/fs/vfat/vfat.h WD -- <mikedep333> but if it isnt working, why is it even included on the CD?

18 years, 9 months

Status: mshta???

by Rick Langschultz

I was looking at reactos control panels and was wondering if there was any MS HTA or something like it embedded. I was thinking that XUL, Firefox, and Mozilla could be integrated into the Explorer and other things to dynamically update the interface of Reactos. Something like Apple's Safari RSS Reader, and Explorer's (XP) Sidebars with common tasks and utilities.

18 years, 9 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev