Ros-dev

ros-dev@reactos.org

1 participants
5793 discussions

Re: [ros-svn] [hbirr] 15117: - Changed IopCompleteRequest back to the old schematics (rev 14933) with some minor corrections.
by Alex Ionescu 08 May '05

08 May '05

hbirr(a)svn.reactos.com wrote: >- Set the IOSB on error for async irp's with a sync FO (fix bug #609). > > > Clearly, the problem is that someone is reading the Iosb instead of reading the FileObject->FinalStatus. Do you know who is doing that? Fixing the caller would fix the bug, instead of adding the hack into the IRP Code. Thanks for the commit, Best regards, Alex Ionescu

1 1

RE: [ros-svn] [weiden] 15110: more fixes for GCC4
by Ge van Geldorp 08 May '05

08 May '05

> From: weiden(a)svn.reactos.com > > more fixes for GCC4 > > Updated files: > trunk/reactos/tools/wrc/lex.yy.c Hmm, this is going to be a problem, lex.yy.c is a generated file. Gé van Geldorp.

3 3

RE: [ros-svn] [chorns] 15140: Delete old w32api
by Casper Hornstrup 08 May '05

08 May '05

You will likely need to remove the w32api directory before you "svn up" next time. Casper > -----Original Message----- > From: ros-svn-bounces(a)reactos.com [mailto:ros-svn-bounces@reactos.com] On Behalf Of > chorns(a)svn.reactos.com > Sent: 8. maj 2005 19:43 > To: ros-svn(a)reactos.com > Subject: [ros-svn] [chorns] 15140: Delete old w32api > > Delete old w32api > > > Deleted files: > trunk/reactos/w32api/

1 0

RE: [ros-svn] [ion] 15097: Wipe out current includes to start fresh.
by Casper Hornstrup 08 May '05

08 May '05

You are really abusing the version control system here. By not using a vendor import for the external project w32api, you make it much harder to keep local changes separate from the non-local changes to w32api and thus complicating the synchronization of the two. This is what Gé is currently doing with the shared wine code and eventually all external code should be imported this way to minimize maintenance. By re-importing the data from trunk instead of merging it from trunk, you effectively screw up the versioning. When the time comes to merge your changes to trunk, you cannot since there is no common history. The only way to get it to trunk is to use "svn delete" and "svn copy" and thus you loose any changes made to include/ and w32api/ on trunk since you created the branch. I'd suggest you read Gé's introduction at http://reactos.com/wiki/index.php/Using_code_from_other_projects and http://svnbook.red-bean.com/en/1.1/svn-book.html#svn-ch-7-sect-4 and do it this way instead. Casper > -----Original Message----- > From: ros-svn-bounces(a)reactos.com [mailto:ros-svn-bounces@reactos.com] On Behalf Of > ion(a)svn.reactos.com > Sent: 8. maj 2005 03:31 > To: ros-svn(a)reactos.com > Subject: [ros-svn] [ion] 15097: Wipe out current includes to start fresh. > > Wipe out current includes to start fresh. > > > Deleted files: > branches/new_headers/reactos/include/ > branches/new_headers/reactos/w32api/ > > _______________________________________________ > Ros-svn mailing list > Ros-svn(a)reactos.com > http://reactos.com:8080/mailman/listinfo/ros-svn

1 0

[Fwd: Re: Was: [ros-dev] Re: [ros-svn] [hbirr] 14988: - Networking broken]
by Gge 08 May '05

08 May '05

I just loaded reactos with svn 15089 , built during the night , and networking is completely broken. I cannot ping my dsl router ( request timeout ) Regards Gerard

1 0

Was: [ros-dev] Re: [ros-svn] [hbirr] 14988: - Guard the copying to the IOSB.
by Hartmut Birr 08 May '05

08 May '05

Copied from the archive because I will receive the mail in some hours: >hbirr at svn.reactos.com wrote: >>- Guard the copying to the IOSB. >>- Do the main processing on success or if previous STATUS_PENDING was returned. >> Do not use some of the IRP and FO flags at this point. >> >> >Ok, I was going to complain about this, but I realize that it must be >used since defintely some parts of ROS don't work properly with those >flags set. It isn't possible to use the flags, because some functions are always synchronous independently which flags are set. Ntoskrnl may set the flags correctly, but a driver may possible not. >>- Set all results before signaling the events. >>- Signal the FO event previous the user event. >>- Made the code a little bit shorter. >> >> >> >I like your changes and have no complaints, except that the signaling >semantics of the File/User events should be different in the failure >case (my "else" path). You've completely removed that path and thus >changed the logic. If the driver has returned STATUS_PENDING and completes the irp later with an error, both events must be signaled, because two different threads may waiting on this events. The IOSB must be also set. The apc must be also deliver (I've tested this with the apc sample and some modifications on windows). There is no difference between completing the irp with and without an error if the driver has returned STATUS_PENDING. - Hartmut

4 9

More Problems
by James Tabor 08 May '05

08 May '05

Hi, 8^(, svn 15092; (NTDLL:ldr/utils.c:2039) Failed to create or open dll section of 'midimap.drv' ( Status c0000135) (windows/input.c:97)(GetAsyncKeyState) is unimplemented, please try again later. (shell32_main.c:989:ShellDDEInit) stub: 1 (ntuser/class.c:114) Failed to lookup class atom! (windows/window.c:1493)(SetTaskmanWindow) is unimplemented, please try again lat er. Using shell hooks for notification of shell events. (ntuser/hook.c:504) Not implemented: HookId 3 Global TRUE (dispatch.c:166)(dispatch) Select: 0 (shlexec.c:1024:ShellExecuteExW32) flags ignored: 0x0000000c (dispatch.c:166)(dispatch) Select: 0 (dispatch.c:166)(dispatch) Select: 0 (shlexec.c:1024:ShellExecuteExW32) flags ignored: 0x0000000c (dispatch.c:166)(dispatch) Select: 0 (dispatch.c:166)(dispatch) Select: 0 (dispatch.c:166)(dispatch) Select: 0 (dispatch.c:166)(dispatch) Select: 0 (dispatch.c:166)(dispatch) Select: 0 (dispatch.c:166)(dispatch) Select: 0 (dispatch.c:166)(dispatch) Select: 0 (dispatch.c:166)(dispatch) Select: 0 (dispatch.c:166)(dispatch) Select: 0 (dispatch.c:166)(dispatch) Select: 0 (dispatch.c:166)(dispatch) Select: 0 (dispatch.c:166)(dispatch) Select: 0 (dispatch.c:166)(dispatch) Select: 0 (dispatch.c:166)(dispatch) Select: 0 (dispatch.c:166)(dispatch) Select: 0 (dispatch.c:166)(dispatch) Select: 0 (mm/npool.c:1648) Trying to allocate 224 bytes from nonpaged pool - nothing suit able found, returning NULL (mm/npool.c:1648) Trying to allocate 224 bytes from nonpaged pool - nothing suit able found, returning NULL Entered debugger on last-chance exception number 14 (Page Fault) Memory at 0x2c could not be written: Page not present. kdb:> bt Eip: <ntoskrnl.exe:45e38 (io/file.c:525 (IopCloseFile))> Frames: <ntoskrnl.exe:76408 (ob/handle.c:62 (ObpDecrementHandleCount))> <ntoskrnl.exe:76871 (ob/handle.c:212 (ObpDeleteHandle))> <ntoskrnl.exe:779f4 (ob/handle.c:909 (NtClose))> <ntoskrnl.exe:36e2 (/tmp/cc3xIFLn.s:180 (KiSystemService))> <ffff5485> <ntoskrnl.exe:478da (io/file.c:1958 (NtOpenFile))> <ntoskrnl.exe:36e2 (/tmp/cc3xIFLn.s:180 (KiSystemService))> <kernel32.dll:1c997 (file/file.c:863 (GetFileAttributesExW))> <kernel32.dll:1cb14 (file/file.c:919 (GetFileAttributesExA))> <msvcrt.dll:13f6a (sys_stat/stat.c:31 (_stat))> <make.exe:1d26b> <make.exe:1d11a> <make.exe:12bc9> <make.exe:1189> <make.exe:1018> <kernel32.dll:289b1 (process/create.c:331 (BaseProcessStart))> <deadbeef> kdb:>

1 0

Re: [ros-diffs] [sedwards] 15091: remove trailing whitespace at end of lines
by Alex Ionescu 07 May '05

07 May '05

sedwards(a)svn.reactos.com wrote: >remove trailing whitespace at end of lines > > *[truncated at 1000 lines; 37354 more skipped]* Steven, This patch is unacceptably large, and your commit message is way too short to explain all the changes. Please revert the patch immediately and work on a branch, submitting small patches at a time so that other developers can review them. Also, formatting patches are prohibited, so I don't think your patches can be accepted at all, even if in a branch. Best regards, Alex Ionescu <If anyone did not notice the sarcasm, please shoot yourselves. Great work Steven; I hoped you used an automated tool!>

3 4

Re: [ros-svn] [hbirr] 15089: - initialize a user profile before loading syssetup.dll.
by Gge 07 May '05

07 May '05

hbirr(a)svn.reactos.com wrote: > - initialize a user profile before loading syssetup.dll. > - this makes it possible to install ros over an existing ros. > > > > Updated files: > trunk/reactos/subsys/system/setup/makefile > trunk/reactos/subsys/system/setup/setup.c > Harmut , Does this apply if Ros is started from a freeldr diskette ? Regards Gerard

2 1

CRT/RTL Duplication
by Alex Ionescu 07 May '05

07 May '05

Hi, There are currently some files in ntoskrnl/rtl, lib/rtl, and /lib/crt which are duplicated. Stuff like vsprintf, sprintf, etc. I think they should be massaged into lib/string so that all the modules can share the code instead of duplicating it THREE times(!). Best regards, Alex Ionescu

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev