Ros-dev

ros-dev@reactos.org

5788 discussions

Re: [ros-dev] __attribute__((weak)) - in mingw

by Danny Smith

Boaz Harrosh wrote: > Danny Smith wrote: > > Will you have pre-compiled binaries with these patches for download on > ReactOS.org. No, I am a Mingw developer and I put binaries at mingw's SF site.. Please do, it is a very nice place to have them. And while > we are on the subject. GCC 3.4 is totally broken for ATL. It doesn't > even come close to even imagine to compile ATL. From some of the stuff I > saw it is breaking the standard. It took me 2 minutes to see that it has > no hope. So I have two things. 1 - please if you can keep a live version > of 3.3 with all above enhancements for us, poor, wrote millions of > Microsoft code, guys. 2 - Would you mine talking to me (on the list) > about what is broken in 3.4 and try to see what needs fixing on the > compiler side and what need to be done on the code side. I'll send you > examples of code and we can see what should be done for them and if such > changes are acceptable. > Please, if you want me to stay involved in this discusion,send posts to mingw-users(a)sourceforge.net. I have no intention of "fixing" gcc-3.3.x. My main interest is 4.0, but I will probably backport some changes from 4.0 branch into next gcc 3.4.4 mingw release. If you have specific examples of things that are broken on 3.4.x with mingw please submit a bug report. See http://www.mingw.org/bugs.shtml Danny > Free Life > Boaz > > P.S > My posts do not reach the List. At first I thought they don't go out at > all. But I see you got them. Any body got an Idea what can happen that > causes posts to get lost. Same thing happens to me with wine. Pretty > much consistent now. See if this goes threw

19 years, 10 months

Re: [ros-svn] [weiden] 13576: 1. a few previous mode fixes

by Alex Ionescu

weiden(a)svn.reactos.com wrote: >1. a few previous mode fixes > > >Updated files: >trunk/reactos/ntoskrnl/ke/alert.c >trunk/reactos/ntoskrnl/ke/apc.c >trunk/reactos/ntoskrnl/ke/error.c > > > Please revert these "fixes". They are incorrect. Best regards, Alex Ionescu

19 years, 10 months

Re: [ros-dev] __attribute__((weak)) - in mingw

by Danny Smith

Boaz Harrosh wrote: >> Danny Smith wrote: >> >>> Boaz Harrosh wrote: >>> >>> >>>> [Q] I'm (well ATL is) using __attribute__((weak)) (translated from >>>> __declspec( selectany) ) for instantiation of members and variables in >>>> headers. I had no problem with it On GCC in Linux (gcc 3.2.2). On MinGW >>>> >>>> >>> >>> IMAGE_COMDAT_SELECT_ANY is not quite same as PECOFF version of "weak" , but >>> AFAICT is equivalent to the GCC section flag ".linkonce discard". I don't >>> think there is a way for the user to specify that for data using an >>> attribute, but it could be done with asm statements. >>> >>> .weak directive is partially supported in current binutils CVS. >>> __attribute__((weak)) is not supported by GCC-3.4.x but will be in the next >>> major GCC release (4.0.0). >>> Sorry, that was unclear. I should have qualified with "on windows targets" >>> The semantics of weak for PECOFF differ from that on Linux.See the PECOFF60 >>> specs (Microsoft Portable Executable and Common Object File Format >>> Specification) section on weak externals >>> >>> Danny >>> >>> >> (binutils at sources dot redhat dot com please also cc me as I'm not on >> the list) >> >> Attached is a proof (See fooInt.h) that gcc (gcc version 3.2 (mingw >> special 20020817-1)) has support for weak symbols. Just not with the >> regular syntax. >> But when templates are used duplicate symbols are merged by the linker. >> >> What would be the assembler magic to cram into the __WEAK__ definition >> that would make this project link? >> I am currently testing a patch to GCC to add an __attribute__ ((selectany)) that would work the way it is discribed in MS docs and in the spec of IMAGE_COMDAT_SELECT_ANY in PECOFF doc. Basically it puts the symbol into its own section with ".linkonce discard" charcteristics. __declspec (selectany) int foo = 1; becomes: .globl _foo .section .data$foo,"w" .linkonce discard .align 4 _foo: .long 1 So far the only problem I've seen is that, although it works for global objects with non-trivial constructors eg: struct X { static int s; int m; X(int _i) : m(_i) { m++; } }; __declspec(selectany) int X::s = -1; // OK __declspec(selectany) X x(1); // This is OK but app will be bloated with // duplicate initialization code. . I haven't figured out how to get rid of the duplicated inititialization code I will submit the patch for comment once GCC trunk branches. Danny >> Free Life >> Boaz >> > >

19 years, 10 months

Re: [ros-svn] [gvg] 13584: Fix ROUND_UP when N is a multiple of S. Proposed by unC0Rr.

by Hartmut Birr

gvg(a)svn.reactos.com schrieb: >Fix ROUND_UP when N is a multiple of S. Proposed by unC0Rr. > > > >Updated files: >trunk/reactos/tools/mkhive/binhive.c > >_______________________________________________ >Ros-svn mailing list >Ros-svn(a)reactos.com >http://reactos.com:8080/mailman/listinfo/ros-svn > > > > Hi, I don't like this implemention (and the old one) of ROUND_UP and ROUND_DOWN. I would prefer: #define ROUND_UP(N,S) (((N) + (S) -1) & ~((S) -1)) #define ROUND_DOWN(N,S) ((N) & ~((S) - 1)) - Hartmut

19 years, 10 months

msvcrt headers removal

by Gunnar Dalsnes

Hi. Does anyone know why ros duplicate the mingw msvcrt headers in include\msvcrt? If no one objects, I will remove those duplicates and use the mingw headers 100%. Gunnar

19 years, 10 months

Re: [ros-svn] [fireball] 13520: Added cromwell's drivers into build/install process. Now we have two alternatives: usbport/usbXhci or usbcore/ohci.sys. With time they will be merged into one, or cromwell will be wasted and usbport/usbXhci will be written from scratch.

by Mark Tempel

fireball(a)svn.reactos.com wrote: >Added cromwell's drivers into build/install process. Now we have two alternatives: usbport/usbXhci or usbcore/ohci.sys. With time they will be merged into one, or cromwell will be wasted and usbport/usbXhci will be written from scratch. > > >Updated files: >trunk/reactos/drivers/usb/Makefile > >_______________________________________________ >Ros-svn mailing list >Ros-svn(a)reactos.com >http://reactos.com:8080/mailman/listinfo/ros-svn > > > > I would expect that USBPORT/USBXXXHCI will just delegate to cromwell. That way we can use cromwell like we use wine or oskit tcp... --mark

19 years, 10 months

typo in hivesys.inf

by netzimme＠netscape.net

Hi Here is a little patch for the typo: Index: hivesys.inf =================================================================== --- hivesys.inf (revision 13570) +++ hivesys.inf (working copy) @@ -11,7 +11,7 @@ HKLM,"SYSTEM\CurrentControlSet\Control\Class\{4D36E965-E325-11CE-BFC1-08002BE10318}",,0x00000000,"DVD/CD-ROM drives" HKLM,"SYSTEM\CurrentControlSet\Control\Class\{4D36E965-E325-11CE-BFC1-08002BE10318}","Class",0x00000000,"CDROM" -HKLM,"SYSTEM\CurrentControlSet\Control\Class\{4D36E972-E325-11CE-BFC1-08002BE10318}","EnumPropPages32",0x00000000,"MmSys.Cpl,MediaPropPageProvider" +HKLM,"SYSTEM\CurrentControlSet\Control\Class\{4D36E965-E325-11CE-BFC1-08002BE10318}","EnumPropPages32",0x00000000,"MmSys.Cpl,MediaPropPageProvider" HKLM,"SYSTEM\CurrentControlSet\Control\Class\{4D36E965-E325-11CE-BFC1-08002BE10318}","Icon",0x00000000,"-20" HKLM,"SYSTEM\CurrentControlSet\Control\Class\{4D36E965-E325-11CE-BFC1-08002BE10318}","NoInstallClass",0x00000000,"1" __________________________________________________________________ Switch to Netscape Internet Service. As low as $9.95 a month -- Sign up today at http://isp.netscape.com/register Netscape. Just the Net You Need. New! Netscape Toolbar for Internet Explorer Search from anywhere on the Web and block those annoying pop-ups. Download now at http://channels.netscape.com/ns/search/install.jsp

19 years, 10 months

Re: [ros-dev] NIC RTL8029 will work with NE2000

by netzimme＠netscape.net

James Tabor <jimtabor(a)adsl-64-217-116-74.dsl.hstntx.swbell.net> wrote: >netzimme(a)netscape.net wrote: >> Hi Ros-Dev >> >> I have a patch that let a RTL8029 based NIC work with >> the ne2000 driver and partiell with the original driver. >> The problem is when the 'size' is 0 and the queriy run in >> NDIS_STATUS_INVALID_LENGTH. Then the size is never set to >> the a new value. >> >Hi, >What was your hivesys.inf setup like? Hi James Add this entries : HKLM,"SYSTEM\CurrentControlSet\Control\Class\{4D36E972-E325-11CE-BFC1-08002BE10318}\0001","Port",0x00000000,"B800" HKLM,"SYSTEM\CurrentControlSet\Control\Class\{4D36E972-E325-11CE-BFC1-08002BE10318}\0001","Irq",0x00000000,"A" This can you get when you run the DOS-Utility from the NIC to see the IRQ and Port Number. Under Windows 2000 there are difference entries. HKLM,"SYSTEM\CurrentControlSet\Control\Class\{4D36E972-E325-11CE-BFC1-08002BE10318}\0001","BusType",0x00000000,"5" This is from the Registry from Windows 2000 HKLM,"SYSTEM\CurrentControlSet\Control\Class\{4D36E972-E325-11CE-BFC1-08002BE10318}\0001","SlotNumber",0x00000000,"11" HKLM,"SYSTEM\CurrentControlSet\Control\Class\{4D36E972-E325-11CE-BFC1-08002BE10318}\0001","BusNumber",0x00000000,"0" And this i get from the BIOS bootscreen. HKLM,"SYSTEM\CurrentControlSet\Services\Ne2000","Start",0x00010001,0x00000003 To start the ne2000 driver. Hope this helps Daniel __________________________________________________________________ Switch to Netscape Internet Service. As low as $9.95 a month -- Sign up today at http://isp.netscape.com/register Netscape. Just the Net You Need. New! Netscape Toolbar for Internet Explorer Search from anywhere on the Web and block those annoying pop-ups. Download now at http://channels.netscape.com/ns/search/install.jsp

19 years, 10 months

NIC RTL8029 will work with NE2000

by netzimme＠netscape.net

Hi Ros-Dev I have a patch that let a RTL8029 based NIC work with the ne2000 driver and partiell with the original driver. The problem is when the 'size' is 0 and the queriy run in NDIS_STATUS_INVALID_LENGTH. Then the size is never set to the a new value. Index: miniport.c =================================================================== --- miniport.c (revision 13495) +++ miniport.c (working copy) @@ -603,7 +603,7 @@ Adapter->NdisMiniportBlock.MiniportAdapterContext, Oid, Adapter->QueryBuffer, - Size, + Adapter->QueryBufferLength, BytesWritten, &BytesNeeded); } __________________________________________________________________ Switch to Netscape Internet Service. As low as $9.95 a month -- Sign up today at http://isp.netscape.com/register Netscape. Just the Net You Need. New! Netscape Toolbar for Internet Explorer Search from anywhere on the Web and block those annoying pop-ups. Download now at http://channels.netscape.com/ns/search/install.jsp

19 years, 10 months

__attribute__((weak)) - in mingw

by Boaz Harrosh

Hi List I'm finally on my ass trying to redo the ATL/MFC Job from a year ago. This time I decided to start on windows with MinGW than move the MinGW makefiles to be used with winegcc. It is a grate test for winegcc and the windows API in general. Well it turns out to be a very big test for MinGW as well. The headers are in a very bad shape. I had to use Wine headers to be able to compile. but I'll leave all that to a later e-mail. [Q] I'm (well ATL is) using __attribute__((weak)) (translated from __declspec( selectany) ) for instantiation of members and variables in headers. I had no problem with it On GCC in Linux (gcc 3.2.2). On MinGW I get below warning. And needless to say that I get a Linker duplicate symbol Error. Any Ideas on how to overcome this. Is this a g++ only bug? <g++ warning example> H:\Dinosaur\OneSource\MinGWStudio\msvc\atl\include\atlhost.h:56: warning: weak declaration of `UINT ATL::WM_ATLGETCONTROL' not supported </g++ warrning example> <linker error example> H:\Dinosaur\OneSource\MinGWStudio\msvc\atl\include\atlwin.h: multiple definition of `ATL::WM_ATLGETCONTROL' H:\Dinosaur\OneSource\MinGWStudio\Samples\AtlWB\Debug\aboutdlg.o(.bss+0x1c):H:\Dinosaur\OneSource\MinGWStudio\msvc\atl\include\atlwin.h: first defined here </linker error example> Please forgive me for sending it here and not to MinGW list. But I feel more at home here than there. ( :( ) Free Life Boaz

19 years, 10 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev