Ros-dev

ros-dev@reactos.org

5791 discussions

Re: [ros-diffs] [hbirr] 13257: - Interpret STATUS_TIMEOUT as error in PsLockProcess.
by Filip Navara 25 Jan '05

25 Jan '05

hbirr(a)svn.reactos.com wrote: >- if(!NT_SUCCESS(Status)) > > >+ if(!NT_SUCCESS(Status) || STATUS_TIMEOUT) > > Shouldn't this be "|| Status == STATUS_TIMEOUT" ?

3 2

Re: [ros-dev] Re: We have a web browser : Input ?
by barry day 25 Jan '05

25 Jan '05

On Mon, Jan 24, 2005 at 08:49:17PM -0500, Richard Campbell wrote: > If internet explorer were a 'mistake' it wouldn't have a 92% user base. > If it isn't working, people wouldn't use it. It took quite a long time > for a worthy competitor (firefox) to appear. Anyways, cloning internet > explorer is outside the scope of this project. It may BE a part of > windows, but we can install it (IE5 at least) seperately (eventually). > What the user base is depends on who you ask. Nobody appears to have irrefutable up-to-date figures. And do you describe a program that CERT advises people not to use as "works"? But lets not argue over this. My reason for posting my commments is simply because I think some of us are only aiming at implementing a clone whereas I feel we should be striving to create a compatible OS that is even better, and I get the impression from the faq on the wiki site that was one of the reasons for this project's existence. But on the other hand that risks becoming bogged down in discussion about how things should be done. If at the end of the day we end up with nothing more than an open source clone of Windows that I can hack on I will still be happy.

1 0

Re: [ros-dev] Re: We have a web browser : Input ?
by barry day 25 Jan '05

25 Jan '05

On Mon, Jan 24, 2005 at 04:54:58PM -0600, Royce Mitchell III wrote: > Steven Edwards wrote: > > We may have to install it as both iexplore.exe as well as ibrowser.exe, > because certain ill-behaved apps may look for iexplore.exe, and we want > it to find the user's browser, regardless of whether they've installed > MS's IE or are using ours. > But if the user's choice of browser is firefox or something else then that's not going to work is it.

1 0

Re: [ros-dev] Re: We have a web browser : Input ?
by barry day 24 Jan '05

24 Jan '05

On Mon, Jan 24, 2005 at 04:54:58PM -0600, Royce Mitchell III wrote: > We may have to install it as both iexplore.exe as well as ibrowser.exe, > because certain ill-behaved apps may look for iexplore.exe, and we want > it to find the user's browser, regardless of whether they've installed > MS's IE or are using ours. > That should be left to the developer of the buggy app to fix. One of the reasons Windows has problems with malware is because of developers going about things the wrong way. They need to be taught to do things correctly, not accommodated for.

2 1

Re: [ros-svn] [gvg] 13252: IoCreateFile should be passed kernelmode parameters.
by Hartmut Birr 24 Jan '05

24 Jan '05

gvg(a)svn.reactos.com schrieb: >IoCreateFile should be passed kernelmode parameters. > > > >Updated files: >trunk/reactos/ntoskrnl/include/internal/safe.h >trunk/reactos/ntoskrnl/io/create.c >trunk/reactos/ntoskrnl/io/mailslot.c >trunk/reactos/ntoskrnl/io/npipe.c >trunk/reactos/ntoskrnl/rtl/capture.c > >_______________________________________________ >Ros-svn mailing list >Ros-svn(a)reactos.com >http://reactos.com:8080/mailman/listinfo/ros-svn > > > > Hi, it seems that the memory for the captured parameters is never freed. - Hartmut

1 0

memory leakage
by Hartmut Birr 24 Jan '05

24 Jan '05

Hi, since some days ros eats up paged pool memory. I'm using cmd as login shell. 'Make clean' on the ros source tree increase the number of paged pool pages from 500 to more than 8000. In the past the number of paged pool pages has never changed. - Hartmut

1 0

Re: [ros-svn] [ion] 13130: Bug fixes against uninitizlied variables and support for tree-wide optimization (do not try yet, crashes in bootvid).
by Alex Ionescu 24 Jan '05

24 Jan '05

ion(a)svn.reactos.com wrote: >Bug fixes against uninitizlied variables and support for tree-wide optimization (do not try yet, crashes in bootvid). > > >Updated files: >trunk/reactos/config >trunk/reactos/drivers/lib/ip/transport/datagram/datagram.c >trunk/reactos/drivers/net/afd/afd/connect.c >trunk/reactos/drivers/net/afd/afd/write.c >trunk/reactos/drivers/net/tcpip/tcpip/info.c >trunk/reactos/hal/halx86/generic/dma.c >trunk/reactos/lib/epsapi/enum/drivers.c >trunk/reactos/lib/msafd/misc/dllmain.c >trunk/reactos/lib/shellext/slayer/slayer.c >trunk/reactos/lib/ws2_32/misc/ns.c >trunk/reactos/ntoskrnl/Makefile >trunk/reactos/regtests/shared/regtests.h >trunk/reactos/subsys/csrss/win32csr/guiconsole.c >trunk/reactos/subsys/win32k/makefile >trunk/reactos/tools/helper.mk > > If some of you would like to turn OPTIMIZED = 1 and help me with some of the current problems, I'd appreciate it greatly: 1) Bootvid crashes during boot logo intialization. Booting with NOGUIBOOT gets ros to the installation page, where 2) Default selections for radio buttons and combobox do not appear, they must now be selected manually Apart from this glitch, driver installation and second boot were perfect, minus the following: 3) Debug message about unhandled exception, followed by an explorer crash related to a header file. 4) Browsing some registry keys in regedit causes regedit to crash. I haven't noted any other problems for now, but I haven't done any deep testing. On the up side, this brings my little syscall benchmark to 170ms, an additional 15% improvement. In total, this is an 80% improvement over int2e builds. Furthermore, all of ReactOS is extremly fast. Directory listing in cmd.exe is instant, explorer navigation as well. Menus re-draw instantly and the whole experience is smooth. It really feels like Windows, you have to try it to believe it. There's been some talk on activating OPTIMIZED = 1 if (K)DBG != 1 and all the developers on IRC were in agreement. But before such a change is made, the bugs above need to be fixed, as well as any other possible things which might crop up. Best regards, Alex Ionescu

2 3

RE: [ion] 12806: Use proper PISID pointer to SID structure, fix wrong LUID definition, and remove duplicate code in Security Manager
by Ge van Geldorp 24 Jan '05

24 Jan '05

> From: ion(a)svn.reactos.com > > Use proper PISID pointer to SID structure, fix wrong LUID > definition, and remove duplicate code in Security Manager > > Updated files: > trunk/reactos/include/ntos/security.h Are you sure that the constants for e.g. SYSTEM_LUID need to be enclosed in double braces for MinGW? I'd expect SYSTEM_LUID to be of type LUID. That would make the code in ntoskrnl\se\luid.c where SYSTEM_LUID is assigned to a LARGE_INTEGER instead of a LUID incorrect. Gé van Geldorp.

1 0

Re: [ros-svn] [weiden] 13138: implemented the ProcessSessionInformation information class
by Hartmut Birr 24 Jan '05

24 Jan '05

weiden(a)svn.reactos.com schrieb: >implemented the ProcessSessionInformation information class > > >Updated files: >trunk/reactos/ntoskrnl/ps/process.c > >_______________________________________________ >Ros-svn mailing list >Ros-svn(a)reactos.com >http://reactos.com:8080/mailman/listinfo/ros-svn > > > > Hi, I think that some parts of your implementation are incorrect. The function must check for the location of the buffer and the previous mode. If the previous mode is user mode, the buffer must be located within the user address space. IMHO using of MmCopyFrom/ToCaller is better than using an exception block. It is also true for your following commits. - Hartmut

10 16

Re: [ros-svn] [weiden] 13226: the system process should be called "System", not "SYSTEM"
by Emanuele Aliberti 23 Jan '05

23 Jan '05

weiden(a)svn.reactos.com wrote: >the system process should be called "System", not "SYSTEM" > > SYSTEM = NT 3.x, 4.0 System = NT 5.x

2 2

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev