GvG
This change breaks explorer.
Ge van Geldorp wrote:
>CVSROOT: /CVS/ReactOS
>Module name: reactos
>Repository: reactos/lib/shell32/
>Changes by: gvg(a)mok.osexperts.com 04/09/29 00:01:38
>
>Modified files:
> reactos/lib/shell32/: folders.c shfldr.h shlfolder.c
>
>Log message:
> Robert Shearman <rob(a)codeweavers.com>
> - Simplify getting custom icons for a folder by utilising the new
> SHELL32_GetCustomFolderAttribute function.
> - Add support for custom shell folders, such as the History folder.
> - Always try to initialize folder using IPersistFolder3 interface and
> then fall back on IPersistFolder if not supported.
>
>_______________________________________________
>Ros-cvs mailing list
>Ros-cvs(a)reactos.com
>http://reactos.com/mailman/listinfo/ros-cvs
>
>
>
Well, As Royce pointed out to me yesterday, it appears that the user
profile is created the first time the user logs on...and the registry
entries are set up. My question is how should this be handled in ROS?
In WINLOGON? Does anyone have any documentation on the windows logon
procedure available?
Richard
Hi,
This is especially in regard to Steven, since he mentionned it might be
a WINE bug. I had mentionned that the Edit Box cursor/text isn't always
centered...and I finally managed to get a good picture, attached below.
I agree this is a trivial bug but I'm just posting it for all to see and
so that Steven can possibly put it on WINE's bug list (if it's indeed a
WINE bug)
Best regards,
Alex Ionescu
"Richard Campbell" <rcampbell(a)cvs.reactos.com> wrote:
> CVSROOT: /CVS/ReactOS
> Module name: reactos
> Repository: reactos/bootdata/
> Changes by: rcampbell(a)mok.osexperts.com 04/09/28 18:26:36
>
> Modified files:
> reactos/bootdata/: hivedef.inf hivesft.inf
>
> Log message:
> - Changed a few REG_EXPAND_SZ to REG_SZs as per Windows
Please revert that change! These values _must_ be expandable in ReactOS to
work properly, no matter which type is used by Windows.
Regards,
Eric
Hi,
i386-mingw32-gcc -I./include -D__NTOSKRNL__ -g -Wall -Werror -D_DISABLE_TIDENTS
-D_SEH_NO_NATIVE_NLG -I../include -I../w32api/include -pipe -march=i486 -D_M_IX86 -c mm/section.c -o
mm/section.o
mm/section.c: In function `MmMapViewOfSection':
mm/section.c:3812: error: too few arguments to function `MmFindGap'
make: *** [mm/section.o] Error 1
Need to make clean and recompile ntoskrnl.
Thanks,
James
> From: Hartmut Birr
>
> Log message:
> - Rewrote (copied from ntdll) parts of the relocation
> and import fixup code.
> - Don't load no-load sections at the end of the driver.
> - Don't relocate the relocation section itself.
> - Set the correct page protection for section which are
> executable.
With current CVS, the VMware SVGA driver crashes. It happens in a
HwFindAdapter() call. While tracing through the driver, I got this eery
"I've been here before" feeling. And sure enough, I fixed this same crash
about a year and a half ago.
The problem is that vmx_svga.sys has a section alignment of 0x20 instead of
the normal 0x1000. So, sections are much smaller than the page size. When
setting the page protections you need to take into account all the sections
which might be mapped to that page. This was implemented in
ntoskrnl/ldr/loader.c rev 1.126.
Gé van Geldorp.
I started putting in ASSERT_IRQL in ntoskrnl, hoping that only my own code
would break from it. The results are ... interesting.
I've put a metabug (426) on bugzilla which is about reactos not honoring
documented irql requirements. I fixed a place in win32k.sys, but there
are probably more. I think we should clean these up and get the
assert_irqls into HEAD, so that people like me won't get bitten over and
over by assuming we're in one irql when we're in another.
Unrelated, please take a look at the following patch, anyone who's cozy
with the mm. The reason why this code is needed is that MmNotPresentFault
and MmAccessFault will try to lock the address space as well as
MmProbeAndLockPages. Since this is a spin lock, reactos will always
bugcheck when MmProbeAndLockPages faults in a page, even if that would
be legal otherwise. I'm not sure if this patch fixes it right but it does
seem to work this way. If i don't hear too many complaints i'll think
about committing something similar.
There are a couple of other places where MmNotPresentFault is called
(section.c) within a MmLockAddressSpace. Another idea would be to give
MmNotPresentFault and MmAccessFault an extra argument so they can ignore
locking if the address space is already locked.
--
Hey, Adam Smith, keep your invisible hands to yourself!
Hello!
I thought I would try running Cygwin on a ReactOS CVS build, and
after talking with some of you on IRC, I went ahead.
After setting PATH=c:\cygwin\bin;%PATH%, dd.exe, uniq.exe,
bash.exe, and ls.exe all drop ros to the kernel debugger with an
exception 14. This is on the now dead Command Prompt:
41 [Main] ? 10 cygheap_user::init: SetTokenInformation
(TokenDefaultDacl): Win32 error 1
Here is the debug output leading up to the exection of uniq.exe:
(objects/gdiobj.c:401) Can't delete hObj:0x00042d77, type:0x007f0000, flag:0
(objects/gdiobj.c:401) Can't delete hObj:0x00042f72, type:0x007f0000, flag:0
(ntuser/desktop.c:808) RtlQueryRegistryValues failed for
PaintDesktopVersion: status=c0000005
(NTDLL:ldr/utils.c:2060) Relocating (10000000 -> 631000)
C:\cygwin\bin\cygiconv-2.dll
(NTDLL:ldr/utils.c:2060) Relocating (77f00000 -> 941000)
C:\ReactOS\system32\KERNEL32.dll
(NTDLL:ldr/utils.c:2060) Relocating (77dc0000 -> 9ba000)
C:\ReactO(NTDLL:ldr/utils.c:2060) Relocating (61000000 -> 9d0000)
C:\cygwin\bin\cygwin1.dll
S\system32\advapi32.dll
(sec/misc.c:489) GetUserNameA: stub
Entered debugger on exception number 14.
Entered kernel debugger (type "help" for a list of commands)
kdb:> bt
Frames: <ntoskrnl.exe: e326c (ob/security.c:311 (NtSetSecurityObject))>
<ntoskrnl.exe: 3e5b (:148 (KeUserModeCallback))>
<ntdll.dll: 3379 (napi.c:404 (NtSetSecurityObject))>
All of the above commands result in the "GetUserNameA: stub" error and
the message on the command prompt.
Andy
--
The cheese stands alone.
(io/arcname.c:375) Booting from CD-ROM!
(io/arcname.c:319) Could not find ntoskrnl.exe
IoCreateSystemRootLink FAILED: (0xc0000001) - %KERNEL-WRN-UNSUCCESSFUL
UNSUCCESSFUL
KeBugCheck at ke/main.c:687
Bug detected (code 7b param 0 0 0 0)
INACCESSIBLE_BOOT_DEVICE
Frames: <ntoskrnl.exe: a859> <ntoskrnl.exe: a879> <C0082E12>
<ntoskrnl.exe: c0a9> <C0083681> <ntoskrnl.exe: 115c>
this is using the livecd, haven't figured out how to mod the bootcd to
display that output.
Hi,
can you disable line #32 (#define NDEBUG)in ntoskrnl\io\arcname.c and try it
again?
- Hartmut
> -----Original Message-----
> From: ros-kernel-bounces(a)reactos.com
> [mailto:ros-kernel-bounces@reactos.com] On Behalf Of Richard Campbell
> Sent: Tuesday, September 28, 2004 7:34 PM
> To: ros-kernel(a)reactos.com
> Subject: [ros-kernel] BootCD doesn't boot...
>
>
> Hello all
>
> I'm using a fresh CVS checkout and ROS fails to boot in
> either VMWare or
> QEMU via the iso built by mingw32-make bootcd.
>
> Attached is a screen.
>
