Ros-dev

ros-dev@reactos.org

5788 discussions

Re: [ros-dev] [ros-diffs] [cwittich] 68673: [MSAFD] don't trace an uninitialized UNICODE_STRING

by Thomas Faber

On 2015-08-10 19:54, cwittich(a)svn.reactos.org wrote: > @@ -40,8 +40,8 @@ > PLIST_ENTRY Helpers; > INT Status; > > - TRACE("AddressFamily %p, SocketType %p, Protocol %p, Group %u, Flags %lx, TransportName %wZ, HelperDllContext %p, HeplperDllData %p, Events %p\n", > - AddressFamily, SocketType, Protocol, Group, Flags, TransportName, HelperDllContext, HelperDllData, Events); > + TRACE("AddressFamily %p, SocketType %p, Protocol %p, Group %u, Flags %lx, HelperDllContext %p, HeplperDllData %p, Events %p\n", > + AddressFamily, SocketType, Protocol, Group, Flags, HelperDllContext, HelperDllData, Events); So change it to %p? This is tracing all function arguments... seems keeping that scheme would be good. (also you could fix the Heplper typo if you're already at it :p)

9 years, 5 months

Re: [ros-dev] [ros-diffs] [dreimer] 68672: [BROWSEUI] Address is untranslatable by Adam Stachowicz CORE-9977 #resolve #comment Committed (with a Unicode fix), thx ^^

by Thomas Faber

On 2015-08-10 18:52, dreimer(a)svn.reactos.org wrote: > --- trunk/reactos/dll/win32/browseui/addressband.cpp [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/browseui/addressband.cpp [iso-8859-1] Mon Aug 10 16:52:40 2015 > @@ -93,7 +93,11 @@ > pdbi->ptActual.y = 22; > } > if (pdbi->dwMask & DBIM_TITLE) > - wcscpy(pdbi->wszTitle, L"Address"); > + { > + if (!LoadStringW(_AtlBaseModule.GetResourceInstance(), IDS_ADDRESSBANDLABEL, pdbi->wszTitle, _countof(pdbi->wszTitle))) > + return E_FAIL; > + } As a general rule, try not to use E_FAIL. HRESULT_FROM_WIN32(GetLastError()) would probably be correct here.

9 years, 5 months

Audio development

by Andrew Greenwood

Hi everyone, Some of you probably remember me. I was involved with trying to get audio/sound implemented in ReactOS a few years ago. To be honest, my progress was rather poor, I managed to write a few bits of code but never really had a proper understanding of kernel/OS development or CPU/system architectures. Additionally, whilst I could grasp how the multimedia APIs (MME) in NT4 worked, and how they interacted with the drivers (audio device X opens device Y and writes buffered data to it) for Windows 2000 and later, Kernel Streaming was used which partly built on top of the older implementation but added a load of new stuff. This complicated matters as firstly, KS uses COM (which I still struggle to wrap my head around) in kernel-mode, secondly there were multiple components involved between the application and the hardware (wdmaud.drv -> wdmaud.sys -> ks.sys -> portcls.sys -> driver as far as I remember), and finally I really struggled to find example code and thorough documentation describing how it all worked. Ultimately I gave up with that and intended to move to another platform to develop multimedia applications. Not much happened with that. I remember there were complaints from application developers over Kernel Streaming offering poor latency - instead developers would turn to other technologies such as ASIO or DirectSound. So for recent versions of Windows (Vista onwards?) Microsoft implemented a new, user-mode sound system (WASAPI) which again uses COM but is pretty nicely documented, with code samples. Having done a little reading about this, it renewed my interest. It still uses COM, and KS.SYS is still present (I assume for compatibility?) but as a lot of this is implemented in user-space I suspect it'd be easier to develop/test. Aside from this, over the past few years I've also gained a better understanding of topics I didn't know much about previously and I feel more confident at being able to write lower-level stuff that works properly. I've also developed more of a keen interest in how Windows works. So basically I'm considering implementing the current Windows audio system in ReactOS. I'd imagine we don't need to be too concerned about audio drivers themselves (at least, initially) as vendors tend to offer these and it's not like we need sound immediately post-install! The only thing I really lack now is knowledge of how to implement COM classes - at least, outside of using Visual Studio. Anyone got recommended reading or example code for this? Andrew

9 years, 5 months

Re: [ros-dev] [ros-diffs] [dreimer] 68645: [shell32] Change Trash to Recycle Bin by Lee Schroeder CORE-8391 #resolve #comment Committed the big one with changes to all RC files, because it's the right way to do that. All th...

by Thomas Faber

Well... since you asked... Really good reason not to: if something's not broken, don't fix it. Really good reason not to: if everything works fine and the user experience is generally Windows-like, we should NOT try to make things more Windows-like. On the contrary. Different is good, both in terms of project philosophy and legally. Really good reason not to: as another non-native speaker... neither of the two terms seems better than the other for any objective reason. Except that 'trash' is something people actually say :p Keep on hacking! ;) On August 9, 2015 9:56:47 AM CEST, dreimer(a)svn.reactos.org wrote: >Author: dreimer >Date: Sun Aug 9 07:56:47 2015 >New Revision: 68645 > >URL: http://svn.reactos.org/svn/reactos?rev=68645&view=rev >Log: >[shell32] >Change Trash to Recycle Bin by Lee Schroeder >CORE-8391 #resolve #comment Committed the big one with changes to all >RC files, because it's the right way to do that. All these strings are >originated from the english resource and NEVER were translated up to >now, so we keep these strings in sync. Second argument. Trash is not >the right word here (YES, a non native dares to say this ^^) We use the >Windows way here, unless someone gives me a REALLY good reason not to >^^ > >Modified: > trunk/reactos/dll/win32/shell32/lang/ca-ES.rc > trunk/reactos/dll/win32/shell32/lang/da-DK.rc > trunk/reactos/dll/win32/shell32/lang/en-US.rc > trunk/reactos/dll/win32/shell32/lang/fi-FI.rc > trunk/reactos/dll/win32/shell32/lang/he-IL.rc > trunk/reactos/dll/win32/shell32/lang/hu-HU.rc > trunk/reactos/dll/win32/shell32/lang/ko-KR.rc > trunk/reactos/dll/win32/shell32/lang/nl-NL.rc > trunk/reactos/dll/win32/shell32/lang/pt-BR.rc > trunk/reactos/dll/win32/shell32/lang/sl-SI.rc > trunk/reactos/dll/win32/shell32/lang/sv-SE.rc > trunk/reactos/dll/win32/shell32/lang/zh-TW.rc > >Modified: trunk/reactos/dll/win32/shell32/lang/ca-ES.rc >URL: >http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/ca-… >============================================================================== >--- trunk/reactos/dll/win32/shell32/lang/ca-ES.rc [iso-8859-1] >(original) >+++ trunk/reactos/dll/win32/shell32/lang/ca-ES.rc [iso-8859-1] Sun Aug >9 07:56:47 2015 >@@ -661,7 +661,7 @@ > /* special folders */ > IDS_DESKTOP "Desktop" > IDS_MYCOMPUTER "My Computer" >- IDS_RECYCLEBIN_FOLDER_NAME "Trash" >+ IDS_RECYCLEBIN_FOLDER_NAME "Recycle Bin" > IDS_CONTROLPANEL "Control Panel" > IDS_ADMINISTRATIVETOOLS "Administrative Tools" > >@@ -689,10 +689,10 @@ > IDS_DELETEITEM_TEXT "Are you sure you want to delete '%1'?" >IDS_DELETEMULTIPLE_TEXT "Are you sure you want to delete these %1 >items?" >IDS_DELETESELECTED_TEXT "Are you sure you want to delete the selected >item(s)?" >- IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the >Trash?" >- IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and >all its content to the Trash?" >- IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these >%1 items to the Trash?" >- IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Trash. Do you >want to delete it instead?" >+ IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the >Recycle Bin?" >+ IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and >all its content to the Recycle Bin?" >+ IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these >%1 items to the Recycle Bin?" >+ IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Recycle Bin. Do >you want to delete it instead?" >IDS_OVERWRITEFILE_TEXT "This folder already contains a file called >'%1'.\n\nDo you want to replace it?" > IDS_OVERWRITEFILE_CAPTION "Confirm file overwrite" >IDS_OVERWRITEFOLDER_TEXT "This folder already contains a folder named >'%1'.\n\nIf the files in the destination folder have the same names as >files in the\nselected folder they will be replaced. Do you still want >to move or copy\nthe folder?" > >Modified: trunk/reactos/dll/win32/shell32/lang/da-DK.rc >URL: >http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/da-… >============================================================================== >--- trunk/reactos/dll/win32/shell32/lang/da-DK.rc [iso-8859-1] >(original) >+++ trunk/reactos/dll/win32/shell32/lang/da-DK.rc [iso-8859-1] Sun Aug >9 07:56:47 2015 >@@ -667,7 +667,7 @@ > /* special folders */ > IDS_DESKTOP "Skrivebord" > IDS_MYCOMPUTER "Min Computer" >- IDS_RECYCLEBIN_FOLDER_NAME "Trash" >+ IDS_RECYCLEBIN_FOLDER_NAME "Recycle Bin" > IDS_CONTROLPANEL "Control Panel" > IDS_ADMINISTRATIVETOOLS "Administrative Tools" > >@@ -695,10 +695,10 @@ > IDS_DELETEITEM_TEXT "Er du sikker pÃ¥ du vil slette '%1'?" >IDS_DELETEMULTIPLE_TEXT "Are you sure you want to delete these %1 >items?" >IDS_DELETESELECTED_TEXT "Are you sure you want to delete the selected >item(s)?" >- IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the >Trash?" >- IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and >all its content to the Trash?" >- IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these >%1 items to the Trash?" >- IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Trash. Do you >want to delete it instead?" >+ IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the >Recycle Bin?" >+ IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and >all its content to the Recycle Bin?" >+ IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these >%1 items to the Recycle Bin?" >+ IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Recycle Bin. Do >you want to delete it instead?" > IDS_OVERWRITEFILE_TEXT "Overskriv fil %1?" > IDS_OVERWRITEFILE_CAPTION "BekrÃ¦ft overskrivelse af fil" >IDS_OVERWRITEFOLDER_TEXT "This folder already contains a folder named >'%1'.\n\nIf the files in the destination folder have the same names as >files in the\nselected folder they will be replaced. Do you still want >to move or copy\nthe folder?" > >Modified: trunk/reactos/dll/win32/shell32/lang/en-US.rc >URL: >http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/en-… >============================================================================== >--- trunk/reactos/dll/win32/shell32/lang/en-US.rc [iso-8859-1] >(original) >+++ trunk/reactos/dll/win32/shell32/lang/en-US.rc [iso-8859-1] Sun Aug >9 07:56:47 2015 >@@ -661,7 +661,7 @@ > /* special folders */ > IDS_DESKTOP "Desktop" > IDS_MYCOMPUTER "My Computer" >- IDS_RECYCLEBIN_FOLDER_NAME "Trash" >+ IDS_RECYCLEBIN_FOLDER_NAME "Recycle Bin" > IDS_CONTROLPANEL "Control Panel" > IDS_ADMINISTRATIVETOOLS "Administrative Tools" > >@@ -689,10 +689,10 @@ > IDS_DELETEITEM_TEXT "Are you sure you want to delete '%1'?" >IDS_DELETEMULTIPLE_TEXT "Are you sure you want to delete these %1 >items?" >IDS_DELETESELECTED_TEXT "Are you sure you want to delete the selected >item(s)?" >- IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the >Trash?" >- IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and >all its content to the Trash?" >- IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these >%1 items to the Trash?" >- IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Trash. Do you >want to delete it instead?" >+ IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the >Recycle Bin?" >+ IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and >all its content to the Recycle Bin?" >+ IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these >%1 items to the Recycle Bin?" >+ IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Recycle Bin. Do >you want to delete it instead?" >IDS_OVERWRITEFILE_TEXT "This folder already contains a file called >'%1'.\n\nDo you want to replace it?" > IDS_OVERWRITEFILE_CAPTION "Confirm file overwrite" >IDS_OVERWRITEFOLDER_TEXT "This folder already contains a folder named >'%1'.\n\nIf the files in the destination folder have the same names as >files in the\nselected folder they will be replaced. Do you still want >to move or copy\nthe folder?" > >Modified: trunk/reactos/dll/win32/shell32/lang/fi-FI.rc >URL: >http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/fi-… >============================================================================== >--- trunk/reactos/dll/win32/shell32/lang/fi-FI.rc [iso-8859-1] >(original) >+++ trunk/reactos/dll/win32/shell32/lang/fi-FI.rc [iso-8859-1] Sun Aug >9 07:56:47 2015 >@@ -661,7 +661,7 @@ > /* special folders */ > IDS_DESKTOP "TyÃ¶pÃ¶ytÃ¤" > IDS_MYCOMPUTER "Oma Tietokone" >- IDS_RECYCLEBIN_FOLDER_NAME "Trash" >+ IDS_RECYCLEBIN_FOLDER_NAME "Recycle Bin" > IDS_CONTROLPANEL "Control Panel" > IDS_ADMINISTRATIVETOOLS "Administrative Tools" > >@@ -689,10 +689,10 @@ > IDS_DELETEITEM_TEXT "Haluatko varmasti tuhota '%1':n?" > IDS_DELETEMULTIPLE_TEXT "Haluatko varmasti tuhota nÃ¤mÃ¤ %1?" >IDS_DELETESELECTED_TEXT "Are you sure you want to delete the selected >item(s)?" >- IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the >Trash?" >- IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and >all its content to the Trash?" >- IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these >%1 items to the Trash?" >- IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Trash. Do you >want to delete it instead?" >+ IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the >Recycle Bin?" >+ IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and >all its content to the Recycle Bin?" >+ IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these >%1 items to the Recycle Bin?" >+ IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Recycle Bin. Do >you want to delete it instead?" >IDS_OVERWRITEFILE_TEXT "This folder already contains a file called >'%1'.\n\nDo you want to replace it?" > IDS_OVERWRITEFILE_CAPTION "Vahvista Tiedoston Ylikirjoitus" >IDS_OVERWRITEFOLDER_TEXT "This folder already contains a folder named >'%1'.\n\nIf the files in the destination folder have the same names as >files in the\nselected folder they will be replaced. Do you still want >to move or copy\nthe folder?" > >Modified: trunk/reactos/dll/win32/shell32/lang/he-IL.rc >URL: >http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/he-… >============================================================================== >--- trunk/reactos/dll/win32/shell32/lang/he-IL.rc [iso-8859-1] >(original) >+++ trunk/reactos/dll/win32/shell32/lang/he-IL.rc [iso-8859-1] Sun Aug >9 07:56:47 2015 >@@ -689,10 +689,10 @@ > IDS_DELETEITEM_TEXT "Are you sure you want to delete '%1'?" >IDS_DELETEMULTIPLE_TEXT "Are you sure you want to delete these %1 >items?" >IDS_DELETESELECTED_TEXT "Are you sure you want to delete the selected >item(s)?" >- IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the >Trash?" >- IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and >all its content to the Trash?" >- IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these >%1 items to the Trash?" >- IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Trash. Do you >want to delete it instead?" >+ IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the >Recycle Bin?" >+ IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and >all its content to the Recycle Bin?" >+ IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these >%1 items to the Recycle Bin?" >+ IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Recycle Bin. Do >you want to delete it instead?" >IDS_OVERWRITEFILE_TEXT "This folder already contains a file called >'%1'.\n\nDo you want to replace it?" > IDS_OVERWRITEFILE_CAPTION "Confirm file overwrite" >IDS_OVERWRITEFOLDER_TEXT "This folder already contains a folder named >'%1'.\n\nIf the files in the destination folder have the same names as >files in the\nselected folder they will be replaced. Do you still want >to move or copy\nthe folder?" > >Modified: trunk/reactos/dll/win32/shell32/lang/hu-HU.rc >URL: >http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/hu-… >============================================================================== >--- trunk/reactos/dll/win32/shell32/lang/hu-HU.rc [iso-8859-1] >(original) >+++ trunk/reactos/dll/win32/shell32/lang/hu-HU.rc [iso-8859-1] Sun Aug >9 07:56:47 2015 >@@ -661,7 +661,7 @@ > /* special folders */ > IDS_DESKTOP "Asztal" > IDS_MYCOMPUTER "SzÃ¡mÃtÃ³gÃ©p" >- IDS_RECYCLEBIN_FOLDER_NAME "Trash" >+ IDS_RECYCLEBIN_FOLDER_NAME "Recycle Bin" > IDS_CONTROLPANEL "Control Panel" > IDS_ADMINISTRATIVETOOLS "Administrative Tools" > >@@ -689,10 +689,10 @@ > IDS_DELETEITEM_TEXT "Biztosan tÃ¶rÃ¶lni szeretnÃ©d?: '%1'?" >IDS_DELETEMULTIPLE_TEXT "Biztosan tÃ¶rÃ¶lni szeretnÃ©d ezt a(z) %1 >elemet?" >IDS_DELETESELECTED_TEXT "Are you sure you want to delete the selected >item(s)?" >- IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the >Trash?" >- IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and >all its content to the Trash?" >- IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these >%1 items to the Trash?" >- IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Trash. Do you >want to delete it instead?" >+ IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the >Recycle Bin?" >+ IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and >all its content to the Recycle Bin?" >+ IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these >%1 items to the Recycle Bin?" >+ IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Recycle Bin. Do >you want to delete it instead?" >IDS_OVERWRITEFILE_TEXT "This folder already contains a file called >'%1'.\n\nDo you want to replace it?" > IDS_OVERWRITEFILE_CAPTION "ÃllomÃ¡ny felÃ¼lÃrÃ¡sa" >IDS_OVERWRITEFOLDER_TEXT "This folder already contains a folder named >'%1'.\n\nIf the files in the destination folder have the same names as >files in the\nselected folder they will be replaced. Do you still want >to move or copy\nthe folder?" > >Modified: trunk/reactos/dll/win32/shell32/lang/ko-KR.rc >URL: >http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/ko-… >============================================================================== >--- trunk/reactos/dll/win32/shell32/lang/ko-KR.rc [iso-8859-1] >(original) >+++ trunk/reactos/dll/win32/shell32/lang/ko-KR.rc [iso-8859-1] Sun Aug >9 07:56:47 2015 >@@ -661,7 +661,7 @@ > /* special folders */ > IDS_DESKTOP "Desktop" > IDS_MYCOMPUTER "My Computer" >- IDS_RECYCLEBIN_FOLDER_NAME "Trash" >+ IDS_RECYCLEBIN_FOLDER_NAME "Recycle Bin" > IDS_CONTROLPANEL "Control Panel" > IDS_ADMINISTRATIVETOOLS "Administrative Tools" > >@@ -689,10 +689,10 @@ > IDS_DELETEITEM_TEXT "Are you sure you want to delete '%1'?" >IDS_DELETEMULTIPLE_TEXT "Are you sure you want to delete these %1 >items?" >IDS_DELETESELECTED_TEXT "Are you sure you want to delete the selected >item(s)?" >- IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the >Trash?" >- IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and >all its content to the Trash?" >- IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these >%1 items to the Trash?" >- IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Trash. Do you >want to delete it instead?" >+ IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the >Recycle Bin?" >+ IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and >all its content to the Recycle Bin?" >+ IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these >%1 items to the Recycle Bin?" >+ IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Recycle Bin. Do >you want to delete it instead?" >IDS_OVERWRITEFILE_TEXT "This folder already contains a file called >'%1'.\n\nDo you want to replace it?" > IDS_OVERWRITEFILE_CAPTION "Confirm file overwrite" >IDS_OVERWRITEFOLDER_TEXT "This folder already contains a folder named >'%1'.\n\nIf the files in the destination folder have the same names as >files in the\nselected folder they will be replaced. Do you still want >to move or copy\nthe folder?" > >Modified: trunk/reactos/dll/win32/shell32/lang/nl-NL.rc >URL: >http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/nl-… >============================================================================== >--- trunk/reactos/dll/win32/shell32/lang/nl-NL.rc [iso-8859-1] >(original) >+++ trunk/reactos/dll/win32/shell32/lang/nl-NL.rc [iso-8859-1] Sun Aug >9 07:56:47 2015 >@@ -661,7 +661,7 @@ > /* special folders */ > IDS_DESKTOP "Desktop" > IDS_MYCOMPUTER "My Computer" >- IDS_RECYCLEBIN_FOLDER_NAME "Trash" >+ IDS_RECYCLEBIN_FOLDER_NAME "Recycle Bin" > IDS_CONTROLPANEL "Control Panel" > IDS_ADMINISTRATIVETOOLS "Administrative Tools" > >@@ -689,10 +689,10 @@ > IDS_DELETEITEM_TEXT "Are you sure you want to delete '%1'?" >IDS_DELETEMULTIPLE_TEXT "Are you sure you want to delete these %1 >items?" >IDS_DELETESELECTED_TEXT "Are you sure you want to delete the selected >item(s)?" >- IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the >Trash?" >- IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and >all its content to the Trash?" >- IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these >%1 items to the Trash?" >- IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Trash. Do you >want to delete it instead?" >+ IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the >Recycle Bin?" >+ IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and >all its content to the Recycle Bin?" >+ IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these >%1 items to the Recycle Bin?" >+ IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Recycle Bin. Do >you want to delete it instead?" >IDS_OVERWRITEFILE_TEXT "This folder already contains a file called >'%1'.\n\nDo you want to replace it?" > IDS_OVERWRITEFILE_CAPTION "Confirm file overwrite" >IDS_OVERWRITEFOLDER_TEXT "This folder already contains a folder named >'%1'.\n\nIf the files in the destination folder have the same names as >files in the\nselected folder they will be replaced. Do you still want >to move or copy\nthe folder?" > >Modified: trunk/reactos/dll/win32/shell32/lang/pt-BR.rc >URL: >http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/pt-… >============================================================================== >--- trunk/reactos/dll/win32/shell32/lang/pt-BR.rc [iso-8859-1] >(original) >+++ trunk/reactos/dll/win32/shell32/lang/pt-BR.rc [iso-8859-1] Sun Aug >9 07:56:47 2015 >@@ -689,10 +689,10 @@ > IDS_DELETEITEM_TEXT "VocÃª tem certeza que deseja excluir '%1'?" >IDS_DELETEMULTIPLE_TEXT "VocÃª tem certeza que deseja excluir estes %1 >arquivos?" >IDS_DELETESELECTED_TEXT "VocÃª tem certeza que deseja excluir o(s) >arquivo(s) selecionado(s)?" >- IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the >Trash?" >- IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and >all its content to the Trash?" >- IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these >%1 items to the Trash?" >- IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Trash. Do you >want to delete it instead?" >+ IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the >Recycle Bin?" >+ IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and >all its content to the Recycle Bin?" >+ IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these >%1 items to the Recycle Bin?" >+ IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Recycle Bin. Do >you want to delete it instead?" >IDS_OVERWRITEFILE_TEXT "This folder already contains a file called >'%1'.\n\nDo you want to replace it?" > IDS_OVERWRITEFILE_CAPTION "Confirmar sobreescrever arquivo" >IDS_OVERWRITEFOLDER_TEXT "This folder already contains a folder named >'%1'.\n\nIf the files in the destination folder have the same names as >files in the\nselected folder they will be replaced. Do you still want >to move or copy\nthe folder?" > >Modified: trunk/reactos/dll/win32/shell32/lang/sl-SI.rc >URL: >http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/sl-… >============================================================================== >--- trunk/reactos/dll/win32/shell32/lang/sl-SI.rc [iso-8859-1] >(original) >+++ trunk/reactos/dll/win32/shell32/lang/sl-SI.rc [iso-8859-1] Sun Aug >9 07:56:47 2015 >@@ -661,7 +661,7 @@ > /* special folders */ > IDS_DESKTOP "Desktop" > IDS_MYCOMPUTER "My Computer" >- IDS_RECYCLEBIN_FOLDER_NAME "Trash" >+ IDS_RECYCLEBIN_FOLDER_NAME "Recycle Bin" > IDS_CONTROLPANEL "Control Panel" > IDS_ADMINISTRATIVETOOLS "Administrative Tools" > >@@ -689,10 +689,10 @@ > IDS_DELETEITEM_TEXT "Are you sure you want to delete '%1'?" >IDS_DELETEMULTIPLE_TEXT "Are you sure you want to delete these %1 >items?" >IDS_DELETESELECTED_TEXT "Are you sure you want to delete the selected >item(s)?" >- IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the >Trash?" >- IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and >all its content to the Trash?" >- IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these >%1 items to the Trash?" >- IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Trash. Do you >want to delete it instead?" >+ IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the >Recycle Bin?" >+ IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and >all its content to the Recycle Bin?" >+ IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these >%1 items to the Recycle Bin?" >+ IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Recycle Bin. Do >you want to delete it instead?" >IDS_OVERWRITEFILE_TEXT "This folder already contains a file called >'%1'.\n\nDo you want to replace it?" > IDS_OVERWRITEFILE_CAPTION "Confirm file overwrite" >IDS_OVERWRITEFOLDER_TEXT "This folder already contains a folder named >'%1'.\n\nIf the files in the destination folder have the same names as >files in the\nselected folder they will be replaced. Do you still want >to move or copy\nthe folder?" > >Modified: trunk/reactos/dll/win32/shell32/lang/sv-SE.rc >URL: >http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/sv-… >============================================================================== >--- trunk/reactos/dll/win32/shell32/lang/sv-SE.rc [iso-8859-1] >(original) >+++ trunk/reactos/dll/win32/shell32/lang/sv-SE.rc [iso-8859-1] Sun Aug >9 07:56:47 2015 >@@ -661,7 +661,7 @@ > /* special folders */ > IDS_DESKTOP "Desktop" > IDS_MYCOMPUTER "My Computer" >- IDS_RECYCLEBIN_FOLDER_NAME "Trash" >+ IDS_RECYCLEBIN_FOLDER_NAME "Recycle Bin" > IDS_CONTROLPANEL "Control Panel" > IDS_ADMINISTRATIVETOOLS "Administrative Tools" > >@@ -689,10 +689,10 @@ > IDS_DELETEITEM_TEXT "Are you sure you want to delete '%1'?" >IDS_DELETEMULTIPLE_TEXT "Are you sure you want to delete these %1 >items?" >IDS_DELETESELECTED_TEXT "Are you sure you want to delete the selected >item(s)?" >- IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the >Trash?" >- IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and >all its content to the Trash?" >- IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these >%1 items to the Trash?" >- IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Trash. Do you >want to delete it instead?" >+ IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the >Recycle Bin?" >+ IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and >all its content to the Recycle Bin?" >+ IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these >%1 items to the Recycle Bin?" >+ IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Recycle Bin. Do >you want to delete it instead?" >IDS_OVERWRITEFILE_TEXT "This folder already contains a file called >'%1'.\n\nDo you want to replace it?" > IDS_OVERWRITEFILE_CAPTION "Confirm file overwrite" >IDS_OVERWRITEFOLDER_TEXT "This folder already contains a folder named >'%1'.\n\nIf the files in the destination folder have the same names as >files in the\nselected folder they will be replaced. Do you still want >to move or copy\nthe folder?" > >Modified: trunk/reactos/dll/win32/shell32/lang/zh-TW.rc >URL: >http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/zh-… >============================================================================== >--- trunk/reactos/dll/win32/shell32/lang/zh-TW.rc [iso-8859-1] >(original) >+++ trunk/reactos/dll/win32/shell32/lang/zh-TW.rc [iso-8859-1] Sun Aug >9 07:56:47 2015 >@@ -697,10 +697,10 @@ > IDS_DELETEITEM_TEXT "Are you sure you want to delete '%1'?" >IDS_DELETEMULTIPLE_TEXT "Are you sure you want to delete these %1 >items?" >IDS_DELETESELECTED_TEXT "Are you sure you want to delete the selected >item(s)?" >- IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the >Trash?" >- IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and >all its content to the Trash?" >- IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these >%1 items to the Trash?" >- IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Trash. Do you >want to delete it instead?" >+ IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the >Recycle Bin?" >+ IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and >all its content to the Recycle Bin?" >+ IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these >%1 items to the Recycle Bin?" >+ IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Recycle Bin. Do >you want to delete it instead?" >IDS_OVERWRITEFILE_TEXT "This folder already contains a file called >'%1'.\n\nDo you want to replace it?" > IDS_OVERWRITEFILE_CAPTION "Confirm file overwrite" >IDS_OVERWRITEFOLDER_TEXT "This folder already contains a folder named >'%1'.\n\nIf the files in the destination folder have the same names as >files in the\nselected folder they will be replaced. Do you still want >to move or copy\nthe folder?" -- Sent from my Android phone with K-9 Mail. Please excuse my brevity.

9 years, 5 months

Re: [ros-dev] [ros-diffs] [aandrejevic] 68607: [FASTFAT] Irp->UserBuffer being NULL doesn't indicate any error. It could be that the caller really wants the result stored at address NULL (which can be valid, and is valid by...

by Pierre Schweitzer

This patch, as it, is really dangerous. MS allows null pointer in its Read/Write routines, but they are wrapped inside a SEH block, to prevent nasty things to happen in case of a null pointer dereference. Here we don't, meaning that a null pointer here will cause major damages. Furthermore, your commit regressed ntdll:file: https://reactos.org/sites/all/modules/reactos/testman/compare.php?ids=40042… Regards, On 08/07/2015 05:30 AM, aandrejevic(a)svn.reactos.org wrote: > Author: aandrejevic > Date: Fri Aug 7 03:30:05 2015 > New Revision: 68607 > > URL: http://svn.reactos.org/svn/reactos?rev=68607&view=rev > Log: > [FASTFAT] > Irp->UserBuffer being NULL doesn't indicate any error. It could be that the > caller really wants the result stored at address NULL (which can be valid, > and is valid by default for programs like NTVDM). > > > Modified: > trunk/reactos/drivers/filesystems/fastfat/rw.c > > Modified: trunk/reactos/drivers/filesystems/fastfat/rw.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… > ============================================================================== > --- trunk/reactos/drivers/filesystems/fastfat/rw.c [iso-8859-1] (original) > +++ trunk/reactos/drivers/filesystems/fastfat/rw.c [iso-8859-1] Fri Aug 7 03:30:05 2015 > @@ -656,7 +656,7 @@ > } > > Buffer = VfatGetUserBuffer(IrpContext->Irp, BooleanFlagOn(IrpContext->Irp->Flags, IRP_PAGING_IO)); > - if (!Buffer) > + if (!Buffer && IrpContext->Irp->MdlAddress) > { > Status = STATUS_INVALID_USER_BUFFER; > goto ByeBye; > @@ -927,7 +927,7 @@ > OldFileSize = Fcb->RFCB.FileSize; > > Buffer = VfatGetUserBuffer(IrpContext->Irp, BooleanFlagOn(IrpContext->Irp->Flags, IRP_PAGING_IO)); > - if (!Buffer) > + if (!Buffer && IrpContext->Irp->MdlAddress) > { > Status = STATUS_INVALID_USER_BUFFER; > goto ByeBye; > > -- Pierre Schweitzer <pierre(a)reactos.org> System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V.

9 years, 5 months

VcXsrv Windows X Server

by Javier Agustìn Fernàndez Arroyo

Hello, i dont know if this list is the correct place to post this, I found this software some weeks ago, and i thought it would be interesting to have it running in ReactOS. But, according its website, support for Windows XP has been stopped. So question is, what about asking author to reenable XP support via ReactOS? :) http://sourceforge.net/projects/vcxsrv/

9 years, 5 months

WDM sound drivers question

by Mgr. Janusz Chmiel

Dear core developers, Is it possible to use Windows XP based WDM sound drivers with Reactos 0.4-CLT2015? Is it possible to make something so specific WDM sound driver can be incorporated to Live CD so it would work out of The box? If there is issues with using various sound drivers, how complex would bew for You to add support for general USB audio device. Last plea. Which dlls would had to be redesigned so NVDA screen reader would be used? Oleacc.dll and other mSAA based libraries? Thank You very much for Yours answers. With kindness regards. Janusz Chmiel

9 years, 5 months

Unify system icons into one central folder

by Jared Smudde

Hello. I am Jared Smudde aka. Pi_User5. I propose that we move most of the icons in trunk into a central folder in the media folder. Some icons will need to stay because they might be application specific. The folder can be called icons and it would be organized according to http://standards.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.h…. This way, we can eliminate duplicate icons thus making trunk slightly smaller. It will also make changing ReactOS to a different icon theme much easier. This idea was suggested by gigaherz and I would like to see it done. Thanks! Jared

9 years, 5 months

Working on partitions

by stack exchange

Hi On my issue CORE-9641 <https://jira.reactos.org/browse/CORE-9641> Victor Martinez made a comment saying that Eric Kohl is currently working on partitions. If that is the case, what kind of changes are being worked on? Since I created another issue related to that (CORE-9661 <https://jira.reactos.org/browse/CORE-9661>), if this is already worked on, I don't want to look into it either, otherwise this would be what I would fix next. mfg, Gerhard Gruber

9 years, 6 months

Re: [ros-dev] [ros-diffs] [cfinck] 68253: [SPOOLSS] Halfplement and document the undocumented but exported MarshallDownStructure API. Information about this API was exclusively gained by writing a custom XML file for rohita...

by Alex Ionescu

On Wed, Jun 24, 2015 at 9:26 AM, <cfinck(a)svn.reactos.org> wrote: > cbSize Well, you may at least want to validate that your dwOffsets are within cbSize? Best regards, Alex Ionescu

9 years, 6 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev