Ros-dev

ros-dev@reactos.org

5789 discussions

Re: [ros-dev] [ros-diffs] [gadamopoulos] 66988: [EXPLORER] - Fix showing the website when Help is selected from the start menu.

by Pierre Schweitzer

Just a side (minor) remark. On 31/03/2015 00:28, gadamopoulos(a)svn.reactos.org wrote: > Modified: trunk/reactos/base/shell/explorer/explorer.rc > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/explorer/explor… > ============================================================================== > --- trunk/reactos/base/shell/explorer/explorer.rc [iso-8859-1] (original) > +++ trunk/reactos/base/shell/explorer/explorer.rc [iso-8859-1] Mon Mar 30 22:28:08 2015 > @@ -28,7 +28,7 @@ > STRINGTABLE > BEGIN > //IDS_HELP_COMMAND "helpctr.exe>-FromStartHelp" > - IDS_HELP_COMMAND "https://www.reactos.org/" > + IDS_HELP_COMMAND "http://www.reactos.org/" This is to be reverted once ReactOS fully supports SSL. -- Pierre Schweitzer <pierre at reactos.org> System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V.

10 years, 3 months

Re: [ros-dev] [ros-diffs] [gadamopoulos] 66992: [BROWSEUI] - CProgressDialog: Allocate big enough buffers needed for the text messages during initialization and don't reallocate them at all. Should stop thrashing the heap w...

by Thomas Faber

On 2015-03-31 00:50, gadamopoulos(a)svn.reactos.org wrote: > --- trunk/reactos/dll/win32/browseui/CProgressDialog.cpp [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/browseui/CProgressDialog.cpp [iso-8859-1] Mon Mar 30 22:50:34 2015 > CProgressDialog::CProgressDialog() > { > + this->cancelMsg[0] = this->title[0]; Did you mean this->cancelMsg[0] = this->title[0] = 0;? (or UNICODE_NULL for that matter) > static void set_buffer(LPWSTR *buffer, LPCWSTR string) > { > + > + ULONG len = max((wcslen(string) + 1)*sizeof(WCHAR), BUFFER_SIZE); > StringCchCopyW(*buffer, len, string); This makes no sense. I think you simply want StringCchCopyW(*buffer, len, BUFFER_SIZE); Thanks! -Thomas

10 years, 3 months

Re: [ros-dev] [ros-diffs] [hbelusca] 66946: [CMAKE] Improve the concatenate_files macro introduced by Timo in r52179 + r52182 and hackfixed in r53914 . Notice that now it can take an arbitrary number of files to be concaten...

by Thomas Faber

I don't see how creating a new host-tool is an improvement over using OS builtins? On 2015-03-29 03:53, hbelusca(a)svn.reactos.org wrote: > Author: hbelusca > Date: Sun Mar 29 01:53:10 2015 > New Revision: 66946 > > URL: http://svn.reactos.org/svn/reactos?rev=66946&view=rev > Log: > [CMAKE] > Improve the concatenate_files macro introduced by Timo in r52179 + r52182 and hackfixed in r53914 . Notice that now it can take an arbitrary number of files to be concatenated. Hence you need to specify first the output file, and all the rest is the different files. > > [FREELDR] > Use the improved concatenate_files macro. > > Modified: > trunk/reactos/boot/freeldr/freeldr/CMakeLists.txt > trunk/reactos/cmake/CMakeMacros.cmake > > Modified: trunk/reactos/boot/freeldr/freeldr/CMakeLists.txt > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/CMake… > ============================================================================== > --- trunk/reactos/boot/freeldr/freeldr/CMakeLists.txt [iso-8859-1] (original) > +++ trunk/reactos/boot/freeldr/freeldr/CMakeLists.txt [iso-8859-1] Sun Mar 29 01:53:10 2015 > @@ -226,10 +226,13 @@ > add_dependencies(freeldr_pe asm) > add_dependencies(freeldr_pe_dbg asm) > > +# Retrieve the full path to the generated file of the 'freeldr_pe' target > +get_target_property(_freeldr_pe_output_file freeldr_pe LOCATION) > + > concatenate_files( > + ${CMAKE_CURRENT_BINARY_DIR}/freeldr.sys > ${CMAKE_CURRENT_BINARY_DIR}/frldr16.bin > - freeldr_pe > - ${CMAKE_CURRENT_BINARY_DIR}/freeldr.sys) > + ${_freeldr_pe_output_file}) > > add_custom_target(freeldr ALL DEPENDS ${CMAKE_CURRENT_BINARY_DIR}/freeldr.sys) > > @@ -238,9 +241,9 @@ > add_cd_file(TARGET freeldr FILE ${CMAKE_CURRENT_BINARY_DIR}/freeldr.sys DESTINATION loader NO_CAB NOT_IN_HYBRIDCD FOR livecd hybridcd NAME_ON_CD setupldr.sys) > > concatenate_files( > + ${CMAKE_CURRENT_BINARY_DIR}/setupldr.sys > ${CMAKE_CURRENT_BINARY_DIR}/frldr16.bin > - freeldr_pe > - ${CMAKE_CURRENT_BINARY_DIR}/setupldr.sys) > + ${_freeldr_pe_output_file}) > > add_custom_target(setupldr ALL DEPENDS ${CMAKE_CURRENT_BINARY_DIR}/setupldr.sys) > add_cd_file(TARGET setupldr FILE ${CMAKE_CURRENT_BINARY_DIR}/setupldr.sys DESTINATION loader NO_CAB FOR bootcd regtest) > > Modified: trunk/reactos/cmake/CMakeMacros.cmake > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/cmake/CMakeMacros.cmake?re… > ============================================================================== > --- trunk/reactos/cmake/CMakeMacros.cmake [iso-8859-1] (original) > +++ trunk/reactos/cmake/CMakeMacros.cmake [iso-8859-1] Sun Mar 29 01:53:10 2015 > @@ -504,33 +504,12 @@ > endfunction() > endif() > > -if(CMAKE_HOST_SYSTEM_NAME STREQUAL "Windows") > - macro(to_win_path _cmake_path _native_path) > - string(REPLACE "/" "\\" ${_native_path} "${_cmake_path}") > - endmacro() > - > - # yeah the parameter mess sucks, but thats what works... > - function(concatenate_files _file1 _target2 _output) > - get_target_property(_file2 ${_target2} LOCATION) > - to_win_path("${_file1}" _real_file1) > - to_win_path("${_file2}" _real_file2) > - to_win_path("${_output}" _real_output) > - add_custom_command( > - OUTPUT ${_output} > - COMMAND cmd.exe /C "copy /Y /B ${_real_file1} + ${_real_file2} ${_real_output} > nul" > - DEPENDS ${_file1} > - DEPENDS ${_target2}) > - endfunction() > -else() > - macro(concatenate_files _file1 _target2 _output) > - get_target_property(_file2 ${_target2} LOCATION) > - add_custom_command( > - OUTPUT ${_output} > - COMMAND cat ${_file1} ${_file2} > ${_output} > - DEPENDS ${_file1} > - DEPENDS ${_target2}) > - endmacro() > -endif() > +macro(concatenate_files _output) > + add_custom_command( > + OUTPUT ${_output} > + COMMAND native-cat ${ARGN} > ${_output} > + DEPENDS ${ARGN} native-cat) > +endmacro() > > function(add_importlibs _module) > add_dependency_node(${_module}) > >

10 years, 3 months

Re: [ros-dev] [ros-diffs] [hbelusca] 66903: [NTVDM] - Fix some english. - Validity checks for DosGetSftEntry returned pointer added. - Use unsigned indices for for-loops indices that are always positive.

by Pierre Schweitzer

On 03/26/2015 03:52 PM, hbelusca(a)svn.reactos.org wrote: > Modified: trunk/reactos/subsystems/mvdm/ntvdm/dos/dos32krnl/bios.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/mvdm/ntvdm/dos/… > ============================================================================== > --- trunk/reactos/subsystems/mvdm/ntvdm/dos/dos32krnl/bios.c [iso-8859-1] (original) > +++ trunk/reactos/subsystems/mvdm/ntvdm/dos/dos32krnl/bios.c [iso-8859-1] Thu Mar 26 14:52:16 2015 > @@ -56,6 +56,13 @@ > BOOLEAN DosCheckInput(VOID) > { > PDOS_SFT_ENTRY SftEntry = DosGetSftEntry(DOS_INPUT_HANDLE); > + > + if (SftEntry == NULL) > + { > + /* Invalid handle */ > + DosLastError = ERROR_INVALID_HANDLE; // ERROR_FILE_NOT_FOUND Hum... Why? Is the error code wrong and should be ERROR_FILE_NOT_FOUND? And then, why setting this other error code? Or is the error code right, and then, what's the purpose of such comment? Or do you have a doubt about the right error code to use? Be it one or the other? I come back to my eternal comment: don't comment for yourself. Comment for the others, you're not alone here. So, make it explicit. Cheers, -- Pierre Schweitzer <pierre(a)reactos.org> System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V.

10 years, 3 months

Win2k3 end of life

by Huw Campbell

Hey, Win2k3 is end of support in 6 months, which will mean that the symbol server will go down (as it has done for XP). At the very least, we should scrape the symbol server so we can continue to check and debug. Or move to NT6...

10 years, 3 months

Status Meeting (March 2015)

by Aleksey Bragin

Hello, Let me invite you to the monthly status meeting taking place today 26th of March, 19:00 UTC, as always. IRC service will only be started shortly before the meeting. Your participation passwords and server address will be emailed to you shortly before the meeting starts, and they are going to be different once again as they are not stored in any database. Hopefully it's not much of inconvenience. If someone still is not getting passwords sent before a meeting - please email Pierre before the meeting started to get one. Please send agenda proposals to me before the meeting, so that we can start with a proposed agenda. And join Mumble! Regards, Aleksey Bragin

10 years, 3 months

Re: [ros-dev] [ros-diffs] [tkreuzer] 66893: [WIN32K] Rewrite brush code in C++

by Ged Murphy

Timo and C++?? Hell must be a bit chilly today :) -----Original Message----- From: Ros-diffs [mailto:ros-diffs-bounces@reactos.org] On Behalf Of tkreuzer(a)svn.reactos.org Sent: 25 March 2015 22:38 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [tkreuzer] 66893: [WIN32K] Rewrite brush code in C++ Author: tkreuzer Date: Wed Mar 25 22:38:20 2015 New Revision: 66893 URL: http://svn.reactos.org/svn/reactos?rev=66893&view=rev Log: [WIN32K] Rewrite brush code in C++

10 years, 3 months

msi:msi Wine Test hanging under Windows Server 2003

by Colin Finck

Hi all, With my latest log flush change to rosautotest, you see that it's msi:msi which is hanging in our Windows Server 2003 WHS-Testbot. See https://build.reactos.org/builders/WHS-Testbot/builds/30/steps/test/logs/st… The actual hang looks like this: http://fs2.directupload.net/images/150322/tsr72fu5.png This is the only bug that prevents us from running the full Wine Test Suite under Windows Server 2003. Fixes are welcome :) Cheers, Colin

10 years, 3 months

Jira & Fisheye downtime

by Pierre Schweitzer

Dear all, Due to DB maintenance, Jira & Fisheye will be down in a few minutes. There's no ETA for up status. Sorry for the caused inconvenience, -- Pierre Schweitzer <pierre(a)reactos.org> System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V.

10 years, 3 months

Re: [ros-dev] Ros-dev Digest, Vol 127, Issue 29

by Fedor Zaitsev

Thank you, with revision 66721 everything is ok with building ReactOS > Hi Fedor, > >> Hi. I am trying to compile ReactOS on my macbook with OSX 10.10 on it, but I got an error. Building tools compiled quite well (with some warmings, but I think that it is ok), but when I call "ninja all? I got error: > Can you please try with r66700 and report back? > > Cheers, > Amine.

10 years, 3 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev