On 03/26/2015 03:52 PM, hbelusca(a)svn.reactos.org wrote:
> Modified: trunk/reactos/subsystems/mvdm/ntvdm/dos/dos32krnl/bios.c
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/mvdm/ntvdm/dos/…
> ==============================================================================
> --- trunk/reactos/subsystems/mvdm/ntvdm/dos/dos32krnl/bios.c [iso-8859-1] (original)
> +++ trunk/reactos/subsystems/mvdm/ntvdm/dos/dos32krnl/bios.c [iso-8859-1] Thu Mar 26 14:52:16 2015
> @@ -56,6 +56,13 @@
> BOOLEAN DosCheckInput(VOID)
> {
> PDOS_SFT_ENTRY SftEntry = DosGetSftEntry(DOS_INPUT_HANDLE);
> +
> + if (SftEntry == NULL)
> + {
> + /* Invalid handle */
> + DosLastError = ERROR_INVALID_HANDLE; // ERROR_FILE_NOT_FOUND
Hum... Why?
Is the error code wrong and should be ERROR_FILE_NOT_FOUND? And then,
why setting this other error code?
Or is the error code right, and then, what's the purpose of such comment?
Or do you have a doubt about the right error code to use? Be it one or
the other?
I come back to my eternal comment: don't comment for yourself. Comment
for the others, you're not alone here. So, make it explicit.
Cheers,
--
Pierre Schweitzer <pierre(a)reactos.org>
System & Network Administrator
Senior Kernel Developer
ReactOS Deutschland e.V.
Hey,
Win2k3 is end of support in 6 months, which will mean that the symbol
server will go down (as it has done for XP).
At the very least, we should scrape the symbol server so we can
continue to check and debug.
Or move to NT6...
Hello,
Let me invite you to the monthly status meeting taking place today 26th
of March, 19:00 UTC, as always.
IRC service will only be started shortly before the meeting. Your
participation passwords and server address will be emailed to you
shortly before the meeting starts, and they are going to be different
once again as they are not stored in any database. Hopefully it's not
much of inconvenience.
If someone still is not getting passwords sent before a meeting - please
email Pierre before the meeting started to get one.
Please send agenda proposals to me before the meeting, so that we can
start with a proposed agenda.
And join Mumble!
Regards,
Aleksey Bragin
Timo and C++??
Hell must be a bit chilly today :)
-----Original Message-----
From: Ros-diffs [mailto:ros-diffs-bounces@reactos.org] On Behalf Of tkreuzer(a)svn.reactos.org
Sent: 25 March 2015 22:38
To: ros-diffs(a)reactos.org
Subject: [ros-diffs] [tkreuzer] 66893: [WIN32K] Rewrite brush code in C++
Author: tkreuzer
Date: Wed Mar 25 22:38:20 2015
New Revision: 66893
URL: http://svn.reactos.org/svn/reactos?rev=66893&view=rev
Log:
[WIN32K]
Rewrite brush code in C++
Dear all,
Due to DB maintenance, Jira & Fisheye will be down in a few minutes.
There's no ETA for up status.
Sorry for the caused inconvenience,
--
Pierre Schweitzer <pierre(a)reactos.org>
System & Network Administrator
Senior Kernel Developer
ReactOS Deutschland e.V.
Thank you, with revision 66721 everything is ok with building ReactOS
> Hi Fedor,
>
>> Hi. I am trying to compile ReactOS on my macbook with OSX 10.10 on it, but I got an error. Building tools compiled quite well (with some warmings, but I think that it is ok), but when I call "ninja all? I got error:
> Can you please try with r66700 and report back?
>
> Cheers,
> Amine.
dreimer(a)svn.reactos.org wrote:
> [RAPPS] lack of a proxy configuration by Peter Hater.
I don't think we need a separate proxy configuration per application.
We should rather keep things consistent and always use the system
proxy set in the "Internet Options" control panel applet.
Unless someone has any objections, I suggest reverting this.
- Colin
