Ros-dev

ros-dev@reactos.org

5790 discussions

Re: [ros-dev] [ros-diffs] [tkreuzer] 64078: [PSEH] - On clang builds we need to do the return twice trick, since we don't have asm goto, which would allow us to specify labels in the code where we can branch to on an except...

by Thomas Faber

On 2014-09-07 23:40, tkreuzer(a)svn.reactos.org wrote: > --- trunk/reactos/lib/pseh/i386/pseh3_i386.S [iso-8859-1] (original) > +++ trunk/reactos/lib/pseh/i386/pseh3_i386.S [iso-8859-1] Sun Sep 7 21:40:07 2014 > @@ -30,6 +30,10 @@ > mov [eax + SEH3_REGISTRATION_FRAME_Esi], esi > mov [eax + SEH3_REGISTRATION_FRAME_Edi], edi > > + /* Safe the return address */ > + mov ebx, [esp] > + mov [eax + SEH3_REGISTRATION_FRAME_ReturnAddress], ebx > + > .global __SEH3$_RegisterFrameWithStackLayout > __SEH3$_RegisterFrameWithStackLayout: > I think we need to restore ebx before returning? I don't see us telling the compiler that it was clobbered anywhere.

11 years, 1 month

Re: [ros-dev] [ros-diffs] [akhaldi] 64113: [GLU32] * Link with mingwex. * Allow multiple definitions at link time because longjmp exists in both our msvcrt and mingwex. CORE-8516

by Timo Kreuzer

Are you sure that we will link to the correct one? I doubt that the one from mingwex is compatible. Am 11.09.2014 12:13, schrieb akhaldi(a)svn.reactos.org: > Author: akhaldi > Date: Thu Sep 11 10:13:05 2014 > New Revision: 64113 > > URL: http://svn.reactos.org/svn/reactos?rev=64113&view=rev > Log: > [GLU32] > * Link with mingwex. > * Allow multiple definitions at link time because longjmp exists in both our msvcrt and mingwex. > CORE-8516 > > Modified: > trunk/reactos/dll/opengl/glu32/CMakeLists.txt > > Modified: trunk/reactos/dll/opengl/glu32/CMakeLists.txt > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/opengl/glu32/CMakeList… > ============================================================================== > --- trunk/reactos/dll/opengl/glu32/CMakeLists.txt [iso-8859-1] (original) > +++ trunk/reactos/dll/opengl/glu32/CMakeLists.txt [iso-8859-1] Thu Sep 11 10:13:05 2014 > @@ -114,6 +114,11 @@ > > if(NOT MSVC) > add_target_compile_flags(glu32 "-Wno-write-strings -Wno-unused-but-set-variable") > + if(CMAKE_C_COMPILER_ID STREQUAL "Clang") > + target_link_libraries(glu32 mingwex) > + #FIXME: longjmp exists in both our msvcrt and mingwex > + add_target_link_flags(glu32 "-Wl,--allow-multiple-definition") > + endif() > endif() > > add_importlibs(glu32 opengl32 gdi32 msvcrt kernel32 ntdll) > > >

11 years, 1 month

Re: [ros-dev] [ros-diffs] [akhaldi] 64094: [CMAKE/CLANG] * Globally link mingwex for C modules. CORE-8516

by Jérôme Gardou

Hey Amine Is there any reason to not use our own mingwex build ? Le 09/09/2014 20:11, akhaldi(a)svn.reactos.org a écrit : > Author: akhaldi > Date: Tue Sep 9 18:11:10 2014 > New Revision: 64094 > > URL: http://svn.reactos.org/svn/reactos?rev=64094&view=rev > Log: > [CMAKE/CLANG] > * Globally link mingwex for C modules. > CORE-8516 > > Modified: > trunk/reactos/toolchain-clang.cmake > > Modified: trunk/reactos/toolchain-clang.cmake > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/toolchain-clang.cmake?rev=… > ============================================================================== > --- trunk/reactos/toolchain-clang.cmake [iso-8859-1] (original) > +++ trunk/reactos/toolchain-clang.cmake [iso-8859-1] Tue Sep 9 18:11:10 2014 > @@ -56,7 +56,7 @@ > set(CMAKE_ASM_CREATE_STATIC_LIBRARY ${CMAKE_C_CREATE_STATIC_LIBRARY}) > > # Don't link with anything by default unless we say so > -set(CMAKE_C_STANDARD_LIBRARIES "-lgcc" CACHE STRING "Standard C Libraries") > +set(CMAKE_C_STANDARD_LIBRARIES "-lmingwex -lgcc" CACHE STRING "Standard C Libraries") > > #MARK_AS_ADVANCED(CLEAR CMAKE_CXX_STANDARD_LIBRARIES) > set(CMAKE_CXX_STANDARD_LIBRARIES "-lgcc" CACHE STRING "Standard C++ Libraries") > >

11 years, 1 month

by Thomas Faber

Making the member conditional but writing to it unconditionally seems like it would overflow the stack variable on GCC? On 2014-09-07 23:40, tkreuzer(a)svn.reactos.org wrote: > +#ifdef __clang__ > + void *ReturnAddress; > #endif > + /* Safe the return address */ > + mov ebx, [esp] > + mov [eax + SEH3_REGISTRATION_FRAME_ReturnAddress], ebx

11 years, 1 month

Re: [ros-dev] [ros-diffs] [jgardou] 64022: [SECUR32] - Update spec file [SCHANNEL] - Update stubs list Please blame binutils

by Timo Kreuzer

Am 01.09.2014 14:21, schrieb jgardou(a)svn.reactos.org: > Author: jgardou > Date: Mon Sep 1 12:21:16 2014 > New Revision: 64022 > > URL: http://svn.reactos.org/svn/reactos?rev=64022&view=rev > Log: > [SECUR32] > - Update spec file > [SCHANNEL] > - Update stubs list > Please blame binutils > > Modified: > trunk/reactos/dll/win32/schannel/schannel.spec > trunk/reactos/dll/win32/schannel/schannel_wine.c > trunk/reactos/dll/win32/schannel/stubs.c > trunk/reactos/dll/win32/secur32/secur32.spec > > Modified: trunk/reactos/dll/win32/schannel/schannel.spec > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/schannel/schanne… > ============================================================================== > --- trunk/reactos/dll/win32/schannel/schannel.spec [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/schannel/schannel.spec [iso-8859-1] Mon Sep 1 12:21:16 2014 > @@ -15,14 +15,14 @@ > @ stdcall InitSecurityInterfaceW() schan_InitSecurityInterfaceW > @ stdcall InitializeSecurityContextA(ptr ptr str long long long ptr long ptr ptr ptr ptr) schan_InitializeSecurityContextA > @ stdcall InitializeSecurityContextW(ptr ptr wstr long long long ptr long ptr ptr ptr ptr) schan_InitializeSecurityContextW > -@ stdcall MakeSignature(ptr long ptr long) secur32.MakeSignature > +@ stdcall MakeSignature(ptr long ptr long) schan_MakeSignature > @ stub OpenSslPerformanceData > @ stdcall QueryContextAttributesA(ptr long ptr) schan_QueryContextAttributesA > @ stdcall QueryContextAttributesW(ptr long ptr) schan_QueryContextAttributesW > -@ stdcall QuerySecurityPackageInfoA(str ptr) secur32.QuerySecurityPackageInfoA > -@ stdcall QuerySecurityPackageInfoW(wstr ptr) secur32.QuerySecurityPackageInfoW > -@ stdcall RevertSecurityContext(ptr) secur32.RevertSecurityContext > -@ stdcall SealMessage(ptr long ptr long) secur32.SealMessage > +@ stdcall QuerySecurityPackageInfoA(str ptr) schan_QuerySecurityPackageInfoA > +@ stdcall QuerySecurityPackageInfoW(wstr ptr) schan_QuerySecurityPackageInfoW > +@ stdcall RevertSecurityContext(ptr) schan_RevertSecurityContext > +@ stdcall SealMessage(ptr long ptr long) schan_EncryptMessage > @ stdcall SpLsaModeInitialize(long ptr ptr ptr) > @ stdcall SpUserModeInitialize(long ptr ptr ptr) > @ stub SslCrackCertificate > @@ -33,5 +33,5 @@ > @ stub SslGenerateRandomBits > @ stub SslGetMaximumKeySize > @ stub SslLoadCertificate > -@ stdcall UnsealMessage(ptr ptr long ptr) secur32.UnsealMessage > -@ stdcall VerifySignature(ptr ptr long ptr) secur32.VerifySignature > +@ stdcall UnsealMessage(ptr ptr long ptr) schan_DecryptMessage > +@ stdcall VerifySignature(ptr ptr long ptr) schan_VerifySignature This change is not correct. The following functions from schannel are forwarded to secur32: MakeSignature, QueryContextAttributesA/W, QuerySecurityPackageInfoA/W, RevertSecurityContext, SealMessage, UnsealMessage, VerifySignature Timo

11 years, 1 month

Re: [ros-dev] [ros-diffs] [hbelusca] 64017: [BOOTVID] - Synchronize correctly arm/bootdata.c with i386, as it was done previously. - Code formatting: whitespace fixes, add braces/brackets and spaces where needed; comments s...

by Timo Kreuzer

Am 01.09.2014 01:00, schrieb hbelusca(a)svn.reactos.org: > Author: hbelusca > Date: Sun Aug 31 23:00:29 2014 > New Revision: 64017 > > URL: http://svn.reactos.org/svn/reactos?rev=64017&view=rev > Log: > [BOOTVID] > - Synchronize correctly arm/bootdata.c with i386, as it was done previously. Why is that file duplicated at all, if the contents are identical?

11 years, 1 month

Re: [ros-dev] [ros-diffs] [tfaber] 63953: [FASTFAT] - Do not use direct I/O since it limits read/write operations to 64 MB CORE-8410 #resolve

by cameron.gutman＠reactos.org

This seems strange. I understand that NT 5.x has a limitation of 64 MB MDLs on x86, but direct I/O was designed for exactly this case of large I/O operations. Has anyone verified that 2k3 doesn’t do MDL chaining for direct I/O when the transfer is larger than a single MDL can hold? Also aren’t there changes to the IRP dispatch routines required to cope with not having an Irp->MdlAddress pointer anymore? Cameron From: tfaber(a)svn.reactos.org Sent: ‎Tuesday‎, ‎August‎ ‎26‎, ‎2014 ‎6‎:‎41‎ ‎AM To: ros-diffs(a)reactos.org Author: tfaber Date: Tue Aug 26 13:41:57 2014 New Revision: 63953 URL: http://svn.reactos.org/svn/reactos?rev=63953&view=rev Log: [FASTFAT] - Do not use direct I/O since it limits read/write operations to 64 MB CORE-8410 #resolve Modified: trunk/reactos/drivers/filesystems/fastfat/fsctl.c Modified: trunk/reactos/drivers/filesystems/fastfat/fsctl.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… ============================================================================== --- trunk/reactos/drivers/filesystems/fastfat/fsctl.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fastfat/fsctl.c [iso-8859-1] Tue Aug 26 13:41:57 2014 @@ -442,8 +442,7 @@ goto ByeBye; } - DeviceObject->Flags = DeviceObject->Flags | DO_DIRECT_IO; - DeviceExt = (PVOID) DeviceObject->DeviceExtension; + DeviceExt = DeviceObject->DeviceExtension; RtlZeroMemory(DeviceExt, ROUND_UP(sizeof(DEVICE_EXTENSION), sizeof(ULONG)) + sizeof(HASHENTRY*) * HashTableSize); DeviceExt->FcbHashTable = (HASHENTRY**)((ULONG_PTR)DeviceExt + ROUND_UP(sizeof(DEVICE_EXTENSION), sizeof(ULONG))); DeviceExt->HashTableSize = HashTableSize;

11 years, 1 month

mplay translation

by Javier Agustìn Fernàndez Arroyo

hello folks, i have just updated the spanish translatiuon of mplay. Its here: https://jira.reactos.org/browse/CORE-8470 Enjoy! :)

11 years, 1 month

Re: [ros-dev] [ros-diffs] [tfaber] 63928: [FASTFAT] - Properly handle errors in CcInitializeCacheMap, CcCopyRead and CcCopyWrite CORE-8410

by Jérôme Gardou

Hey Thomas I think that you want to use _SEH2_YIELD in a few places here, that is, unless we want to completely ditch pseh2 in favor of pseh3 ;-) Regards Jérôme Le 24/08/2014 05:28, tfaber(a)svn.reactos.org a écrit : > Author: tfaber > Date: Sun Aug 24 03:28:01 2014 > New Revision: 63928 > > URL: http://svn.reactos.org/svn/reactos?rev=63928&view=rev > Log: > [FASTFAT] > - Properly handle errors in CcInitializeCacheMap, CcCopyRead and CcCopyWrite > CORE-8410 > > Modified: > trunk/reactos/drivers/filesystems/fastfat/CMakeLists.txt > trunk/reactos/drivers/filesystems/fastfat/fcb.c > trunk/reactos/drivers/filesystems/fastfat/fsctl.c > trunk/reactos/drivers/filesystems/fastfat/rw.c > trunk/reactos/drivers/filesystems/fastfat/vfat.h > > Modified: trunk/reactos/drivers/filesystems/fastfat/CMakeLists.txt > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… > ============================================================================== > --- trunk/reactos/drivers/filesystems/fastfat/CMakeLists.txt [iso-8859-1] (original) > +++ trunk/reactos/drivers/filesystems/fastfat/CMakeLists.txt [iso-8859-1] Sun Aug 24 03:28:01 2014 > @@ -26,6 +26,7 @@ > add_library(fastfat SHARED ${SOURCE} vfatfs.rc) > > set_module_type(fastfat kernelmodedriver) > +target_link_libraries(fastfat ${PSEH_LIB}) > add_importlibs(fastfat ntoskrnl hal) > > add_pch(fastfat vfat.h SOURCE) > > Modified: trunk/reactos/drivers/filesystems/fastfat/fcb.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… > ============================================================================== > --- trunk/reactos/drivers/filesystems/fastfat/fcb.c [iso-8859-1] (original) > +++ trunk/reactos/drivers/filesystems/fastfat/fcb.c [iso-8859-1] Sun Aug 24 03:28:01 2014 > @@ -340,12 +340,14 @@ > { > PFILE_OBJECT fileObject; > PVFATCCB newCCB; > + NTSTATUS status; > > fileObject = IoCreateStreamFileObject (NULL, vcb->StorageDevice); > > newCCB = ExAllocateFromNPagedLookasideList(&VfatGlobalData->CcbLookasideList); > if (newCCB == NULL) > { > + ObDereferenceObject(fileObject); > return STATUS_INSUFFICIENT_RESOURCES; > } > RtlZeroMemory(newCCB, sizeof (VFATCCB)); > @@ -356,11 +358,24 @@ > fcb->FileObject = fileObject; > fcb->RefCount++; > > - CcInitializeCacheMap(fileObject, > - (PCC_FILE_SIZES)(&fcb->RFCB.AllocationSize), > - TRUE, > - &VfatGlobalData->CacheMgrCallbacks, > - fcb); > + _SEH2_TRY > + { > + CcInitializeCacheMap(fileObject, > + (PCC_FILE_SIZES)(&fcb->RFCB.AllocationSize), > + TRUE, > + &VfatGlobalData->CacheMgrCallbacks, > + fcb); > + } > + _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) > + { > + status = _SEH2_GetExceptionCode(); > + fcb->RefCount--; > + fcb->FileObject = NULL; > + ExFreeToNPagedLookasideList(&VfatGlobalData->CcbLookasideList, newCCB); > + ObDereferenceObject(fileObject); > + return status; > + } > + _SEH2_END; > > fcb->Flags |= FCB_CACHE_INITIALIZED; > return STATUS_SUCCESS; > > Modified: trunk/reactos/drivers/filesystems/fastfat/fsctl.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… > ============================================================================== > --- trunk/reactos/drivers/filesystems/fastfat/fsctl.c [iso-8859-1] (original) > +++ trunk/reactos/drivers/filesystems/fastfat/fsctl.c [iso-8859-1] Sun Aug 24 03:28:01 2014 > @@ -550,11 +550,20 @@ > Fcb->RFCB.ValidDataLength = Fcb->RFCB.FileSize; > Fcb->RFCB.AllocationSize = Fcb->RFCB.FileSize; > > - CcInitializeCacheMap(DeviceExt->FATFileObject, > - (PCC_FILE_SIZES)(&Fcb->RFCB.AllocationSize), > - TRUE, > - &VfatGlobalData->CacheMgrCallbacks, > - Fcb); > + _SEH2_TRY > + { > + CcInitializeCacheMap(DeviceExt->FATFileObject, > + (PCC_FILE_SIZES)(&Fcb->RFCB.AllocationSize), > + TRUE, > + &VfatGlobalData->CacheMgrCallbacks, > + Fcb); > + } > + _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) > + { > + Status = _SEH2_GetExceptionCode(); > + goto ByeBye; > + } > + _SEH2_END; > > DeviceExt->LastAvailableCluster = 2; > ExInitializeResourceLite(&DeviceExt->FatResource); > > Modified: trunk/reactos/drivers/filesystems/fastfat/rw.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… > ============================================================================== > --- trunk/reactos/drivers/filesystems/fastfat/rw.c [iso-8859-1] (original) > +++ trunk/reactos/drivers/filesystems/fastfat/rw.c [iso-8859-1] Sun Aug 24 03:28:01 2014 > @@ -673,22 +673,35 @@ > Status = /*STATUS_END_OF_FILE*/STATUS_SUCCESS; > } > > - if (IrpContext->FileObject->PrivateCacheMap == NULL) > - { > - CcInitializeCacheMap(IrpContext->FileObject, > - (PCC_FILE_SIZES)(&Fcb->RFCB.AllocationSize), > - FALSE, > - &(VfatGlobalData->CacheMgrCallbacks), > - Fcb); > - } > - > - if (!CcCopyRead(IrpContext->FileObject, &ByteOffset, Length, > - (BOOLEAN)(IrpContext->Flags & IRPCONTEXT_CANWAIT), Buffer, > - &IrpContext->Irp->IoStatus)) > - { > - Status = STATUS_PENDING; > - goto ByeBye; > - } > + _SEH2_TRY > + { > + if (IrpContext->FileObject->PrivateCacheMap == NULL) > + { > + CcInitializeCacheMap(IrpContext->FileObject, > + (PCC_FILE_SIZES)(&Fcb->RFCB.AllocationSize), > + FALSE, > + &(VfatGlobalData->CacheMgrCallbacks), > + Fcb); > + } > + > + if (!CcCopyRead(IrpContext->FileObject, > + &ByteOffset, > + Length, > + (IrpContext->Flags & IRPCONTEXT_CANWAIT) != 0, > + Buffer, > + &IrpContext->Irp->IoStatus)) > + { > + ASSERT((IrpContext->Flags & IRPCONTEXT_CANWAIT) == 0); > + Status = STATUS_PENDING; > + goto ByeBye; > + } > + } > + _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) > + { > + Status = _SEH2_GetExceptionCode(); > + goto ByeBye; > + } > + _SEH2_END; > > if (!NT_SUCCESS(IrpContext->Irp->IoStatus.Status)) > { > @@ -947,30 +960,42 @@ > { > // cached write > > - if (IrpContext->FileObject->PrivateCacheMap == NULL) > - { > - CcInitializeCacheMap(IrpContext->FileObject, > - (PCC_FILE_SIZES)(&Fcb->RFCB.AllocationSize), > - FALSE, > - &VfatGlobalData->CacheMgrCallbacks, > - Fcb); > - } > - > - if (ByteOffset.QuadPart > OldFileSize.QuadPart) > - { > - CcZeroData(IrpContext->FileObject, &OldFileSize, &ByteOffset, TRUE); > - } > - > - if (CcCopyWrite(IrpContext->FileObject, &ByteOffset, Length, > - 1 /*IrpContext->Flags & IRPCONTEXT_CANWAIT*/, Buffer)) > - { > - IrpContext->Irp->IoStatus.Information = Length; > - Status = STATUS_SUCCESS; > - } > - else > - { > - Status = STATUS_UNSUCCESSFUL; > - } > + _SEH2_TRY > + { > + if (IrpContext->FileObject->PrivateCacheMap == NULL) > + { > + CcInitializeCacheMap(IrpContext->FileObject, > + (PCC_FILE_SIZES)(&Fcb->RFCB.AllocationSize), > + FALSE, > + &VfatGlobalData->CacheMgrCallbacks, > + Fcb); > + } > + > + if (ByteOffset.QuadPart > OldFileSize.QuadPart) > + { > + CcZeroData(IrpContext->FileObject, &OldFileSize, &ByteOffset, TRUE); > + } > + > + if (CcCopyWrite(IrpContext->FileObject, > + &ByteOffset, > + Length, > + TRUE /*(IrpContext->Flags & IRPCONTEXT_CANWAIT) != 0*/, > + Buffer)) > + { > + IrpContext->Irp->IoStatus.Information = Length; > + Status = STATUS_SUCCESS; > + } > + else > + { > + ASSERT(FALSE /*(IrpContext->Flags & IRPCONTEXT_CANWAIT) == 0*/); > + Status = STATUS_UNSUCCESSFUL; > + } > + } > + _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) > + { > + Status = _SEH2_GetExceptionCode(); > + } > + _SEH2_END; > } > else > { > > Modified: trunk/reactos/drivers/filesystems/fastfat/vfat.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… > ============================================================================== > --- trunk/reactos/drivers/filesystems/fastfat/vfat.h [iso-8859-1] (original) > +++ trunk/reactos/drivers/filesystems/fastfat/vfat.h [iso-8859-1] Sun Aug 24 03:28:01 2014 > @@ -4,6 +4,7 @@ > #include <ntifs.h> > #include <ntdddisk.h> > #include <dos.h> > +#include <pseh/pseh2.h> > > #define USE_ROS_CC_AND_FS > > >

11 years, 1 month

Re: [ros-dev] [ros-diffs] [jgardou] 63933: [WIN32K] - Enable commented freetype call: set font face size and coordinate transformation matrix Patch by Huw Campbell, reviewed by a gazillion of people. CORE-4657 #resolve #com...

by Thomas Faber

On 2014-08-24 15:28, jgardou(a)svn.reactos.org wrote: > -// FT_Set_Pixel_Sizes(ft_face, > -// TextObj->logfont.elfEnumLogfontEx.elfLogFont.lfWidth, > + FT_Set_Pixel_Sizes(ft_face, > + TextObj->logfont.elfEnumLogfontEx.elfLogFont.lfWidth, The abs() was added in the second version of the patch because this way it breaks tests. See https://jira.reactos.org/browse/CORE-4657?focusedCommentId=60379&page=com.a…

11 years, 1 month

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev