Re: [ros-dev] [ros-diffs] [jgardou] 56082: [DAMN_IT] - addendum to r56081

[Ged Murphy]

I totally agree, every module should have a ./test folder containing all related tests.
This was something I wanted to do with the proposed tree restructure (which I still think
should be pushed)
The need to save bandwidth and disk space is a thing of the past.


-----Original Message-----
From: ros-dev-bounces(a)reactos.org [mailto:[e-mail]] On Behalf Of Jérôme
Gardou
Sent: 07 March 2012 21:51
To: ros-dev(a)reactos.org
Subject: Re: [ros-dev] [ros-diffs] [jgardou] 56082: [DAMN_IT] - addendum to r56081

Hey!

Can't we add tests to the regular tree, and disable them with a onig 
flag or something. This is getting retarded, and we must be the only 
project separating tests and runtime in their tree.
Every tester should just build them (not speaking about developers...), 
and we include them in nightly builds. For me this separation is just 
pointless...

regards.
Jérôme

Le 07/03/2012 22:46, jgardou(a)svn.reactos.org a écrit :
>   Author: jgardou
>  Date: Wed Mar  7 21:46:15 2012
>  New Revision: 56082
>
>  URL: http://svn.reactos.org/svn/reactos?rev=56082&view=rev
>  Log:
>  [DAMN_IT]
>    - addendum to r56081
>
>  Modified:
>       trunk/rostests/apitests/w32kdll/w32kdll_2k3sp2/CMakeLists.txt
>       trunk/rostests/apitests/w32kdll/w32kdll_ros/CMakeLists.txt
>       trunk/rostests/apitests/w32kdll/w32kdll_vista/CMakeLists.txt
>       trunk/rostests/apitests/w32kdll/w32kdll_xpsp2/CMakeLists.txt
>
>  Modified: trunk/rostests/apitests/w32kdll/w32kdll_2k3sp2/CMakeLists.txt
>  URL:
> http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/w32kdll/w32kdll_…
>  ==============================================================================
>  --- trunk/rostests/apitests/w32kdll/w32kdll_2k3sp2/CMakeLists.txt [iso-8859-1]
> (original)
>  +++ trunk/rostests/apitests/w32kdll/w32kdll_2k3sp2/CMakeLists.txt [iso-8859-1] Wed Mar  7
> 21:46:15 2012
>  @@ -1,5 +1,5 @@
>
>  -spec2def(w32kdll_2k3sp2.dll w32kdll_2k3sp2.spec)
>  +spec2def(w32kdll_2k3sp2.dll w32kdll_2k3sp2.spec ADD_IMPORTLIB)
>
>    add_library(w32kdll_2k3sp2 SHARED
>        main.c
>  @@ -9,4 +9,3 @@
>    set_entrypoint(w32kdll_2k3sp2 0)
>
>    add_dependencies(w32kdll_2k3sp2 psdk )
>  -add_importlib_target(w32kdll_2k3sp2.spec w32kdll_2k3sp2.dll)
>
>  Modified: trunk/rostests/apitests/w32kdll/w32kdll_ros/CMakeLists.txt
>  URL:
> http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/w32kdll/w32kdll_…
>  ==============================================================================
>  --- trunk/rostests/apitests/w32kdll/w32kdll_ros/CMakeLists.txt [iso-8859-1] (original)
>  +++ trunk/rostests/apitests/w32kdll/w32kdll_ros/CMakeLists.txt [iso-8859-1] Wed Mar  7
> 21:46:15 2012
>  @@ -1,5 +1,5 @@
>
>  -spec2def(w32kdll_ros.dll w32kdll_ros.spec)
>  +spec2def(w32kdll_ros.dll w32kdll_ros.spec ADD_IMPORTLIB)
>
>    add_library(w32kdll_ros SHARED
>        main.c
>  @@ -10,4 +10,3 @@
>    target_link_libraries(w32kdll_ros win32ksys)
>
>    add_dependencies(w32kdll_ros psdk)
>  -add_importlib_target(w32kdll_ros.spec w32kdll_ros.dll)
>
>  Modified: trunk/rostests/apitests/w32kdll/w32kdll_vista/CMakeLists.txt
>  URL:
> http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/w32kdll/w32kdll_…
>  ==============================================================================
>  --- trunk/rostests/apitests/w32kdll/w32kdll_vista/CMakeLists.txt [iso-8859-1] (original)
>  +++ trunk/rostests/apitests/w32kdll/w32kdll_vista/CMakeLists.txt [iso-8859-1] Wed Mar  7
> 21:46:15 2012
>  @@ -1,5 +1,5 @@
>
>  -spec2def(w32kdll_dll.spec w32kdll_vista.spec)
>  +spec2def(w32kdll_vista.spec w32kdll_vista.spec ADD_IMPORTLIB)
>
>    add_library(w32kdll_vista SHARED
>        main.c
>  @@ -8,4 +8,3 @@
>    set_entrypoint(w32kdll_vista 0)
>
>    add_dependencies(w32kdll_vista psdk )
>  -add_importlib_target(w32kdll_vista.spec w32kdll_dll.spec)
>
>  Modified: trunk/rostests/apitests/w32kdll/w32kdll_xpsp2/CMakeLists.txt
>  URL:
> http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/w32kdll/w32kdll_…
>  ==============================================================================
>  --- trunk/rostests/apitests/w32kdll/w32kdll_xpsp2/CMakeLists.txt [iso-8859-1] (original)
>  +++ trunk/rostests/apitests/w32kdll/w32kdll_xpsp2/CMakeLists.txt [iso-8859-1] Wed Mar  7
> 21:46:15 2012
>  @@ -1,4 +1,4 @@
>  -spec2def(w32kdll_xpsp2.dll w32kdll_xpsp2.spec)
>  +spec2def(w32kdll_xpsp2.dll w32kdll_xpsp2.spec ADD_IMPORTLIB)
>
>    add_library(w32kdll_xpsp2 SHARED
>        main.c
>  @@ -6,5 +6,4 @@
>        ${CMAKE_CURRENT_BINARY_DIR}/w32kdll_xpsp2.def)
>    set_entrypoint(w32kdll_xpsp2 0)
>
>  -add_dependencies(w32kdll_xpsp2 psdk )
>  -add_importlib_target(w32kdll_xpsp2.spec w32kdll_xpsp2.dll)
>  +add_dependencies(w32kdll_xpsp2 psdk)
>
>  

_______________________________________________
Ros-dev mailing list
Ros-dev(a)reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev