If it ain't broke, don't fix it. ;)
I support winesync after the release, so as not to rush into it too much or delay the release further.
On Thu, 23 Sep 2010 12:14:13 +1000, victor martinez vicmarcal@hotmail.com wrote:
Completly agree with Caemyr. Indeed more,imho, we should just sync Wine AFTER each release in a 1-month window. This is quite common in projects that has a big dependence of others. I.E: -We release 0.3.12 at 10-October-2010. -We can just sync with Wine from 10-October-2010 to 10-November-2010. -After 10-November we have to forget about Wine Syncs and continue adding features, fixing regressions, bugs and underlying bugs discovered because the sync/own code. -Testing and -Release. If we found that is quite necesary a sync with Wine, then we have to release first and then AFTER the release sync with Wine again. This prevents finding bugs/regressions 1 week before a release. Some are caused because ReactOS bugs but others could be caused by the own Wine regressions. So with this 1-month window we have time to battle against ours and theirs after the Wine Sync.
As we love structured code, as we have a structured way to branch and release , maybe it is time to structure our sync/release process in order to avoid Frozen Trunks, extra-testers work, Last-minute-changelogs, or 10 months between releases.
In the same way, and imho, I think it is much better to avoid sending critical code one month before the release. Maybe the critical code is perfect/bug-free but it needs deep testing as it can reveal underlying bugs related to other hacked pieces. If a developer needs to follow coding that critical piece during that Quarantine-month before the release he can choose between a Branch or Keeping the critical pieces in his WC (Working Copy) and commiting after the release.
These two problems: Wine Syncs done out of a frame time and adding Critical code without a Quarantine time has been in my opinion the causes of this big delay.
Also, after releasing we should talk /chat/discuss which are the candidate-milestones for the next release.
These are my opinions from the Tester and the PR (the eternal forgotten) point of view. Good n8!
Date: Wed, 22 Sep 2010 23:57:43 +0200 From: caemyr@gmail.com To: ros-dev@reactos.org Subject: Re: [ros-dev] 0.3.12 milestones status
It might be helpful but otoh, it would delay release even futher, two weeks minimum in my opinion... and even more if serious regressions happen. Is it worthy to do a winesync before release? We do risk regressions and bugs a lot.
Best regards 2010/9/22 James Tabor jimtabor.rosdev@gmail.com
Just an idea, could we get to release state than sync up with wine (at
least, most of User32) and test again? Testing is the only thing I can
to for now.
James
On Tue, Sep 21, 2010 at 5:37 PM, Olaf Siejka caemyr@gmail.com wrote:
Translations must be commited first, i would also have as many fix patches
in, as possible. Otherwise, i agree.
2010/9/21 Aleksey Bragin aleksey@reactos.org
Let's branch & release 0.3.12 then, and finally unlock trunk.
WBR,
Aleksey Bragin.
Ros-dev mailing list
Ros-dev@reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev
Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev