Re: [ros-dev] [ros-diffs] [turner] 22683: expand %* to batch file params. b ug: #1629

[Saveliy Tretiakov]

And you forget return value check. malloc may return null.

Murphy, Ged (Bolton) wrote:
> [e-mail] wrote:
> > bc->raw_params = malloc(_tcslen(param));
> > _tcscpy(bc->raw_params,param);
>
> Please check the docs, I don't have access to any at the moment, but if I
> recall correctly both strlen and wcslen return the number of chars, not
> including the '/0'.
>
> This will therefore mean we miss off the '/0' for ASCII builds and only have
> half the required space for unicode builds.
>
> Ged.
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev