Re: [ros-dev] Re : I need help fixing rbuild and testing builds on *nix machines!

[Eric Kohl]

Hello Sylvain!

The goal is to convert most of the *.inf files to Unicode. The 
conversion is optional, not mandatory. In cases where localized strings 
should be use a conversion is needed. For example syssetup.inf could 
keep the names of all start menu folders and items for all supported 
languages in localized "Strings" sections (eg "[Strings.0407]"). Once 
you install ReactOS the start menu will be localized correctly, no more 
"Accessories" folder for french, spanish, greek or turkish users.

The Unicode-enabled inf parser has at least one or two major bugs that 
cause a heap space corruption on linux machines. It should be either an 
off-by-one bug or a missing "* sizeof(WCHAR)" somewhere because the 
ASCII/ANSI version worked quite well for a few years.

Regards
Eric

Sylvain Petreolle schrieb:
> Are the usetup changes implying a unicode conversion of reactos.dff ?
> Doing tests and looking at testbot output shows that usetup is having problem parsing the file.
>
> (base/setup/usetup/interface/usetup.c:2758) SetupFindFirstLine() failed (1st stage)It also fails finding gecko cab file in 2nd stage.
>
> Kind regards,
> Sylvain Petreolle
>
> ----- Message d'origine ----
> > De : Eric Kohl [e-mail]
> > À : ReactOS Development List [e-mail]
> > Envoyé le : Ven 23 avril 2010, 11 h 42 min 41 s
> > Objet : [ros-dev] I need help fixing rbuild and testing builds on *nix machines!
> >
> > Hi!
>
> In order to fix bug #2482 I needed to make inflib Unicode-aware. My
> > local ReactOS setup is curently able to build Boot-CD and Live-CD using Unicode 
> > hive*.inf files.
>
> Rbuild is the only tool that still uses the original
> > inflib. Could someone who knows more about C++ and STL than I do have a look at 
> > rbuild and make it work with the new inflib?
>
> I can provide a patch that
> > includes newinflib (Unicode-aware inflib) and  my changes to usetup and 
> > mkhive.
>
> I also need someone who can test the whole patch on a *nix
> > machine. Any 
> > volunters?
>
> Regards,
> Eric
>
> Ros-dev
> > mailing list
> > href="mailto:[e-mail]">[e-mail]
> > href="http://www.reactos.org/mailman/listinfo/ros-dev" target=_blank
> > > http://www.reactos.org/mailman/listinfo/ros-dev
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev