[ros-dev] MS Console/Terminal stuff (was: "RE: Ros-dev Digest, Vol 177, Issue 2")

[Hermès BÉLUSCA-MAÏTO]

Hi,

I’m trying to answer point by point.

 

1.       Their license is MIT. At least it allows us to borrow ideas from their code for
how to implement stuff in ReactOS’ console/terminal. (I suppose that if one wants to copy
entire chunks of code, that I wouldn’t do it, I’m not sure how the licensing of the
original ReactOS console GPL code would have to change. But “I’m not a lawyer”. Anyway,
copy-pasting stuff is never a good idea.)

2.       Yes but again you don’t need to care. It allows us to remain “original” in our
way of implementing the things. What’s now “documented” however, is the interface between
condrv and conhost (and to kernel32 if my quick reading of the shared headers is correct).
This is sufficient. Then the internal implementation one can write for ReactOS is left
free, this allows one to have original code and note a dull copy-paste.

3.       ReactOS doesn’t use C++ in the console, and won’t use ”WinRT” any time soon in
its entire code-base. So forget about any direct import of the MS console code into ROS.

 

Regards,

Hermès

 

De : Ros-dev [mailto:[e-mail]] De la part de Biswapriyo Nath
Envoyé : mardi 7 mai 2019 20:42
À : ros-dev(a)reactos.org
Objet : Re: [ros-dev] Ros-dev Digest, Vol 177, Issue 2

 

Some queries though:

1. There are many restrictions on how the code can be used. Are developers allowed to
import the idea to ReactOS? Also with a different license.

2. The half of the codebase of console subsystem implemented in KernelBase and Kernel32.
Those are not open source. Also the main magic happens in ConDrv driver.

3. The project has C++/WinRT code. Does ReactOS have that section?

Thank you <3