Hi,
I haven't exactly said, why I'm against to merging Alex branch into the
trunk. Usually I try to review all commits which goes to kernel
components (except win32k and network drivers) and to some of the user
mode dlls (ntdll, crt, msvcrt, kernel32). Alex' commits are often a mix
from many changes, improvements and merges from trunk. It is not
possible, to review a single change or improvement. I'm not against the
changes, but I need (and some other people also) a way to understand
what is changed.
- Hartmut
Hartmut Birr schrieb:
Hi,
sorry for my next lines,
I'm strictly against to merging Alex branch into our trunk. If I look to
the commit comments, I see one, two or three lines of comments like
'Merge with blight 's rewrite' or 'My kernel fixes, new...' and
always
there are changed ten, twenty or more files. In the past there was
always a description about the improvement of our development. I would
like it if we can go back to this policity. I does know, that some of my
commits are in conflict with this rules.
- Hartmut
_______________________________________________
Ros-dev mailing list
Ros-dev(a)reactos.com
http://reactos.com:8080/mailman/listinfo/ros-dev