Re: [ros-dev] [ros-diffs] [pschweitzer] 58960: [RTL] Finally reenable RtlAcquirePrivilege

[Jérôme Gardou]

Hey Pierre!

Nice patch series, that takes ReactOS nearer to being secure. A remark though :
>  /*
> * enable the SeSystemtimePrivilege privilege
> * Call SetLocalTime twice to ensure correct results
> */
> Ret = SetLocalTime(&SetupData->SystemTime) &&
>      SetLocalTime(&SetupData->SystemTime);

This is a bit confusing, and the comment doesn't really help. Why would calling the function twice ansure correct result ? Also, this is likely to be optimized away by the compiler, or at least produce a report in static code analysers.

I know this isn't pure chance. Any hint as to why you wrote it like this ?

Cheers
Jérôme