Re: [ros-dev] [ros-diffs] [akhaldi] 69435: [NTVDM] Improve the PCH situation.

[Hermès BÉLUSCA - MAÏTO]

Hi !

I don't think this commit constitutes a nice improvement for NTVDM at its
present status:

- having the precise list of the used headers in each .c file helped me in
knowing at a glance which functionalities a given .c needed,
- therefore enabling me to find better places where to put the functions and
possibly reduce the number of headers in the future (refactoring).
- This broke my numerous local changes regarding e.g. a modularization of
the CPU layer in NTVDM, video layer, ...
- Finally, stuffing indistinctively *all* the headers (including the private
ones like bios32p.h which purpose was to be used in the sources of one
module only) inside the PCH ntvdm.h, makes for example BIOS or DOS functions
visible inside hardware modules like ps2.h, which is completely illogical
when you try to modularize NTVDM at source level, by completely separating
hardware emulation from bios code and DOS emulation, etc... .

Therefore I will revert your commit tomorrow, while keeping a diff and put
it in a JIRA report.

Cheers,
Hermès.

________________________________________

[ros-diffs] [akhaldi] 69435: [NTVDM] Improve the PCH situation.
akhaldi at svn.reactos.org akhaldi at svn.reactos.org 
Sat Oct 3 21:47:46 UTC 2015
• Previous message: [ros-diffs] [spetreolle] 69434: [user32_apitest] 0x%lu
does not mean anything correct.
• Next message: [ros-diffs] [spetreolle] 69436: [ROSTESTS] Fix 0x%lu
specifier. Add cmake file for notificationtest.
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
________________________________________
Author: akhaldi
Date: Sat Oct  3 21:47:46 2015
New Revision: 69435

URL: http://svn.reactos.org/svn/reactos?rev=69435&view=rev
Log:
[NTVDM] Improve the PCH situation.