21 Nov
2015
21 Nov
'15
10:01 a.m.
Hey all. I have some thoughts about our current patch situation. After
the last big strike regarding patches, which was around the Hackfest,
The count of them increased amazingly.
We got some new contributers, this year, which do a great work. Some of
our old contributers are still hacking like fire and mostly this are
small fixes with big impact. Easy to review.
I summed up some of them, to show which could get some attention. There
are also bigger patches, which would need a coordinated review, but add
very nice features (Swyters vbox fix for
example). I am sure that about 10 of them could make it.
Patches that are currently under review or active development
=============================================================
The following patches are the ones, which actually got some attention.
They all are slightly bigger ones.
CORE-10533 PATCH: Fix local network resolving
CORE-10440 PATCH: Fix issues of ws2_32_new
CORE-10367 Implement apphelp sdb layer
(More or less) simple patches, that would be nice2have for 0.4
==============================================================
These are all the patches from our actual most active contributers. Most
of them are very small and easy to understand.
Let's not forget them because contributers can become developers, which
we need so badly. It would be nice to have them in trunk
before release, if they are correct.
CORE-10550 clipbrd: Load the clipboard contents from a file
CORE-10476 Add a placeholder machine owner at second stage
installer to improve UX
CORE-10438 [shell32] 'Empty Recycle Bin' should be disabled
when no items are present
CORE-10437 [console] Add missing DS_MODALFRAME
CORE-10436 [shell32] OK button in run dialog should be disabled
by default
CORE-10410 [fdebug] Manifest and application title
CORE-10393 [RAPPS] Small Database Update
CORE-10310 Automatically format file size & assorted fixes for apps
CORE-9721 [notepad] Let the user know when an opened file is
modified
CORE-9959 shell32: patch for SHFileOperation (delete-operation)
CORE-6742 Can't dynamically change the resolution by resizing
in VirtualBox
Hacks(?) that would improve the look and feel in 0.4
====================================================
These patches contain hacks but it would be nice to have them in
release. I don't mean to apply them to trunk, but to the 0.4 branch.
Important is that, if this happens, enough regression testing is done.
CORE-9654 PATCH +Bugfix: UXTHEME draw text with shadows, fix
GetThemeSysColor
CORE-9533 Title icons are 32pixel downsized to 16pixel
CORE-5644 mspaint: selection border isn't visible
CORE-9689 Drive's properties theming problem
CORE-8925 Start menu has classic border when themes are enabled
Drive Type related patches
==========================
The author of these patches did some effort to fix the bug, which shows
the correct icon for specific drives.
I feel like I saw more than this 2 patches but I am not sure and don't
find more. We should collaborate with him and take care of this annoying
bug,
CORE-10221 Fix icons in My Computer
CORE-9622 Improvement to GetDriveType() Function
Victor's Patches
================
These patches are from Victor M. Calvo. He did a big effort to fix bugs,
which affect specifig apps and caused registry curruption.
He also proved his patches with apitests but almost nothing happened
with the patches.
CORE-9673 PATCH: BS_DIBPATTERN8x8 not supported
CORE-9672 PATCH: Rewrite RegQueryInfoKeyW
CORE-9666 PATCH: RegQueryValueExW fails to set properly the
REG_NONE type
CORE-9665 PATCH: RegQueryValueExW and RegQueryValueExA calls
accept bytes not chars.
CORE-9398 PATCH: Several fixes for
SetupInstallServicesFromInfSectionExW
CORE-8164 Fix a interexchanging values in Vga driver
CORE-8157 Fix a memcpy in Dhcpclient using the length in bytes.
CORE-8156 Fix a sanity check of a returned ConstructBitBlob
CORE-8077 GetDiskFreeSpaceW fixes
CORE-8076 SetVolumeLabelW and GetVolumeInformationW fixes
Cheers
Robert