Re: [ros-dev] Re: [ros-diffs] [cwittich] 18611: fix compile with msvc

[Christoph von Wittich]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I already started to fix the headers, and I will remove #include
winternl.h from aclui as soon I have tested my changes.


Christoph


Alex Ionescu schrieb:
>   cwittich(a)svn.reactos.com wrote:
>  
> >   fix compile with msvc
> >
> >
> >  ------------------------------------------------------------------------
> >  *Modified: trunk/reactos/lib/aclui/precomp.h*
> >
> >  --- trunk/reactos/lib/aclui/precomp.h    2005-10-19 21:46:17 UTC (rev
> >  18610)
> >  +++ trunk/reactos/lib/aclui/precomp.h    2005-10-19 21:46:30 UTC (rev
> >  18611)
> >  @@ -5,7 +5,9 @@
> >
> >  #include <prsht.h>
> >  #include <aclui.h>
> >  #include <sddl.h>
> >   
> >
> >  +#if defined (__GNUC__)
> >   
> >
> >  #include <winternl.h>
> >   
> >
> >  +#endif
> >   
> >
> >  #include <ntsecapi.h>
> >  #if SUPPORT_UXTHEME
> >  #include <uxtheme.h>
> >   
> >  
>  These changes are really wrong! HEADERS have nothing to do with the
>  compiler! The HEADERS have to be fixed...you're just building with mingw
>  headers and msvc, and assuming the errors are because of msvc, but if
>  you'll try compiling with PSDK (or vice-versa), then these changes make
>  no sense at all.
>  
>  Best regards,
>  Alex Ionescu
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev 
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.1 (MingW32)
> Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
>
> iD8DBQFDVss70ADPczu7wMoRAjD7AKCcm6I6WgwIn9Gjfe/WYz2gIR0k9QCfV0rj
> cEW1aAG8FSF93ZaiE9ynW3o=
> =vV92
> -----END PGP SIGNATURE-----