30 May
2018
30 May
'18
4:19 p.m.
Am 30.05.2018 um 13:26 schrieb Ged Murphy:
Potential problems are:
4) something else?
I've been struggling with e.g. https://github.com/reactos/reactos/pull/276
On the one hand, we definitely need official support for Chinese,
Korean, and Japanese character sets.
On the other hand, this must not bloat up ReactOS by default, and just
dropping a 12 MB font into the repository definitely does.
So what is the ideal solution? I don't even know myself.
- I could leave the PR open and hope that the submitter addresses my
comments and comes up with a better solution. That hasn't happened in
the last months.
- I could close the PR right away. That would give the submitter no
chance to address my comments and may even look disrespectful. And the
original problem tends to be forgotten.
- I could close the PR and open a JIRA issue describing the problem.
If we decide on that as a general rule, we would put another burden on
every reviewer. Additionally, such general JIRA issues tend to rot in
our database as well.
I think we often have this situation where the submitted PR is wrong,
but we don't know the right solution either, and therefore keep the PR
open. If we can better deal with these cases, the number of open PRs may
decrease significantly.
- Colin