Oh please don't go there. Do you honestly think you (in general) are smarter at
generating microprocessor instructions than a multi-million hour compiler software?
If the execution speed is acceptable, I will always prefer readability of the source code
over execution speed. I don't really care if some function can be executed 1ns faster if
several functions were collapsed into one.
If I could trade a 1 second added boot up time (~8 second total then?) for readable
ReactOS source code, I would do it immediately ;-)
Casper
_____
From: ros-dev-bounces@reactos.com [mailto:ros-dev-bounces@reactos.com] On Behalf Of crashofurit Sent: 28. september 2005 17:22 To: ReactOS Development List Subject: Re: [ros-dev] Re: [ros-svn] [gdalsnes]18113:-reorderInsertXscendingOrder macro argument order andupdate uses
Using smaller functions instead when we are only using the code once, may help on readability but can cost speed and space. (Think of what standard code C uses to enter and exit a function.) But then again, you can get around that by using declaring those functions as inline.
On 9/28/05, Casper Hornstrup ch@csh-consult.dk wrote:
The alternative is: do the cleanup at every return, use goto or use try/finally. 1)Cleanup at every return is madness. Most functions in ros do a large amount of cleanup at each return and I sometimes spot mistakes where one/more return misses some cleanup. Those errors are _hard_ to find.
The functions are too large then. Use more smaller functions instead.
Casper
_______________________________________________ Ros-dev mailing list Ros-dev@reactos.com http://reactos.com:8080/mailman/listinfo/ros-dev