On 8/20/07, Colin Finck mail@colinfinck.de wrote:
If you look in glibc's "stddef.h" (for example here: http://tinyurl.com/yv6s9b), you find 32 checks for the existence of the wchar_t type. We'll probably never need all of them, but this just shows that almost every host needs its own check. And adding all these definitions to the Makefile of every app, which needs them, is a huge overkill in my opinion. This is why I prefer putting all checks into "winnt.h".
I agree its a pain but it seems like a GNUism we have to live with. I mean any other project we import in to the tree is going to have the same problem if it uses the wchar_t type right? So we would have to change the include order with them as well. Couldn't we add some magic to rbuild to make it act like configure, detect the host and then pass this to the makefile by just globally add a -D($HOST_WCHAR_DEFINE) like we do with other compiler flags?
Sorry if I am way off base, I admit I have not looked in to the problem in depth, I am just trying to avoid long term hassle. As it stands now the Wine guys are reluctant to change things just for ReactOS and also reluctant to change things that already work on multiple host platforms.