Hi Marc,
I talked with Hervé about this in IRC.
Marc Piulachs wrote: A) The behavior of the "include" + "directory" tags are inconsistent
He has no opinion about this directory thing. But I myself would prefer your change here, so we have a consistent handling.
B) The "oldcrt" attribute is no longer used and can be removed.
Hervé agrees with you on that.
C) The module types "Iso" , "LiveIso" , "IsoRegTest" and "LiveIsoRegTest" are IMHO hacks introduced to be able use the makefile generation code.
They are hacks, but they are still needed. If you can rewrite them better, feel free to do so :-)
D) Any module is using the "EmbeddedTypeLib" module type , is really
needed or can be removed?
This module is needed for a future import of "stdole2.tlb".
E) IMHO the "ElfExecutable" is incorrect
We cannot say anything about that, you should sort this out with Art Yerkes.
X) tags like "linkerflag" or "compilerflag" are gcc/mingw specific and
should be replaced with other tags that provide the
equivalent functionality using a more abstract aproach so other
backends/compilers could benefit from it
This would really require much work and mingw is the only backend, which is currently used for compiling ReactOS. Some of the stuff, which can be compiled with MSVC, will be compiled in the IDE with the project files. But generally this sounds good, so we can think about that as a long-term plan.
Generally, if you have a great idea to improve something, don't hesitate to write a patch and file a bug in our Bugzilla for it :-)
Regards,
Colin