M Bealby wrote:
However, after submitting bugs #1102 and #1103 (now fixed by BrandonTurner) it became apparent that incorrect usage of the RtlAllocateHeap function (and its alias HeapAlloc) is quite common. It may return NULL if memory cannot be allocated and in some parts of the code this is not checked. This would lead to a segmentation fault on reading / writing.
If it was only the incorrect usage of RtlAllocateHeap, missing checks are all over the place and I wish at least all of our permanent developers would take care of at least the most common ones that could lead to crashes in case of failure. Admittedly sometimes people seem to be lazy and don't care about possible failures, but it's annoying to see such code going in on an almost daily basis.
- Thomas