Hartmut Birr wrote:
Alex Ionescu wrote:
Hi,
Revision 17718 should fix this. It was a small typo on my part, sorry.
Have you looked to RtlUnicodeStringToAnsiSize and RtlUnicodeStringToOemSize? They do simply the same and cannot fix the bug.
I don't understand what you mean? Those macros are re-written from the IFS, they can't be wrong... I must be misunderstanding you.
PS. Filip: do you ever *read* my patches when you review them? ;-)
Do you ever *test* your own patches before you commit them? ;-)
Sure... testing this patch (which took me about 2 hours) revealed two things to me: 1) The string routines were returning the wrong size, breaking countless applications 2) ANSI_NULL was not defined correctly, also causing possibly many bugs.
but I have to admit, I don't compile ros-on-ros, so I didn't catch those two typos. I don't think any of the developers here do except for you... Just like almost nobody here does release builds, and I'm always the one that has to fix the build :)
- Hartmut
Best regards, Alex Ionescu