[ros-dev] Re: [ros-bugs] [Bug 986] devmgr - DeviceCreateHardwarePage, DeviceCreateHardwarePageEx

[Brandon Turner]

Also, just 2 things i noticed:
1) int -> INT and void -> VOID
2) the name of the function should be the first word on the line per our 
unspoken formatting.

Brandon

ReactOS.Bugzilla(a)reactos.org wrote:

>  http://www.reactos.org/bugzilla/show_bug.cgi?id=986
>
>
>
>
>
> ------- Additional Comments From w3seek(a)reactos.com  2005-11-14 16:21 CET -------
> If you happen to use TortoiseSVN, there's an option 'Create Patch' in the
> menu,
> otherwise see help for svn diff. Anyway, here are the things I'd like you to fix
> before I'm going to commit it to svn:
>
> - add missing definitions to cfgmgr32.h if missing (instead of defining it in
> the .c file)
> - please don't mix tchar and unicode-only stuff like here (just use unicode
> stuff in there): wsprintf( resData, TEXT("%s %s"), resData, textData);
> - the code lacks a lot important failure case checks, making it unpredictable
> when a single function call fails
>
> This may sound like a lot, I'm just trying to preserve a certain level of
> quality ;) We already have more than enough code that needs a serious overhaul
> or even rewrite.
>
>   
>