Re: [ros-dev] [ros-diffs] [sginsberg] 42829: - svchost: #ifdef _MSC_VER doesn't mean "using Microsoft's headers" anymore - ddraw, imm32, msxml3, oleaut32, riched20: Include typeof.h for typeof emulation when compiling under MSVC and remove from ReactOS-generic.rbuild (this can't go to port.h as the modules do not include it). - TCPIP: Fix a check for MSVC. - NDIS: Don't use floating point arithmetics in kernel mode -- spotted by MSVC trying to link to ftol (gcc inlined the operation). - SAMLIB: Use __VA_ARG

[Timo Kreuzer]

lol+1!


sginsberg(a)svn.reactos.org wrote:
>   Author: sginsberg
>  Date: Fri Aug 21 17:57:26 2009
>  New Revision: 42829
>
>  URL: http://svn.reactos.org/svn/reactos?rev=42829&view=rev
>  Log:
>  [...]
>  - NDIS: Don't use floating point arithmetics in kernel mode -- spotted by MSVC trying
> to link to ftol (gcc inlined the operation).
>  [...]
>
>
>  Modified: trunk/reactos/drivers/network/ndis/ndis/config.c
>  URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/ndis/ndis/…
>  ==============================================================================
>  --- trunk/reactos/drivers/network/ndis/ndis/config.c [iso-8859-1] (original)
>  +++ trunk/reactos/drivers/network/ndis/ndis/config.c [iso-8859-1] Fri Aug 21 17:57:26
> 2009
>  @@ -705,7 +705,14 @@
>   
>       while (j < str.Length && str.Buffer[j] != '\0') j++;
>            
>  -    *NetworkAddressLength = (UINT)((j/2)+0.5);
>  +    if ((j % 2) == 0)
>  +    {
>  +        *NetworkAddressLength = (UINT)(j/2);
>  +    }
>  +    else
>  +    {
>  +        *NetworkAddressLength = (UINT)((j/2)+1);
>  +    }
>   
>       if ((*NetworkAddressLength) == 0)
>       {
>
>