Re: [ros-dev] [ros-diffs] [spetreolle] 60221: [ROSSYM] Enable rossym build on MSVC.

[Timo Kreuzer]

Huh? What's the point? You are aware that rossym requires binaries built
with GCC?

Am 20.09.2013 00:13, schrieb spetreolle(a)svn.reactos.org:
>   Author: spetreolle
>  Date: Thu Sep 19 22:13:46 2013
>  New Revision: 60221
>
>  URL: http://svn.reactos.org/svn/reactos?rev=60221&view=rev
>  Log:
>  [ROSSYM]
>  Enable rossym build on MSVC.
>
>  Removed:
>      trunk/reactos/lib/rossym/dummy.c
>      trunk/reactos/lib/rossym_new/dummy.c
>  Modified:
>      trunk/reactos/lib/rossym/CMakeLists.txt
>      trunk/reactos/lib/rossym_new/CMakeLists.txt
>
>  Modified: trunk/reactos/lib/rossym/CMakeLists.txt
>  URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rossym/CMakeLists.txt?…
>  ==============================================================================
>  --- trunk/reactos/lib/rossym/CMakeLists.txt	[iso-8859-1] (original)
>  +++ trunk/reactos/lib/rossym/CMakeLists.txt	[iso-8859-1] Thu Sep 19 22:13:46 2013
>  @@ -1,19 +1,15 @@
>   
>  -if(MSVC)
>  -    add_library(rossym dummy.c)
>  -else()
>  -    add_definitions(-D_NTSYSTEM_)
>  -    list(APPEND SOURCE
>  -        delete.c
>  -        find.c
>  -        fromfile.c
>  -        frommem.c
>  -        fromraw.c
>  -        getraw.c
>  -        init.c
>  -        initkm.c
>  -        initum.c
>  -        zwfile.c)
>  -    add_library(rossym ${SOURCE})
>  -    add_dependencies(rossym psdk bugcodes)
>  -endif()
>  +add_definitions(-D_NTSYSTEM_)
>  +list(APPEND SOURCE
>  +    delete.c
>  +    find.c
>  +    fromfile.c
>  +    frommem.c
>  +    fromraw.c
>  +    getraw.c
>  +    init.c
>  +    initkm.c
>  +    initum.c
>  +    zwfile.c)
>  +add_library(rossym ${SOURCE})
>  +add_dependencies(rossym psdk bugcodes)
>
>  Removed: trunk/reactos/lib/rossym/dummy.c
>  URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rossym/dummy.c?rev=602…
>  ==============================================================================
>  --- trunk/reactos/lib/rossym/dummy.c	[iso-8859-1] (original)
>  +++ trunk/reactos/lib/rossym/dummy.c	(removed)
>  @@ -1,32 +0,0 @@
>  -
>  -#include <ntddk.h>
>  -#include <reactos/rossym.h>
>  -
>  -#define NDEBUG
>  -#include <debug.h>
>  -
>  -BOOLEAN
>  -RosSymCreateFromFile(PVOID FileContext, PROSSYM_INFO *RosSymInfo)
>  -{
>  -    return FALSE;
>  -}
>  -
>  -VOID
>  -RosSymDelete(PROSSYM_INFO RosSymInfo)
>  -{
>  -}
>  -
>  -BOOLEAN
>  -RosSymGetAddressInformation(PROSSYM_INFO RosSymInfo,
>  -                            ULONG_PTR RelativeAddress,
>  -                            ULONG *LineNumber,
>  -                            char *FileName,
>  -                            char *FunctionName)
>  -{
>  -    return FALSE;
>  -}
>  -
>  -VOID
>  -RosSymInitKernelMode(VOID)
>  -{
>  -}
>
>  Modified: trunk/reactos/lib/rossym_new/CMakeLists.txt
>  URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rossym_new/CMakeLists.…
>  ==============================================================================
>  --- trunk/reactos/lib/rossym_new/CMakeLists.txt	[iso-8859-1] (original)
>  +++ trunk/reactos/lib/rossym_new/CMakeLists.txt	[iso-8859-1] Thu Sep 19 22:13:46 2013
>  @@ -1,26 +1,22 @@
>   
>  -if(MSVC)
>  -    add_library(rossym dummy.c)
>  -else()
>  -    add_definitions(-D_NTSYSTEM_)
>  -    list(APPEND SOURCE
>  -        delete.c
>  -        dwarfabbrev.c
>  -        dwarfaranges.c
>  -        dwarfcfa.c
>  -        dwarfget.c
>  -        dwarfinfo.c
>  -        dwarfopen.c
>  -        dwarfpc.c
>  -        dwarfpubnames.c
>  -        find.c
>  -        fromfile.c
>  -        init.c
>  -        initum.c
>  -        pe.c
>  -        zwfile.c)
>  -    add_library(rossym ${SOURCE})
>  -    add_pch(rossym precomp.h)
>  -    add_dependencies(rossym psdk bugcodes)
>  -    allow_warnings(rossym)
>  -endif()
>  +add_definitions(-D_NTSYSTEM_)
>  +list(APPEND SOURCE
>  +    delete.c
>  +    dwarfabbrev.c
>  +    dwarfaranges.c
>  +    dwarfcfa.c
>  +    dwarfget.c
>  +    dwarfinfo.c
>  +    dwarfopen.c
>  +    dwarfpc.c
>  +    dwarfpubnames.c
>  +    find.c
>  +    fromfile.c
>  +    init.c
>  +    initum.c
>  +    pe.c
>  +    zwfile.c)
>  +add_library(rossym ${SOURCE})
>  +add_pch(rossym precomp.h)
>  +add_dependencies(rossym psdk bugcodes)
>  +allow_warnings(rossym)
>
>  Removed: trunk/reactos/lib/rossym_new/dummy.c
>  URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rossym_new/dummy.c?rev…
>  ==============================================================================
>  --- trunk/reactos/lib/rossym_new/dummy.c	[iso-8859-1] (original)
>  +++ trunk/reactos/lib/rossym_new/dummy.c	(removed)
>  @@ -1,60 +0,0 @@
>  -
>  -#include <ntddk.h>
>  -#include <reactos/rossym.h>
>  -
>  -#define NDEBUG
>  -#include <debug.h>
>  -
>  -BOOLEAN
>  -RosSymCreateFromFile(PVOID FileContext, PROSSYM_INFO *RosSymInfo)
>  -{
>  -    UNIMPLEMENTED;
>  -    return FALSE;
>  -}
>  -
>  -VOID
>  -RosSymDelete(PROSSYM_INFO RosSymInfo)
>  -{
>  -    UNIMPLEMENTED;
>  -}
>  -
>  -VOID
>  -RosSymFreeInfo(PROSSYM_LINEINFO LineInfo)
>  -{
>  -    UNIMPLEMENTED;
>  -}
>  -
>  -BOOLEAN
>  -RosSymGetAddressInformation(PROSSYM_INFO RosSymInfo,
>  -                            ULONG_PTR RelativeAddress,
>  -                            PROSSYM_LINEINFO RosSymLineInfo)
>  -{
>  -    UNIMPLEMENTED;
>  -    return FALSE;
>  -}
>  -
>  -VOID
>  -RosSymInit(PROSSYM_CALLBACKS Callbacks)
>  -{
>  -    UNIMPLEMENTED;
>  -}
>  -
>  -VOID
>  -RosSymInitKernelMode(VOID)
>  -{
>  -    UNIMPLEMENTED;
>  -}
>  -
>  -BOOLEAN
>  -RosSymAggregate(PROSSYM_INFO RosSymInfo, PCHAR Type, PROSSYM_AGGREGATE Aggregate)
>  -{
>  -    UNIMPLEMENTED;
>  -    return FALSE;
>  -}
>  -
>  -VOID
>  -RosSymFreeAggregate(PROSSYM_AGGREGATE Aggregate)
>  -{
>  -    UNIMPLEMENTED;
>  -}
>  -
>
>
>