Re: [ros-dev] [ros-diffs] [akhaldi] 56973: [CLASSPNP] * Explicitly mark the functions as stdcall (NTAPI).. -mrtd changes the default calling convention, but name-decoration isn't affected by this. The -mrtd feature has its ...

[Aleksey Bragin]

Indeed,  I said the same in the #reactos-dev: It would be great to fix 
this upstream, and many would enjoy this. Hacking ALL third party MSVC 
code is not as great.

Timo volunteers? :D

On 29.07.2012 14:32, Timo Kreuzer wrote:
>  
>  While this works for us, we should consider trying to get this feature 
>  back. When it's considered for removal, then they obviously "fixed" 
>  something now that noone needs (and that makes absolutely no sense at 
>  all), while the feature as it was before is very useful to compile 3rd 
>  party code for Windows.
>  One possibility (since we compile gcc ourselves anyway), is finding 
>  out where they "fixed" it and revert that revision for our builds. If 
>  they completely remove it, we rename the option and send the old code 
>  in as a new feature for MSVC compatibility ;-)
>
>
>
>  Am 29.07.2012 03:49, schrieb akhaldi(a)svn.reactos.org:
> >   Author: akhaldi
> >  Date: Sun Jul 29 01:49:24 2012
> >  New Revision: 56973
> >
> >  URL: http://svn.reactos.org/svn/reactos?rev=56973&view=rev
> >  Log:
> >  [CLASSPNP]
> >  * Explicitly mark the functions as stdcall (NTAPI).. -mrtd changes 
> >  the default calling convention, but name-decoration isn't affected by 
> >  this. The -mrtd feature has its origin in some older linux-code-mode, 
> >  and it's considered for removal in GCC 4.8.
> >  * Fix some warnings.
> >
> >  Modified:
> >       trunk/reactos/drivers/storage/classpnp/CMakeLists.txt
> >       trunk/reactos/drivers/storage/classpnp/autorun.c
> >       trunk/reactos/drivers/storage/classpnp/class.c
> >       trunk/reactos/drivers/storage/classpnp/classp.h
> >       trunk/reactos/drivers/storage/classpnp/classwmi.c
> >       trunk/reactos/drivers/storage/classpnp/clntirp.c
> >       trunk/reactos/drivers/storage/classpnp/create.c
> >       trunk/reactos/drivers/storage/classpnp/dictlib.c
> >       trunk/reactos/drivers/storage/classpnp/lock.c
> >       trunk/reactos/drivers/storage/classpnp/obsolete.c
> >       trunk/reactos/drivers/storage/classpnp/power.c
> >       trunk/reactos/drivers/storage/classpnp/retry.c
> >       trunk/reactos/drivers/storage/classpnp/utils.c
> >       trunk/reactos/drivers/storage/classpnp/xferpkt.c
> >  
>