Hi,
--- Jason Filby jason.filby@gmail.com wrote:
What are the the areas that we need to standardize on regarding coding style?
OK This only applies to ntdll, user32, kernel32 or any other dll we might share with Wine. ntoskrnl, the drivers and Win32k are off limits. Also I am not talking about issues like tabs and spaces. That can be debated all day long.....
DPRINT and DPRINT1 really need to go and we could just standise on using the Wine macros in our Win32 system, FIXME, WARN, ERR, etc. It reduces the diff and if we ever get support for switching the debug channels then it will make life less of a pain.
Also strings like this have to go
L"Software\Microsoft\"
This will work on Linux and Windows
static const WCHAR KeyW[] = {'S','o','f','t','w','a','r','e','\', 'M','i','c','r','o','s','o','f','t','\',
I really did not want to commit the crypto stuff to advapi32 as I knew it would lead to this discussion but Thomas found that without it then Abiword would not work. This in turn lead to Eric making this patch:
http://cvs.reactos.com/cgi-bin/cvsweb.cgi/reactos/lib/advapi32/crypt/crypt.c...
Which does make it conform to the ReactOS coding standard but now will make merging in fixes from Wine a bit more of a pain.
Thanks Steven
__________________________________ Do you Yahoo!? All your favorites on one personal page � Try My Yahoo! http://my.yahoo.com