I agree with the requirement for the parenthesis, simply because it helps separate the various conditions that are being tested for.&nbsp; Even looking at the code without braces, you should be questioning exactly what is going on in there since you generally don&#39;t do assignments inside if statements.&nbsp; The fact that the compiler failed to catch it because of the parenthesis doesn&#39;t excuse a programmer from not seeing the problem.&nbsp; I personally would never assume that a dev intended to do an assignment just because he or she put parenthesis around such a statement, I would automatically assume they messed up typing and left off a = in the check.<br>
<br><div class="gmail_quote">2009/2/16 Timo Kreuzer <span dir="ltr">&lt;<a href="mailto:timo.kreuzer@web.de">timo.kreuzer@web.de</a>&gt;</span><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">



  

<div bgcolor="#ffffff" text="#000000">
I agree with Dmitry on that matter. The brackets are bad. They only
hide possible bugs. I don&#39;t see any advantage. They don&#39;t add anything
for the compiler nor do they add anything to readability. IMO it&#39;s
easier to read with less braces.<br>
<br>
Timo<br>
<br>
Aleksey Bragin schrieb:
<div><div></div><div class="Wj3C7c"><blockquote type="cite">
  <pre>Good, let&#39;s discuss it developers-wide then, and add a result into  
the (to become official) Coding Style Guidelines for kernel-mode code.
The only thing I&#39;m bothered with is to keep the style consistent  
across kernel (and drivers, where possible). And right now bracing  
arguments of &amp;&amp; and || prevails.

I&#39;m eager to listen to other dev&#39;s opinion on that topic. You just  
showed one disadvantage of such method. Are there any advantages?


WBR,
Aleksey.

On Feb 16, 2009, at 8:47 PM, Dmitry Gorbachev wrote:

  </pre>
  <blockquote type="cite">
    <blockquote type="cite">
      <pre>No, it&#39;s just a matter of coding style used in the kernel.
      </pre>
    </blockquote>
    <pre>What is a logical basis for adopting this particular rule?  
Sometimes it is
not just a matter of preference.

These parentheses are unnecessary for humans, and if they are not  
needed for
compilers or some other tools, they are bad! Without them, the bug  
could be
noticed earlier.

Cheers,
Dmitry
    </pre>
  </blockquote>
  <pre>_______________________________________________
Ros-dev mailing list
<a href="mailto:Ros-dev@reactos.org" target="_blank">Ros-dev@reactos.org</a>
<a href="http://www.reactos.org/mailman/listinfo/ros-dev" target="_blank">http://www.reactos.org/mailman/listinfo/ros-dev</a>

  </pre>
</blockquote>
<br>
</div></div></div>

<br>_______________________________________________<br>
Ros-dev mailing list<br>
<a href="mailto:Ros-dev@reactos.org">Ros-dev@reactos.org</a><br>
<a href="http://www.reactos.org/mailman/listinfo/ros-dev" target="_blank">http://www.reactos.org/mailman/listinfo/ros-dev</a><br></blockquote></div><br>