Re: [ros-dev] [ros-diffs] [hyperion] 42530: modified base/setup/vmwinst/vmwinst.c modified base/setup/vmwinst/vmwinst.rbuild Implement VMWare detection for Visual C++ as well For cleaner code, use SEH instead of VEH, even if it means losing this pearl of ReactOS wisdom: /* Setup a vectored exception handler to protect the detection. Don't use SEH here so we notice the next time someone removes support for vectored exception handling from ros... */ (www.passiveaggressivecommits.com, brought to you by Arch Bl

[Aleksey Bragin]

On Aug 8, 2009, at 10:03 PM, [e-mail] wrote:
> Author: hyperion
> Date: Sat Aug  8 20:03:48 2009
> New Revision: 42530
>
> URL: http://svn.reactos.org/svn/reactos?rev=42530&view=rev
> Log:
> modified   base/setup/vmwinst/vmwinst.c
> modified   base/setup/vmwinst/vmwinst.rbuild
>    Implement VMWare detection for Visual C++ as well
>    For cleaner code, use SEH instead of VEH, even if it means  
> losing this pearl of ReactOS wisdom:
>    /* Setup a vectored exception handler to protect the  
>
> detection. Don't use SEH
>        here so we notice the next time someone removes support for  
> vectored
>        exception handling from ros... */
>
> (www.passiveaggressivecommits.com, brought to you by Arch  
> Blackmann!)
>    Of course, it also means trading our VEH bugs for our SEH bugs,  
> so I'm not sure if it was worth changing

This test should be added to the test suite which we have now (or  
maybe it is there already?). Putting various tests inside unrelated  
apps was a great idea back then but reactos evolved from that.

WBR,
Aleksey Bragin.