Re: [ros-dev] USetup meets NewInfLib

[Eric Kohl]

Hi Roel,

I just committed your changes as they fix some of the issues. Thanks for 
finding these bugs!

I also added a little change to the inf-parser that makes the parser 
stop reading as soon as it finds the first null character.


Regards,
Eric


Roel Messiant schrieb:
>   Hey,
>  
>  This one's mostly for Eric Kohl.
>  
>  Newinflib seems to be causing some issues for usetup, accessing memory 
>  it shouldn't.
>  Attached are some patches that solve this.
>  
>  The newinflib one fixes some pointer arithmetic, which ended up lying 
>  about a buffer size.
>  This was already fixed in the host code, so I just applied the same fix 
>  to the ros code.
>  
>  The usetup patch is a hackfix. The issue here is that usetup fetches a 
>  line from a section,
>  but the line is blank. Usetup treats it as a data line, and reading the 
>  data from it results
>  in NULL .. which usetup tries to dereference.
>  I just hackfixed that one because the code hasn't changed, so it must've 
>  worked fine with
>  the previous inflib. So the question end up as: is newinflib wrong here 
>  by not trying to skip
>  the blank line, or should usetup keep in mind such lines can exist.. or 
>  some third option?
>  
>  WBR,
>  
>  Roel Messiant
>  
>  PS: I know patches belong in bugzilla, but the perceived urgency on my 
>  side won the decision on where to post them.
>  
>  
>  ------------------------------------------------------------------------
>  
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev