Re: [ros-dev] [ros-diffs] [ion] 52596: [NTDLL]: More attempts at fixing up the loader, this time in the PE side of things.

[Alex Ionescu]

Because that's the convention I keep trying to make you enforce. It avoids confusion.

Yes, you will now argue 10 scenarios where this doesn't matter (such as below).

And by doing so, you will have proven my point:

1) You can avoid using (() || ()) if you know the 10 exceptions and operator precedence by
heart. (Aleksey Method)
or
2) You can always use (() || ()) and never have to worry about anything (in this context).
(The Sane Method).

If you'd like to enforce a coding style that requires people knowing K&R by heart,
go ahead, but I won't subscribe to it. KISS.

--
Best regards,
Alex Ionescu

On 2011-07-10, at 1:01 PM, Aleksey Bragin wrote:

>   
>  
>  -----Original Message----- From: ion(a)svn.reactos.org
>  Sent: Sunday, July 10, 2011 6:14 AM
>  To: ros-diffs(a)reactos.org
>  Subject: [ros-diffs] [ion] 52596: [NTDLL]: More attempts at fixing up the loader, this
> time in the PE side of things.
>  
>  Author: ion
>  Date: Sun Jul 10 02:14:29 2011
>  New Revision: 52596
>  
>     /* Check if we got at least one */
>  -    if (BoundEntry || ImportEntry)
>  +    if ((BoundEntry) || (ImportEntry))
>  
>  Could you enlighten me why do you add these redunandant braces?
>  
>  WBR,
>  Aleksey. 
>  
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev