[ros-dev] Re : Re : [ros-diffs] [sginsberg] 43789: - Replace broken implementation of HalpCalibrateStallExecution with a new implementation by a mysterious HAL ninja and myself. The old implementation calculated the stall count factor incorrectly and produced

[Sylvain Petreolle]

It was reported taking 10-20s in the past.
 Kind regards,
Sylvain Petreolle

----- Message d'origine ----
> De : Alex Ionescu [e-mail]
> À : ReactOS Development List [e-mail]
> Envoyé le : Mar 27 Octobre 2009, 14 h 15 min 53 s
> Objet : Re: [ros-dev] Re : [ros-diffs] [sginsberg] 43789: - Replace broken implementation of HalpCalibrateStallExecution with a new implementation by a mysterious HAL ninja and myself. The old implementation calculated the stall count factor incorrectly and produced
>
> And it continues to do its job today -- you added code telling UniATA  
> "wait between 500ms and 5seconds", and it's working fine in trunk.
>
> Why are people complaining "it takes UniATA up to 5 seconds to boot"  
> when this is exactly the code you intended to add?
>
> Also:
>
> "Maybe theres a better way to get this done, but it was enough for  
> testing and did its job well."
>
> Is now my all-time favourite quote, ever.
>
> I bet Hitler would've said the same at Nuremberg....
>
> On 2009-10-27, at 8:50 AM, Daniel Reimer wrote:
> > These timers were added because some SATA adapters are fucking slow in
> > initializing and uniata would continue too early for them and this
> > results in failures. Maybe theres a better way to get this done, but  
> > it
> > was enough for testing and did its job well.
> >
> > Alex Ionescu schrieb:
> > > The real problem is that UniATA is full of shit code from Aleksey  
> > > that
> > > does things like StallExecution(100000). Microsoft says not to go  
> > > over
> > > 50, but hey, this is ReactOS....reading docs?? HAHAHA!!
> > >
> > > I've looked over Stefan's code and it is perfect, and sets a correct
> > > stall factor.
> > >
> > > On 2009-10-27, at 8:24 AM, Sylvain Petreolle wrote:
> > > > It was present here in VirtualBox  3.0.8 for some time
> > > > and disappeared after Stefan's change for exception management.
> > > > Kind regards,
> > > > Sylvain Petreolle
> > > >
> > > > *De :* Gabriel ilardi
> > > > >
> > > >
> > > > *À :* ros-dev >
> > > >    *Envoyé le :* Mar 27 Octobre 2009, 11 h 44 min 19 s
> > > >    *Objet :* Re: [ros-dev] [ros-diffs] [sginsberg] 43789: - Replace
> > > >    broken implementation of HalpCalibrateStallExecution with a new
> > > >    implementation by a mysterious HAL ninja and myself. The old
> > > >    implementation calculated the stall count factor incorrectly and
> > > >    produced
> > > >
> > > > Hi Johannes,
> > > >
> > > > It wasn't present for VirtualBox though, at least for me.
> > > >
> > > > Best regards,
> > > >    Gabriel.
> > > > > Date: Tue, 27 Oct 2009 11:34:03 +0100
> > > > > From: [e-mail] 
> > > > > To: [e-mail] 
> > > > > Subject: Re: [ros-dev] [ros-diffs] [sginsberg] 43789: - Replace
> > > >
> > > > broken implementation of HalpCalibrateStallExecution with a new
> > > >    implementation by a mysterious HAL ninja and myself. The old
> > > >    implementation calculated the stall count factor incorrectly and
> > > >    produced bogus resu
> > > > > Gabriel ilardi schrieb:
> > > > > > In second stage when loading UniATA, it stays there for
> > > >
> > > > about 4-5
> > > > > > seconds, there was no delay before.
> > > > >
> > > > > Hi,
> > > > >
> > > > > The UniATA delay in 2nd stage was already present before that
> > > >
> > > > commit.
> > > > > However, only in VMware.
> > > > > > Best regards,
> > > > > > Gabriel.
> > > > >
> > > > > Best regards,
> > > > > Johannes Anderwald
> > > > >
> > > > > Ros-dev mailing list
> > > > > [e-mail] 
> > > > > http://www.reactos.org/mailman/listinfo/ros-dev
> > > >
> > > > Conosci il tuo Messenger? Scopri tutte le novità
> > > >
> > > > Ros-dev mailing list
> > > > [e-mail] 
> > > > http://www.reactos.org/mailman/listinfo/ros-dev
> > >
> > > Best regards,
> > > Alex Ionescu
> > >
> > > Ros-dev mailing list
> > > [e-mail]
> > > http://www.reactos.org/mailman/listinfo/ros-dev
> >
> > Ros-dev mailing list
> > [e-mail]
> > http://www.reactos.org/mailman/listinfo/ros-dev
>
> Best regards,
> Alex Ionescu
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev