Re: [ros-dev] Merging our x86 HALs

[Colin Finck]

Thanks for the numerous replies! Let's stop at this point and not talk
this topic to death ;)
Even if we don't know yet how many HALs are to be kept, we agree on
reducing the number of HALs from the current 6. There is also no point
in a final decision on this until we have code to back it.

I have begun by deduplicating some code:
https://github.com/reactos/reactos/pull/193
It has also turned out that HalpCalibrateStallExecution was not broken
in the APIC HAL, but relied on the I/O APIC. Unlike the Local APIC, this
one is disabled by default in VirtualBox. When enabling it, the APIC HAL
fails at a later stage.
However, we may still merge both implementations of
HalpCalibrateStallExecution into a generic one at some point.


Cheers,

Colin