Re: [ros-dev] [ros-diffs] [jimtabor] 37436: - Fixes bug 3864. While I was at it I fixed most of the gdi max bit max info sizes too. - Added notes for the SEH abuse in win32k dibobj.c. - Tested WinMerge 2.10.2, AbiWord 2.4.1, Firefox 1.5.0.3 and wine

[James Tabor]

These are correct changes.
On Tue, Nov 18, 2008 at 10:34 AM, Aleksey Bragin <aleksey(a)reactos.org> wrote:
>   May I ask why those if (!Info) checks are required? To
> me it makes no
>  sense to call those APIs with the cruicial, mandatory working (and in
>  one case the only) parameter being NULL, and I would put an ASSERT
>  (Info) there to catch bad callers and fix them.
>  WBR,
>  Aleksey.
>  On Nov 18, 2008, at 8:36 AM, jimtabor(a)svn.reactos.org wrote:
> >   Author: jimtabor
> >  Date: Mon Nov 17 23:36:19 2008
> >  New Revision: 37436
> >   UINT
> >   FASTCALL
> >   DIB_BitmapMaxBitsSize( PBITMAPINFO Info, UINT ScanLines )
> >   {
> >       UINT MaxBits = 0;
> >  +
> >  +    if (!Info) return 0;
> >  +UINT
> >  +FASTCALL
> >  +DIB_BitmapBitsSize( PBITMAPINFO Info )
> >  +{
> >  +  UINT Ret;
> >  +
> >  +  if (!Info) return 0; 
>