caemyr(a)myopera.com wrote:
Should i mention again, that i`m not a dev and i never
posed as one?
You could simply set it as optional flag.
You could wait with it at least after the release is done and we can concentrate on new
changes.
You could push this change with, for example, major compiler change that would block
rebuilding anyway.
Olaf, I announced the change! You did not respond! Please tell me how
long do I have to wait for a response? A week? Two weeks? Six months?
Since you insist on not being a developer, I attached a special class2.c
file which is configured to use the old geometry. Replace the
drivers\storage\class\class2\class2.c file with the attached one and
build ReactOS and you are using the old geometry again.
There could be several more things possibly done to
minimize the impact of this.
You used neither. This is what i`m angry about. Look at CMake, how long the transition is
taking place, how are its effects taken into consideration. This change needed at least
10% of it. It got none and i cant stop thinking its simply because most of devs will even
know its there. Its a pity that this does not extend to all of us:/
Please do not compare my tiny patch with the CMake changes.
Lets finish the discussion. The odds are all against me. We will simply need to live with
its effects. I just hope that my pessimism is not correct. I hate being right:/
End of Drama. Sorry to everyone, especially Eric, who is feeling offended by my
outbreak,
I cannot promise it wont happen in the future again, so i`m not doing so.
I am not feeling offended at all.
Regards
Eric