Re: [ros-dev] [ros-diffs] [jgardou] 63700: [NTOSKRNL] - Use ZwSetValueKey instead of NtSetValueKey - Properly probe and copy parameters when NtSetValueKey is called from UMode CORE-7738 #resolve #comment fixed in r63700

[Aleksey Bragin]

http://www.osronline.com/article.cfm?id=257
That article was the first I read about Nt vs Zw difference back then. 
It's quite helpful, and explains it nicely IMO.
And saves precious Alex's time :-)

Regards,
Aleksey

On 08.07.2014 23:58, Alex Ionescu wrote:
> Calling Nt in those functions was by design, and is how Windows does 
> it as well. I can explain Nt vs Zw (for the 100th time) as needed, but 
> for now, I'd kindly ask for a revert please.
>
> Second, the new code does not conform to formatting and style 
> guidelines. Please fix the code before comitting.
>
> Best regards,
> Alex Ionescu
>
> On Tue, Jul 8, 2014 at 11:42 AM, <[e-mail] 
> mailto:[e-mail]> wrote:
> Author: jgardou
> Date: Tue Jul  8 18:42:20 2014
> New Revision: 63700
>
> URL: http://svn.reactos.org/svn/reactos?rev=63700&view=rev
> Log:
> [NTOSKRNL]
>  - Use ZwSetValueKey instead of NtSetValueKey
>  - Properly probe and copy parameters when NtSetValueKey is called
> from UMode
> CORE-7738 #resolve #comment fixed in r63700