Re: [ros-dev] [ros-diffs] [reactos] 01/01: [SETUP] Remove FSDs which have broken dismount implementation. This avoids issues when these partitions are formatted to FAT for setup.

[David Quintana (gigaherz)]

So in the future, when we DO want to support them in the setup program,
we'll need to implement dismounting in those drivers, and then they can be
added back to the cd.

On 18 December 2017 at 10:25, 7th Element <7element(a)mail.bg> wrote:

>   We don’t have them at the moment, but we hope for the
> future. This will
>  also limit formatting partitions. If you want to setup your hdd with
>  several FSs (like you usually do on Linux for example) and then install on
>  one of them, or want to read some files (drivers) from such supported FSs...
>
>  BR,
>  Peter
>
>  On 18 Dec 2017, at 11:08, David Quintana (gigaherz) <gigaherz(a)gmail.com>
>  wrote:
>
>  We can't boot from those FSs either way, since we don't have boot sectors
>  for them. This only affects the ability for the setup program to access
>  those partitions and format them.
>
>  On 18 December 2017 at 10:02, 7th Element <7element(a)mail.bg> wrote:
>
> >   Hi Pierre,
> >
> >  Isn’t this change going to remove ability to boot from those FSs?
> >
> >  BR,
> >  Peter
> >
> > >   On 18 Dec 2017, at 0:16, Pierre Schweitzer
> > > <pierre(a)reactos.org> wrote:
> > >
> > >  https://git.reactos.org/?p=reactos.git;a=commitdiff;h=806cd1 
> > 6328799771b89397f5c51a3d46884bce0a
> > >  
> > >  commit 806cd16328799771b89397f5c51a3d46884bce0a
> > >  Author: Pierre Schweitzer <pierre(a)reactos.org>
> > >  AuthorDate: Sun Dec 17 23:13:56 2017 +0100
> > >
> > >     [SETUP] Remove FSDs which have broken dismount implementation.
> > >     This avoids issues when these partitions are formatted to FAT for 
> >  setup.
> > >  
> > >     For now, this commit doesn't change anything, but once 
> >  IopParseDevice hack
> > >      gets removed, this will make a difference!
> > >
> > >     CORE-6305
> > >  ---
> > >  boot/bootdata/txtsetup.sif               | 2 --
> > >  drivers/filesystems/btrfs/CMakeLists.txt | 2 +-
> > >  drivers/filesystems/ntfs/CMakeLists.txt  | 2 +-
> > >  3 files changed, 2 insertions(+), 4 deletions(-)
> > >
> > >  diff --git a/boot/bootdata/txtsetup.sif b/boot/bootdata/txtsetup.sif
> > >  index 3ea62974b5..822c19c8c8 100644
> > >  --- a/boot/bootdata/txtsetup.sif
> > >  +++ b/boot/bootdata/txtsetup.sif
> > >  @@ -52,7 +52,6 @@ usbstor.sys=,,,,,,x,,,,,,4
> > >  kbdhid.sys=,,,,,,,,,,,,4
> > >  kbdclass.sys=,,,,,,x,,,,,,4
> > >  l_intl.nls=,,,,,,,,,,,,2
> > >  -ntfs.sys=,,,,,,,,,,,,4
> > >  pci.sys=,,,,,,,,,,,,4
> > >  scsiport.sys=,,,,,,x,,,,,,4
> > >  storport.sys=,,,,,,x,,,,,,4
> > >  @@ -69,7 +68,6 @@ ntdll.dll=,,,,,,,,,,,,2
> > >  wmilib.sys=,,,,,,,,,,,,4
> > >  ksecdd.sys=,,,,,,,,,,,,4
> > >  mountmgr.sys=,,,,,,x,,,,,,4
> > >  -btrfs.sys=,,,,,,x,,,,,,4
> > >  reiserfs.sys=,,,,,,x,,,,,,4
> > >  ffs.sys=,,,,,,x,,,,,,4
> > >  udfs.sys=,,,,,,x,,,,,,4
> > >  diff --git a/drivers/filesystems/btrfs/CMakeLists.txt 
> > b/drivers/filesystems/btrfs/CMakeLists.txt
> > >   index 65e61d255a..123c9f0522 100644
> > >  --- a/drivers/filesystems/btrfs/CMakeLists.txt
> > >  +++ b/drivers/filesystems/btrfs/CMakeLists.txt
> > >  @@ -41,4 +41,4 @@ add_definitions(-D__KERNEL__)
> > >  set_module_type(btrfs kernelmodedriver)
> > >  target_link_libraries(btrfs rtlver ntoskrnl_vista zlib_solo wdmguid 
> >  ${PSEH_LIB})
> > >   add_importlibs(btrfs ntoskrnl hal)
> > >  -add_cd_file(TARGET btrfs DESTINATION reactos/system32/drivers NO_CAB 
> >  FOR all)
> > >   +add_cd_file(TARGET btrfs DESTINATION
> > > reactos/system32/drivers FOR all)
> > >  diff --git a/drivers/filesystems/ntfs/CMakeLists.txt 
> > b/drivers/filesystems/ntfs/CMakeLists.txt
> > >   index 0b1af78947..5a193b449d 100644
> > >  --- a/drivers/filesystems/ntfs/CMakeLists.txt
> > >  +++ b/drivers/filesystems/ntfs/CMakeLists.txt
> > >  @@ -25,4 +25,4 @@ set_module_type(ntfs kernelmodedriver)
> > >  target_link_libraries(ntfs ${PSEH_LIB})
> > >  add_importlibs(ntfs ntoskrnl hal)
> > >  add_pch(ntfs ntfs.h SOURCE)
> > >  -add_cd_file(TARGET ntfs DESTINATION reactos/system32/drivers NO_CAB 
> >  FOR all)
> > >   +add_cd_file(TARGET ntfs DESTINATION
> > > reactos/system32/drivers FOR all)
> > >
> > >  
> >
> >  _______________________________________________
> >  Ros-dev mailing list
> >  Ros-dev(a)reactos.org
> >  http://www.reactos.org/mailman/listinfo/ros-dev 
>
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev
>
>
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev
>