Re: [ros-dev] [ros-diffs] [ekohl] 23521: - Implement ScmStartServiceA and revert the last modification of StartServiceA. - Fix EnumServicesStatusExW.

[Hervé Poussineau]

Hi,
> Subject: [ros-diffs] [ekohl] 23521:
> Implement ScmStartServiceA and revert the last modification of

StartServiceA.
> Fix EnumServicesStatusExW.

We now have an exact code duplication between StartServiceA/StartServiceW
(except strlen/wcslen and strcpy/wcscpy) and
ScmrStartServiceA/ScmrStartServiceW.
I don't think it's a good thing because we will have some problems to keep
the code in sync.

I did r23519 to prevent this code duplication and because
ScmrStartServiceA() was not called except in StartServiceA.
By the way, I also implemented argument conversion between ANSI and Unicode
in StartServiceA before calling StartServiceW, which meant that arguments
were ignored only in ScmrStartServiceW. Now, you have 2 places to take care
of them (ScmrStartServiceA/W)...

That was just to say my feeling...

Hervé