Hi Richard! Long time!
Richard wrote:
My Thoughts:
If code could possibly break trunk, even for a few hours, it should be branched. The developer should work on that code, test it thoroughly, and ask others to test, once it's confirmed working, merge it back to trunk. Simple enough. The problem is many developers only halfway test that a given change works. Or they switch tasks in the middle of implementing something, leaving it half unimplemented.
That is true, some of our devs do not have enough hardware to test. Some just use emulators.
The issue with branching to begin with was the fact that we had 38924384238 branches with XYZ feature that were incomplete, because developers left, got bored and lost interest, or otherwise. Branching should be done on the short term. Instead of doing an entire win32k rewrite in a branch, rewrite a given function at a time. If you must rewrite several functions, do so in your local tree and only commit when things are working. Better yet: don't do large rewrites at all.
I'm currently using concurrent functionality. So it is seamless and unintrusive.
FYI the ROS isos on svn.reactos.org STILL fail to install properly on my vmware machine. Formatting the virtual drive and attempting to install crashes setup, installing without formatting results in locking at the boot screen with just the little bar going, and booting the livecd also results in a lock on the boot screen. These types of regressions should not exist.
Regards, Richard Campbell