Re: [ros-dev] [ros-diffs] [gedmurphy] 52364: [BROWSEUI] - Set the prototypes to be long instead of LONG. This only worked in rbuild previously because WIDL incorrectly generates a LONG for long types. - define SHANDLE_PTR a...

[Colin Finck]

gedmurphy(a)svn.reactos.org wrote:
>   +// WIDL temp hack : [...] 
Even though we all like to see a full MSVC build in the future, does 
this really justify such an even bigger hack on top of the existing 
ones? Would a proper fix really require that much more time?

If we don't want to end up in a new mess, this pretty much forces 
someone to fix it in the coming days or the hack/commit will be 
forgotten again. I'm certain about this, because nobody on #reactos-dev 
really knew the reason behind the older __ROS_LONG64__ hack either.

Alternatively, you could open a detailed bug report about this issue and 
assign some CMake people to it. But in any case, such hacks should be 
tracked in our Bugzilla, in particular when more information about a 
solution is known already.


- Colin