Re: [ros-dev] [ros-diffs] [jgardou] 53481: [WIDL] - reenable -Oif flag, it's too good to be disabled With this commit, advapi32:service winetest suffers only 2 failures.

Yes! Lets hide the bugs, so we can assume ReactOS is fixed!

Please excuse my sarcasm. I couldn't really stop myself.

In my opinion, useless results do happen when you reboot VM that many times until it
returns no failures. Such results are then, useless. If there is an error, it should be
fixed. It doesnt have to be advapi32 error, but still.

Best regards

On Sun, 28 Aug 2011 20:43 +0200, "Eric Kohl" <eric.kohl(a)t-online.de>
wrote:
>   Hello Jérôme,
>  
>  your patch looks very good! I hope Alexandre accepts it without a length 
>  discussion. ;-)
>  
>  I just ran another set of "advapi32_winetest service" tests on my 
>  machine. Both tests, with and without -Oif option return the same 
>  results: 2 failures! Great!
>  
>  And as far as I can see our test machines return bogus results again. I 
>  guess we really need to reboot the test machines for each test, 
>  otherwise the results are useless. :-/ 
With best regards
Caemyr