The stuff that could be done with compile time defines, seems to be used only in a few places (if CHECK_PAGED_CODE_RTL is not counted) I found the following files: atom.c, bootdata.c, debug.c, env.c, except.c, exception.c, heap.c, path.c, ppb.c, rangelist.c, registry.c, res.c, sid.c, thread.c, unicode.c That's 15 out of 57 files. IMO we should keep the rest in "rtl" and only move the parts that need conditional compilation.
Timo
Aleksey Bragin schrieb:
I knew about this post-factum, so let's gather opinions.
Advantage: It's like NT does, less hacks, possible removal of libsupp stuff in ntoskrnl, freeldr, ntdll, etc (which I actually thought would be done in the same commit).
Disadvantage: To be proper, you need a bootloader RTL too, otherwise RTL will still contain "necessitating hacks" aka libsupp stuff. This is gonna make at least 3x time RTL compilation. (thankfully / sadly we don't test it directly).
WBR, Aleksey.
On Oct 15, 2008, at 10:02 PM, Alex Ionescu wrote:
Well, you just removed the one thing ReactOS did different from NT and that I thought was really revolutionary and innovative, because it saves on compile time. It's funny, because I've been trying to sell this as a better approach to building RTL (It's built at least 4 times in the real NT tree, I think -- loader, user-mode tools/testing, kernel, user-mode).
Best regards, Alex Ionescu
Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev